database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-02 09:02:37 +03:00
Code Activity

Fix assignment to array of domain over composite, redux.

Browse Source 
Commit 3e310d837 taught isAssignmentIndirectionExpr() to look through
CoerceToDomain nodes.  That's not sufficient, because since commit
04fe805a1 it's been possible for the planner to simplify
CoerceToDomain to RelabelType when the domain has no constraints
to enforce.  So we need to look through RelabelType too.

Per bug #17897 from Alexander Lakhin.  Although 3e310d837 was
back-patched to v11, it seems sufficient to apply this change
to v12 and later, since 04fe805a1 came in in v12.

Dmitry Dolgov

Discussion: https://postgr.es/m/17897-4216c546c3874044@postgresql.org
This commit is contained in:
Tom Lane
2023-04-15 12:01:39 -04:00
parent d6b5dee42d
commit 064eb89e83
3 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/executor/execExpr.c
View File

@ -3225,8 +3225,8 @@ ExecInitSubscriptingRef(ExprEvalStep *scratch, SubscriptingRef *sbsref,
* trees in which each level of assignment has its own CaseTestExpr, and the
* recursive structure appears within the newvals or refassgnexpr field.
* There is an exception, though: if the array is an array-of-domain, we will
* have a CoerceToDomain as the refassgnexpr, and we need to be able to look
* through that.
* have a CoerceToDomain or RelabelType as the refassgnexpr, and we need to
* be able to look through that.
*/
static bool
isAssignmentIndirectionExpr(Expr *expr)
@ -3253,6 +3253,12 @@ isAssignmentIndirectionExpr(Expr *expr)
return isAssignmentIndirectionExpr(cd->arg);
}
else if (IsA(expr, RelabelType))
{
RelabelType *r = (RelabelType *) expr;
return isAssignmentIndirectionExpr(r->arg);
}
return false;
}