mirror of
https://github.com/postgres/postgres.git
synced 2025-08-14 02:22:38 +03:00
Extend object-access hook machinery to support post-alter events.
This also slightly widens the scope of what we support in terms of post-create events. KaiGai Kohei, with a few changes, mostly to the comments, by me
This commit is contained in:
@@ -19,6 +19,7 @@
|
||||
#include "catalog/dependency.h"
|
||||
#include "catalog/indexing.h"
|
||||
#include "catalog/namespace.h"
|
||||
#include "catalog/objectaccess.h"
|
||||
#include "catalog/pg_collation.h"
|
||||
#include "catalog/pg_conversion.h"
|
||||
#include "catalog/pg_event_trigger.h"
|
||||
@@ -281,6 +282,8 @@ AlterObjectRename_internal(Relation rel, Oid objectId, const char *new_name)
|
||||
simple_heap_update(rel, &oldtup->t_self, newtup);
|
||||
CatalogUpdateIndexes(rel, newtup);
|
||||
|
||||
InvokeObjectPostAlterHook(classId, objectId, 0);
|
||||
|
||||
/* Release memory */
|
||||
pfree(values);
|
||||
pfree(nulls);
|
||||
@@ -657,6 +660,8 @@ AlterObjectNamespace_internal(Relation rel, Oid objid, Oid nspOid)
|
||||
changeDependencyFor(classId, objid,
|
||||
NamespaceRelationId, oldNspOid, nspOid);
|
||||
|
||||
InvokeObjectPostAlterHook(classId, objid, 0);
|
||||
|
||||
return oldNspOid;
|
||||
}
|
||||
|
||||
@@ -934,4 +939,6 @@ AlterObjectOwner_internal(Relation rel, Oid objectId, Oid new_ownerId)
|
||||
pfree(nulls);
|
||||
pfree(replaces);
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(classId, objectId, 0);
|
||||
}
|
||||
|
@@ -27,6 +27,7 @@
|
||||
#include "catalog/heap.h"
|
||||
#include "catalog/index.h"
|
||||
#include "catalog/namespace.h"
|
||||
#include "catalog/objectaccess.h"
|
||||
#include "catalog/toasting.h"
|
||||
#include "commands/cluster.h"
|
||||
#include "commands/matview.h"
|
||||
@@ -481,7 +482,7 @@ check_index_is_clusterable(Relation OldHeap, Oid indexOid, bool recheck, LOCKMOD
|
||||
* otherwise concurrent executions of RelationGetIndexList could miss indexes.
|
||||
*/
|
||||
void
|
||||
mark_index_clustered(Relation rel, Oid indexOid)
|
||||
mark_index_clustered(Relation rel, Oid indexOid, bool is_internal)
|
||||
{
|
||||
HeapTuple indexTuple;
|
||||
Form_pg_index indexForm;
|
||||
@@ -541,6 +542,10 @@ mark_index_clustered(Relation rel, Oid indexOid)
|
||||
simple_heap_update(pg_index, &indexTuple->t_self, indexTuple);
|
||||
CatalogUpdateIndexes(pg_index, indexTuple);
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHookArg(IndexRelationId, thisIndexOid, 0,
|
||||
InvalidOid, is_internal);
|
||||
|
||||
heap_freetuple(indexTuple);
|
||||
}
|
||||
|
||||
@@ -569,7 +574,7 @@ rebuild_relation(Relation OldHeap, Oid indexOid,
|
||||
|
||||
/* Mark the correct index as clustered */
|
||||
if (OidIsValid(indexOid))
|
||||
mark_index_clustered(OldHeap, indexOid);
|
||||
mark_index_clustered(OldHeap, indexOid, true);
|
||||
|
||||
/* Remember if it's a system catalog */
|
||||
is_system_catalog = IsSystemRelation(OldHeap);
|
||||
@@ -590,7 +595,8 @@ rebuild_relation(Relation OldHeap, Oid indexOid,
|
||||
* rebuild the target's indexes and throw away the transient table.
|
||||
*/
|
||||
finish_heap_swap(tableOid, OIDNewHeap, is_system_catalog,
|
||||
swap_toast_by_content, false, frozenXid, frozenMulti);
|
||||
swap_toast_by_content, false, true,
|
||||
frozenXid, frozenMulti);
|
||||
}
|
||||
|
||||
|
||||
@@ -1120,6 +1126,7 @@ copy_heap_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex,
|
||||
static void
|
||||
swap_relation_files(Oid r1, Oid r2, bool target_is_pg_class,
|
||||
bool swap_toast_by_content,
|
||||
bool is_internal,
|
||||
TransactionId frozenXid,
|
||||
MultiXactId frozenMulti,
|
||||
Oid *mapped_tables)
|
||||
@@ -1283,6 +1290,15 @@ swap_relation_files(Oid r1, Oid r2, bool target_is_pg_class,
|
||||
CacheInvalidateRelcacheByTuple(reltup2);
|
||||
}
|
||||
|
||||
/*
|
||||
* Post alter hook for modified relations. The change to r2 is always
|
||||
* internal, but r1 depends on the invocation context.
|
||||
*/
|
||||
InvokeObjectPostAlterHookArg(RelationRelationId, r1, 0,
|
||||
InvalidOid, is_internal);
|
||||
InvokeObjectPostAlterHookArg(RelationRelationId, r2, 0,
|
||||
InvalidOid, true);
|
||||
|
||||
/*
|
||||
* If we have toast tables associated with the relations being swapped,
|
||||
* deal with them too.
|
||||
@@ -1298,6 +1314,7 @@ swap_relation_files(Oid r1, Oid r2, bool target_is_pg_class,
|
||||
relform2->reltoastrelid,
|
||||
target_is_pg_class,
|
||||
swap_toast_by_content,
|
||||
is_internal,
|
||||
frozenXid,
|
||||
frozenMulti,
|
||||
mapped_tables);
|
||||
@@ -1388,6 +1405,7 @@ swap_relation_files(Oid r1, Oid r2, bool target_is_pg_class,
|
||||
relform2->reltoastidxid,
|
||||
target_is_pg_class,
|
||||
swap_toast_by_content,
|
||||
is_internal,
|
||||
InvalidTransactionId,
|
||||
InvalidMultiXactId,
|
||||
mapped_tables);
|
||||
@@ -1427,6 +1445,7 @@ finish_heap_swap(Oid OIDOldHeap, Oid OIDNewHeap,
|
||||
bool is_system_catalog,
|
||||
bool swap_toast_by_content,
|
||||
bool check_constraints,
|
||||
bool is_internal,
|
||||
TransactionId frozenXid,
|
||||
MultiXactId frozenMulti)
|
||||
{
|
||||
@@ -1444,8 +1463,8 @@ finish_heap_swap(Oid OIDOldHeap, Oid OIDNewHeap,
|
||||
*/
|
||||
swap_relation_files(OIDOldHeap, OIDNewHeap,
|
||||
(OIDOldHeap == RelationRelationId),
|
||||
swap_toast_by_content, frozenXid, frozenMulti,
|
||||
mapped_tables);
|
||||
swap_toast_by_content, is_internal,
|
||||
frozenXid, frozenMulti, mapped_tables);
|
||||
|
||||
/*
|
||||
* If it's a system catalog, queue an sinval message to flush all
|
||||
@@ -1526,13 +1545,13 @@ finish_heap_swap(Oid OIDOldHeap, Oid OIDNewHeap,
|
||||
snprintf(NewToastName, NAMEDATALEN, "pg_toast_%u",
|
||||
OIDOldHeap);
|
||||
RenameRelationInternal(newrel->rd_rel->reltoastrelid,
|
||||
NewToastName);
|
||||
NewToastName, true);
|
||||
|
||||
/* ... and its index too */
|
||||
snprintf(NewToastName, NAMEDATALEN, "pg_toast_%u_index",
|
||||
OIDOldHeap);
|
||||
RenameRelationInternal(toastidx,
|
||||
NewToastName);
|
||||
NewToastName, true);
|
||||
}
|
||||
relation_close(newrel, NoLock);
|
||||
}
|
||||
|
@@ -997,6 +997,8 @@ RenameDatabase(const char *oldname, const char *newname)
|
||||
simple_heap_update(rel, &newtup->t_self, newtup);
|
||||
CatalogUpdateIndexes(rel, newtup);
|
||||
|
||||
InvokeObjectPostAlterHook(DatabaseRelationId, db_id, 0);
|
||||
|
||||
/*
|
||||
* Close pg_database, but keep lock till commit.
|
||||
*/
|
||||
@@ -1234,6 +1236,9 @@ movedb(const char *dbname, const char *tblspcname)
|
||||
/* Update indexes */
|
||||
CatalogUpdateIndexes(pgdbrel, newtuple);
|
||||
|
||||
InvokeObjectPostAlterHook(DatabaseRelationId,
|
||||
HeapTupleGetOid(newtuple), 0);
|
||||
|
||||
systable_endscan(sysscan);
|
||||
|
||||
/*
|
||||
@@ -1431,6 +1436,9 @@ AlterDatabase(AlterDatabaseStmt *stmt, bool isTopLevel)
|
||||
/* Update indexes */
|
||||
CatalogUpdateIndexes(rel, newtuple);
|
||||
|
||||
InvokeObjectPostAlterHook(DatabaseRelationId,
|
||||
HeapTupleGetOid(newtuple), 0);
|
||||
|
||||
systable_endscan(scan);
|
||||
|
||||
/* Close pg_database, but keep lock till commit */
|
||||
@@ -1570,6 +1578,8 @@ AlterDatabaseOwner(const char *dbname, Oid newOwnerId)
|
||||
newOwnerId);
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(DatabaseRelationId, HeapTupleGetOid(tuple), 0);
|
||||
|
||||
systable_endscan(scan);
|
||||
|
||||
/* Close pg_database, but keep lock till commit */
|
||||
|
@@ -412,6 +412,9 @@ AlterEventTrigger(AlterEventTrigStmt *stmt)
|
||||
simple_heap_update(tgrel, &tup->t_self, tup);
|
||||
CatalogUpdateIndexes(tgrel, tup);
|
||||
|
||||
InvokeObjectPostAlterHook(EventTriggerRelationId,
|
||||
trigoid, 0);
|
||||
|
||||
/* clean up */
|
||||
heap_freetuple(tup);
|
||||
heap_close(tgrel, RowExclusiveLock);
|
||||
@@ -507,6 +510,9 @@ AlterEventTriggerOwner_internal(Relation rel, HeapTuple tup, Oid newOwnerId)
|
||||
changeDependencyOnOwner(EventTriggerRelationId,
|
||||
HeapTupleGetOid(tup),
|
||||
newOwnerId);
|
||||
|
||||
InvokeObjectPostAlterHook(EventTriggerRelationId,
|
||||
HeapTupleGetOid(tup), 0);
|
||||
}
|
||||
|
||||
/*
|
||||
|
@@ -2573,6 +2573,8 @@ AlterExtensionNamespace(List *names, const char *newschema)
|
||||
changeDependencyFor(ExtensionRelationId, extensionOid,
|
||||
NamespaceRelationId, oldNspOid, nspOid);
|
||||
|
||||
InvokeObjectPostAlterHook(ExtensionRelationId, extensionOid, 0);
|
||||
|
||||
return extensionOid;
|
||||
}
|
||||
|
||||
@@ -2856,6 +2858,8 @@ ApplyExtensionUpdates(Oid extensionOid,
|
||||
recordDependencyOn(&myself, &otherext, DEPENDENCY_NORMAL);
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(ExtensionRelationId, extensionOid, 0);
|
||||
|
||||
/*
|
||||
* Finally, execute the update script file
|
||||
*/
|
||||
@@ -2969,6 +2973,8 @@ ExecAlterExtensionContentsStmt(AlterExtensionContentsStmt *stmt)
|
||||
extension_config_remove(extension.objectId, object.objectId);
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(ExtensionRelationId, extension.objectId, 0);
|
||||
|
||||
/*
|
||||
* If get_object_address() opened the relation for us, we close it to keep
|
||||
* the reference count correct - but we retain any locks acquired by
|
||||
|
@@ -241,6 +241,9 @@ AlterForeignDataWrapperOwner_internal(Relation rel, HeapTuple tup, Oid newOwnerI
|
||||
HeapTupleGetOid(tup),
|
||||
newOwnerId);
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(ForeignDataWrapperRelationId,
|
||||
HeapTupleGetOid(tup), 0);
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -349,6 +352,9 @@ AlterForeignServerOwner_internal(Relation rel, HeapTuple tup, Oid newOwnerId)
|
||||
changeDependencyOnOwner(ForeignServerRelationId, HeapTupleGetOid(tup),
|
||||
newOwnerId);
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(ForeignServerRelationId,
|
||||
HeapTupleGetOid(tup), 0);
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -764,6 +770,8 @@ AlterForeignDataWrapper(AlterFdwStmt *stmt)
|
||||
}
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(ForeignDataWrapperRelationId, fdwId, 0);
|
||||
|
||||
heap_close(rel, RowExclusiveLock);
|
||||
|
||||
return fdwId;
|
||||
@@ -994,6 +1002,8 @@ AlterForeignServer(AlterForeignServerStmt *stmt)
|
||||
simple_heap_update(rel, &tp->t_self, tp);
|
||||
CatalogUpdateIndexes(rel, tp);
|
||||
|
||||
InvokeObjectPostAlterHook(ForeignServerRelationId, srvId, 0);
|
||||
|
||||
heap_freetuple(tp);
|
||||
|
||||
heap_close(rel, RowExclusiveLock);
|
||||
|
@@ -1169,6 +1169,8 @@ AlterFunction(AlterFunctionStmt *stmt)
|
||||
simple_heap_update(rel, &tup->t_self, tup);
|
||||
CatalogUpdateIndexes(rel, tup);
|
||||
|
||||
InvokeObjectPostAlterHook(ProcedureRelationId, funcOid, 0);
|
||||
|
||||
heap_close(rel, NoLock);
|
||||
heap_freetuple(tup);
|
||||
|
||||
|
@@ -198,8 +198,8 @@ ExecRefreshMatView(RefreshMatViewStmt *stmt, const char *queryString,
|
||||
* Swap the physical files of the target and transient tables, then
|
||||
* rebuild the target's indexes and throw away the transient table.
|
||||
*/
|
||||
finish_heap_swap(matviewOid, OIDNewHeap, false, false, true, RecentXmin,
|
||||
ReadNextMultiXactId());
|
||||
finish_heap_swap(matviewOid, OIDNewHeap, false, false, true, true,
|
||||
RecentXmin, ReadNextMultiXactId());
|
||||
|
||||
RelationCacheInvalidateEntry(matviewOid);
|
||||
}
|
||||
|
@@ -1374,6 +1374,9 @@ storeOperators(List *opfamilyname, Oid amoid,
|
||||
referenced.objectSubId = 0;
|
||||
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
|
||||
}
|
||||
/* Post create hook of this access method operator */
|
||||
InvokeObjectPostCreateHook(AccessMethodOperatorRelationId,
|
||||
entryoid, 0);
|
||||
}
|
||||
|
||||
heap_close(rel, RowExclusiveLock);
|
||||
@@ -1473,6 +1476,9 @@ storeProcedures(List *opfamilyname, Oid amoid,
|
||||
referenced.objectSubId = 0;
|
||||
recordDependencyOn(&myself, &referenced, DEPENDENCY_AUTO);
|
||||
}
|
||||
/* Post create hook of access method procedure */
|
||||
InvokeObjectPostCreateHook(AccessMethodProcedureRelationId,
|
||||
entryoid, 0);
|
||||
}
|
||||
|
||||
heap_close(rel, RowExclusiveLock);
|
||||
|
@@ -21,6 +21,7 @@
|
||||
#include "catalog/dependency.h"
|
||||
#include "catalog/indexing.h"
|
||||
#include "catalog/namespace.h"
|
||||
#include "catalog/objectaccess.h"
|
||||
#include "catalog/pg_namespace.h"
|
||||
#include "commands/dbcommands.h"
|
||||
#include "commands/schemacmds.h"
|
||||
@@ -240,6 +241,8 @@ RenameSchema(const char *oldname, const char *newname)
|
||||
simple_heap_update(rel, &tup->t_self, tup);
|
||||
CatalogUpdateIndexes(rel, tup);
|
||||
|
||||
InvokeObjectPostAlterHook(NamespaceRelationId, HeapTupleGetOid(tup), 0);
|
||||
|
||||
heap_close(rel, NoLock);
|
||||
heap_freetuple(tup);
|
||||
|
||||
@@ -376,4 +379,6 @@ AlterSchemaOwner_internal(HeapTuple tup, Relation rel, Oid newOwnerId)
|
||||
newOwnerId);
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(NamespaceRelationId,
|
||||
HeapTupleGetOid(tup), 0);
|
||||
}
|
||||
|
@@ -20,6 +20,7 @@
|
||||
#include "access/xlogutils.h"
|
||||
#include "catalog/dependency.h"
|
||||
#include "catalog/namespace.h"
|
||||
#include "catalog/objectaccess.h"
|
||||
#include "catalog/pg_type.h"
|
||||
#include "commands/defrem.h"
|
||||
#include "commands/sequence.h"
|
||||
@@ -487,6 +488,8 @@ AlterSequence(AlterSeqStmt *stmt)
|
||||
if (owned_by)
|
||||
process_owned_by(seqrel, owned_by);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId, relid, 0);
|
||||
|
||||
relation_close(seqrel, NoLock);
|
||||
|
||||
return relid;
|
||||
|
@@ -669,7 +669,7 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId)
|
||||
*/
|
||||
if (rawDefaults || stmt->constraints)
|
||||
AddRelationNewConstraints(rel, rawDefaults, stmt->constraints,
|
||||
true, true);
|
||||
true, true, false);
|
||||
|
||||
/*
|
||||
* Clean up. We keep lock on new relation (although it shouldn't be
|
||||
@@ -1975,6 +1975,15 @@ StoreCatalogInheritance1(Oid relationId, Oid parentOid,
|
||||
|
||||
recordDependencyOn(&childobject, &parentobject, DEPENDENCY_NORMAL);
|
||||
|
||||
/*
|
||||
* Post creation hook of this inheritance. Since object_access_hook
|
||||
* doesn't take multiple object identifiers, we relay oid of parent
|
||||
* relation using auxiliary_id argument.
|
||||
*/
|
||||
InvokeObjectPostAlterHookArg(InheritsRelationId,
|
||||
relationId, 0,
|
||||
parentOid, false);
|
||||
|
||||
/*
|
||||
* Mark the parent as having subclasses.
|
||||
*/
|
||||
@@ -2234,6 +2243,8 @@ renameatt_internal(Oid myrelid,
|
||||
/* keep system catalog indexes current */
|
||||
CatalogUpdateIndexes(attrelation, atttup);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId, myrelid, attnum);
|
||||
|
||||
heap_freetuple(atttup);
|
||||
|
||||
heap_close(attrelation, RowExclusiveLock);
|
||||
@@ -2381,7 +2392,7 @@ rename_constraint_internal(Oid myrelid,
|
||||
|| con->contype == CONSTRAINT_UNIQUE
|
||||
|| con->contype == CONSTRAINT_EXCLUSION))
|
||||
/* rename the index; this renames the constraint as well */
|
||||
RenameRelationInternal(con->conindid, newconname);
|
||||
RenameRelationInternal(con->conindid, newconname, false);
|
||||
else
|
||||
RenameConstraintById(constraintOid, newconname);
|
||||
|
||||
@@ -2461,7 +2472,7 @@ RenameRelation(RenameStmt *stmt)
|
||||
}
|
||||
|
||||
/* Do the work */
|
||||
RenameRelationInternal(relid, stmt->newname);
|
||||
RenameRelationInternal(relid, stmt->newname, false);
|
||||
|
||||
return relid;
|
||||
}
|
||||
@@ -2476,7 +2487,7 @@ RenameRelation(RenameStmt *stmt)
|
||||
* sequence, AFAIK there's no need for it to be there.
|
||||
*/
|
||||
void
|
||||
RenameRelationInternal(Oid myrelid, const char *newrelname)
|
||||
RenameRelationInternal(Oid myrelid, const char *newrelname, bool is_internal)
|
||||
{
|
||||
Relation targetrelation;
|
||||
Relation relrelation; /* for RELATION relation */
|
||||
@@ -2518,6 +2529,9 @@ RenameRelationInternal(Oid myrelid, const char *newrelname)
|
||||
/* keep the system catalog indexes current */
|
||||
CatalogUpdateIndexes(relrelation, reltup);
|
||||
|
||||
InvokeObjectPostAlterHookArg(RelationRelationId, myrelid, 0,
|
||||
InvalidOid, is_internal);
|
||||
|
||||
heap_freetuple(reltup);
|
||||
heap_close(relrelation, RowExclusiveLock);
|
||||
|
||||
@@ -3531,7 +3545,9 @@ ATRewriteTables(List **wqueue, LOCKMODE lockmode)
|
||||
* interest in letting this code work on system catalogs.
|
||||
*/
|
||||
finish_heap_swap(tab->relid, OIDNewHeap,
|
||||
false, false, true, RecentXmin,
|
||||
false, false, true,
|
||||
!OidIsValid(tab->newTableSpace),
|
||||
RecentXmin,
|
||||
ReadNextMultiXactId());
|
||||
}
|
||||
else
|
||||
@@ -4531,7 +4547,8 @@ ATExecAddColumn(List **wqueue, AlteredTableInfo *tab, Relation rel,
|
||||
* This function is intended for CREATE TABLE, so it processes a
|
||||
* _list_ of defaults, but we just do one.
|
||||
*/
|
||||
AddRelationNewConstraints(rel, list_make1(rawEnt), NIL, false, true);
|
||||
AddRelationNewConstraints(rel, list_make1(rawEnt), NIL,
|
||||
false, true, false);
|
||||
|
||||
/* Make the additional catalog changes visible */
|
||||
CommandCounterIncrement();
|
||||
@@ -4869,6 +4886,9 @@ ATExecDropNotNull(Relation rel, const char *colName, LOCKMODE lockmode)
|
||||
CatalogUpdateIndexes(attr_rel, tuple);
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId,
|
||||
RelationGetRelid(rel), attnum);
|
||||
|
||||
heap_close(attr_rel, RowExclusiveLock);
|
||||
}
|
||||
|
||||
@@ -4921,6 +4941,9 @@ ATExecSetNotNull(AlteredTableInfo *tab, Relation rel,
|
||||
tab->new_notnull = true;
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId,
|
||||
RelationGetRelid(rel), attnum);
|
||||
|
||||
heap_close(attr_rel, RowExclusiveLock);
|
||||
}
|
||||
|
||||
@@ -4975,7 +4998,8 @@ ATExecColumnDefault(Relation rel, const char *colName,
|
||||
* This function is intended for CREATE TABLE, so it processes a
|
||||
* _list_ of defaults, but we just do one.
|
||||
*/
|
||||
AddRelationNewConstraints(rel, list_make1(rawEnt), NIL, false, true);
|
||||
AddRelationNewConstraints(rel, list_make1(rawEnt), NIL,
|
||||
false, true, false);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -5060,6 +5084,9 @@ ATExecSetStatistics(Relation rel, const char *colName, Node *newValue, LOCKMODE
|
||||
/* keep system catalog indexes current */
|
||||
CatalogUpdateIndexes(attrelation, tuple);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId,
|
||||
RelationGetRelid(rel),
|
||||
attrtuple->attnum);
|
||||
heap_freetuple(tuple);
|
||||
|
||||
heap_close(attrelation, RowExclusiveLock);
|
||||
@@ -5117,13 +5144,18 @@ ATExecSetOptions(Relation rel, const char *colName, Node *options,
|
||||
repl_repl[Anum_pg_attribute_attoptions - 1] = true;
|
||||
newtuple = heap_modify_tuple(tuple, RelationGetDescr(attrelation),
|
||||
repl_val, repl_null, repl_repl);
|
||||
ReleaseSysCache(tuple);
|
||||
|
||||
/* Update system catalog. */
|
||||
simple_heap_update(attrelation, &newtuple->t_self, newtuple);
|
||||
CatalogUpdateIndexes(attrelation, newtuple);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId,
|
||||
RelationGetRelid(rel),
|
||||
attrtuple->attnum);
|
||||
heap_freetuple(newtuple);
|
||||
|
||||
ReleaseSysCache(tuple);
|
||||
|
||||
heap_close(attrelation, RowExclusiveLock);
|
||||
}
|
||||
|
||||
@@ -5193,6 +5225,10 @@ ATExecSetStorage(Relation rel, const char *colName, Node *newValue, LOCKMODE loc
|
||||
/* keep system catalog indexes current */
|
||||
CatalogUpdateIndexes(attrelation, tuple);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId,
|
||||
RelationGetRelid(rel),
|
||||
attrtuple->attnum);
|
||||
|
||||
heap_freetuple(tuple);
|
||||
|
||||
heap_close(attrelation, RowExclusiveLock);
|
||||
@@ -5507,7 +5543,7 @@ ATExecAddIndexConstraint(AlteredTableInfo *tab, Relation rel,
|
||||
ereport(NOTICE,
|
||||
(errmsg("ALTER TABLE / ADD CONSTRAINT USING INDEX will rename index \"%s\" to \"%s\"",
|
||||
indexName, constraintName)));
|
||||
RenameRelationInternal(index_oid, constraintName);
|
||||
RenameRelationInternal(index_oid, constraintName, false);
|
||||
}
|
||||
|
||||
/* Extra checks needed if making primary key */
|
||||
@@ -5531,7 +5567,8 @@ ATExecAddIndexConstraint(AlteredTableInfo *tab, Relation rel,
|
||||
stmt->primary,
|
||||
true, /* update pg_index */
|
||||
true, /* remove old dependencies */
|
||||
allowSystemTableMods);
|
||||
allowSystemTableMods,
|
||||
false); /* is_internal */
|
||||
|
||||
index_close(indexRel, NoLock);
|
||||
}
|
||||
@@ -5643,7 +5680,8 @@ ATAddCheckConstraint(List **wqueue, AlteredTableInfo *tab, Relation rel,
|
||||
newcons = AddRelationNewConstraints(rel, NIL,
|
||||
list_make1(copyObject(constr)),
|
||||
recursing, /* allow_merge */
|
||||
!recursing); /* is_local */
|
||||
!recursing, /* is_local */
|
||||
is_readd); /* is_internal */
|
||||
|
||||
/* Add each to-be-validated constraint to Phase 3's queue */
|
||||
foreach(lcon, newcons)
|
||||
@@ -6097,7 +6135,8 @@ ATAddForeignKeyConstraint(AlteredTableInfo *tab, Relation rel,
|
||||
NULL,
|
||||
true, /* islocal */
|
||||
0, /* inhcount */
|
||||
true); /* isnoinherit */
|
||||
true, /* isnoinherit */
|
||||
false); /* is_internal */
|
||||
|
||||
/*
|
||||
* Create the triggers that will enforce the constraint.
|
||||
@@ -6279,6 +6318,10 @@ ATExecValidateConstraint(Relation rel, char *constrName, bool recurse,
|
||||
copy_con->convalidated = true;
|
||||
simple_heap_update(conrel, ©Tuple->t_self, copyTuple);
|
||||
CatalogUpdateIndexes(conrel, copyTuple);
|
||||
|
||||
InvokeObjectPostAlterHook(ConstraintRelationId,
|
||||
HeapTupleGetOid(tuple), 0);
|
||||
|
||||
heap_freetuple(copyTuple);
|
||||
}
|
||||
|
||||
@@ -7707,6 +7750,9 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
|
||||
*/
|
||||
RemoveStatistics(RelationGetRelid(rel), attnum);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId,
|
||||
RelationGetRelid(rel), attnum);
|
||||
|
||||
/*
|
||||
* Update the default, if present, by brute force --- remove and re-add
|
||||
* the default. Probably unsafe to take shortcuts, since the new version
|
||||
@@ -7726,7 +7772,7 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,
|
||||
RemoveAttrDefault(RelationGetRelid(rel), attnum, DROP_RESTRICT, true,
|
||||
true);
|
||||
|
||||
StoreAttrDefault(rel, attnum, defaultexpr);
|
||||
StoreAttrDefault(rel, attnum, defaultexpr, true);
|
||||
}
|
||||
|
||||
/* Cleanup */
|
||||
@@ -7817,11 +7863,16 @@ ATExecAlterColumnGenericOptions(Relation rel,
|
||||
|
||||
newtuple = heap_modify_tuple(tuple, RelationGetDescr(attrel),
|
||||
repl_val, repl_null, repl_repl);
|
||||
ReleaseSysCache(tuple);
|
||||
|
||||
simple_heap_update(attrel, &newtuple->t_self, newtuple);
|
||||
CatalogUpdateIndexes(attrel, newtuple);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId,
|
||||
RelationGetRelid(rel),
|
||||
atttableform->attnum);
|
||||
|
||||
ReleaseSysCache(tuple);
|
||||
|
||||
heap_close(attrel, RowExclusiveLock);
|
||||
|
||||
heap_freetuple(newtuple);
|
||||
@@ -8296,6 +8347,8 @@ ATExecChangeOwner(Oid relationOid, Oid newOwnerId, bool recursing, LOCKMODE lock
|
||||
}
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId, relationOid, 0);
|
||||
|
||||
ReleaseSysCache(tuple);
|
||||
heap_close(class_rel, RowExclusiveLock);
|
||||
relation_close(target_rel, NoLock);
|
||||
@@ -8457,7 +8510,7 @@ ATExecClusterOn(Relation rel, const char *indexName, LOCKMODE lockmode)
|
||||
check_index_is_clusterable(rel, indexOid, false, lockmode);
|
||||
|
||||
/* And do the work */
|
||||
mark_index_clustered(rel, indexOid);
|
||||
mark_index_clustered(rel, indexOid, false);
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -8469,7 +8522,7 @@ ATExecClusterOn(Relation rel, const char *indexName, LOCKMODE lockmode)
|
||||
static void
|
||||
ATExecDropCluster(Relation rel, LOCKMODE lockmode)
|
||||
{
|
||||
mark_index_clustered(rel, InvalidOid);
|
||||
mark_index_clustered(rel, InvalidOid, false);
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -8590,6 +8643,8 @@ ATExecSetRelOptions(Relation rel, List *defList, AlterTableType operation,
|
||||
|
||||
CatalogUpdateIndexes(pgclass, newtuple);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId, RelationGetRelid(rel), 0);
|
||||
|
||||
heap_freetuple(newtuple);
|
||||
|
||||
ReleaseSysCache(tuple);
|
||||
@@ -8647,6 +8702,10 @@ ATExecSetRelOptions(Relation rel, List *defList, AlterTableType operation,
|
||||
|
||||
CatalogUpdateIndexes(pgclass, newtuple);
|
||||
|
||||
InvokeObjectPostAlterHookArg(RelationRelationId,
|
||||
RelationGetRelid(toastrel), 0,
|
||||
InvalidOid, true);
|
||||
|
||||
heap_freetuple(newtuple);
|
||||
|
||||
ReleaseSysCache(tuple);
|
||||
@@ -8688,6 +8747,9 @@ ATExecSetTableSpace(Oid tableOid, Oid newTableSpace, LOCKMODE lockmode)
|
||||
if (newTableSpace == oldTableSpace ||
|
||||
(newTableSpace == MyDatabaseTableSpace && oldTableSpace == 0))
|
||||
{
|
||||
InvokeObjectPostAlterHook(RelationRelationId,
|
||||
RelationGetRelid(rel), 0);
|
||||
|
||||
relation_close(rel, NoLock);
|
||||
return;
|
||||
}
|
||||
@@ -8785,6 +8847,8 @@ ATExecSetTableSpace(Oid tableOid, Oid newTableSpace, LOCKMODE lockmode)
|
||||
simple_heap_update(pg_class, &tuple->t_self, tuple);
|
||||
CatalogUpdateIndexes(pg_class, tuple);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId, RelationGetRelid(rel), 0);
|
||||
|
||||
heap_freetuple(tuple);
|
||||
|
||||
heap_close(pg_class, RowExclusiveLock);
|
||||
@@ -9487,6 +9551,15 @@ ATExecDropInherit(Relation rel, RangeVar *parent, LOCKMODE lockmode)
|
||||
RelationRelationId,
|
||||
RelationGetRelid(parent_rel));
|
||||
|
||||
/*
|
||||
* Post alter hook of this inherits. Since object_access_hook doesn't
|
||||
* take multiple object identifiers, we relay oid of parent relation
|
||||
* using auxiliary_id argument.
|
||||
*/
|
||||
InvokeObjectPostAlterHookArg(InheritsRelationId,
|
||||
RelationGetRelid(rel), 0,
|
||||
RelationGetRelid(parent_rel), false);
|
||||
|
||||
/* keep our lock on the parent relation until commit */
|
||||
heap_close(parent_rel, NoLock);
|
||||
}
|
||||
@@ -9669,6 +9742,9 @@ ATExecAddOf(Relation rel, const TypeName *ofTypename, LOCKMODE lockmode)
|
||||
((Form_pg_class) GETSTRUCT(classtuple))->reloftype = typeid;
|
||||
simple_heap_update(relationRelation, &classtuple->t_self, classtuple);
|
||||
CatalogUpdateIndexes(relationRelation, classtuple);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId, relid, 0);
|
||||
|
||||
heap_freetuple(classtuple);
|
||||
heap_close(relationRelation, RowExclusiveLock);
|
||||
|
||||
@@ -9709,6 +9785,9 @@ ATExecDropOf(Relation rel, LOCKMODE lockmode)
|
||||
((Form_pg_class) GETSTRUCT(tuple))->reloftype = InvalidOid;
|
||||
simple_heap_update(relationRelation, &tuple->t_self, tuple);
|
||||
CatalogUpdateIndexes(relationRelation, tuple);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId, relid, 0);
|
||||
|
||||
heap_freetuple(tuple);
|
||||
heap_close(relationRelation, RowExclusiveLock);
|
||||
}
|
||||
@@ -9778,6 +9857,9 @@ ATExecGenericOptions(Relation rel, List *options)
|
||||
simple_heap_update(ftrel, &tuple->t_self, tuple);
|
||||
CatalogUpdateIndexes(ftrel, tuple);
|
||||
|
||||
InvokeObjectPostAlterHook(ForeignTableRelationId,
|
||||
RelationGetRelid(rel), 0);
|
||||
|
||||
heap_close(ftrel, RowExclusiveLock);
|
||||
|
||||
heap_freetuple(tuple);
|
||||
@@ -9935,6 +10017,8 @@ AlterRelationNamespaceInternal(Relation classRel, Oid relOid,
|
||||
NameStr(classForm->relname));
|
||||
|
||||
add_exact_object_address(&thisobj, objsMoved);
|
||||
|
||||
InvokeObjectPostAlterHook(RelationRelationId, relOid, 0);
|
||||
}
|
||||
|
||||
heap_freetuple(classTup);
|
||||
|
@@ -877,6 +877,8 @@ RenameTableSpace(const char *oldname, const char *newname)
|
||||
simple_heap_update(rel, &newtuple->t_self, newtuple);
|
||||
CatalogUpdateIndexes(rel, newtuple);
|
||||
|
||||
InvokeObjectPostAlterHook(TableSpaceRelationId, tspId, 0);
|
||||
|
||||
heap_close(rel, NoLock);
|
||||
|
||||
return tspId;
|
||||
@@ -945,6 +947,9 @@ AlterTableSpaceOptions(AlterTableSpaceOptionsStmt *stmt)
|
||||
/* Update system catalog. */
|
||||
simple_heap_update(rel, &newtuple->t_self, newtuple);
|
||||
CatalogUpdateIndexes(rel, newtuple);
|
||||
|
||||
InvokeObjectPostAlterHook(TableSpaceRelationId, HeapTupleGetOid(tup), 0);
|
||||
|
||||
heap_freetuple(newtuple);
|
||||
|
||||
/* Conclude heap scan. */
|
||||
|
@@ -446,7 +446,8 @@ CreateTrigger(CreateTrigStmt *stmt, const char *queryString,
|
||||
NULL,
|
||||
true, /* islocal */
|
||||
0, /* inhcount */
|
||||
true); /* isnoinherit */
|
||||
true, /* isnoinherit */
|
||||
isInternal); /* is_internal */
|
||||
}
|
||||
|
||||
/*
|
||||
@@ -742,7 +743,8 @@ CreateTrigger(CreateTrigStmt *stmt, const char *queryString,
|
||||
DEPENDENCY_NORMAL);
|
||||
|
||||
/* Post creation hook for new trigger */
|
||||
InvokeObjectPostCreateHook(TriggerRelationId, trigoid, 0);
|
||||
InvokeObjectPostCreateHookArg(TriggerRelationId, trigoid, 0,
|
||||
isInternal);
|
||||
|
||||
/* Keep lock on target rel until end of xact */
|
||||
heap_close(rel, NoLock);
|
||||
@@ -1276,6 +1278,9 @@ renametrig(RenameStmt *stmt)
|
||||
/* keep system catalog indexes current */
|
||||
CatalogUpdateIndexes(tgrel, tuple);
|
||||
|
||||
InvokeObjectPostAlterHook(TriggerRelationId,
|
||||
HeapTupleGetOid(tuple), 0);
|
||||
|
||||
/*
|
||||
* Invalidate relation's relcache entry so that other backends (and
|
||||
* this one too!) are sent SI message to make them rebuild relcache
|
||||
@@ -1391,6 +1396,9 @@ EnableDisableTrigger(Relation rel, const char *tgname,
|
||||
|
||||
changed = true;
|
||||
}
|
||||
|
||||
InvokeObjectPostAlterHook(TriggerRelationId,
|
||||
HeapTupleGetOid(tuple), 0);
|
||||
}
|
||||
|
||||
systable_endscan(tgscan);
|
||||
|
@@ -612,6 +612,8 @@ AlterTSDictionary(AlterTSDictionaryStmt *stmt)
|
||||
|
||||
CatalogUpdateIndexes(rel, newtup);
|
||||
|
||||
InvokeObjectPostAlterHook(TSDictionaryRelationId, dictId, 0);
|
||||
|
||||
/*
|
||||
* NOTE: because we only support altering the options, not the template,
|
||||
* there is no need to update dependencies. This might have to change if
|
||||
@@ -1184,6 +1186,9 @@ AlterTSConfiguration(AlterTSConfigurationStmt *stmt)
|
||||
/* Update dependencies */
|
||||
makeConfigurationDependencies(tup, true, relMap);
|
||||
|
||||
InvokeObjectPostAlterHook(TSConfigMapRelationId,
|
||||
HeapTupleGetOid(tup), 0);
|
||||
|
||||
heap_close(relMap, RowExclusiveLock);
|
||||
|
||||
ReleaseSysCache(tup);
|
||||
|
@@ -39,6 +39,7 @@
|
||||
#include "catalog/dependency.h"
|
||||
#include "catalog/heap.h"
|
||||
#include "catalog/indexing.h"
|
||||
#include "catalog/objectaccess.h"
|
||||
#include "catalog/pg_authid.h"
|
||||
#include "catalog/pg_collation.h"
|
||||
#include "catalog/pg_constraint.h"
|
||||
@@ -1214,6 +1215,8 @@ AlterEnum(AlterEnumStmt *stmt, bool isTopLevel)
|
||||
stmt->newValNeighbor, stmt->newValIsAfter,
|
||||
stmt->skipIfExists);
|
||||
|
||||
InvokeObjectPostAlterHook(TypeRelationId, enum_type_oid, 0);
|
||||
|
||||
ReleaseSysCache(tup);
|
||||
|
||||
return enum_type_oid;
|
||||
@@ -2190,6 +2193,8 @@ AlterDomainDefault(List *names, Node *defaultRaw)
|
||||
defaultExpr,
|
||||
true); /* Rebuild is true */
|
||||
|
||||
InvokeObjectPostAlterHook(TypeRelationId, domainoid, 0);
|
||||
|
||||
/* Clean up */
|
||||
heap_close(rel, NoLock);
|
||||
heap_freetuple(newtuple);
|
||||
@@ -2299,6 +2304,8 @@ AlterDomainNotNull(List *names, bool notNull)
|
||||
|
||||
CatalogUpdateIndexes(typrel, tup);
|
||||
|
||||
InvokeObjectPostAlterHook(TypeRelationId, domainoid, 0);
|
||||
|
||||
/* Clean up */
|
||||
heap_freetuple(tup);
|
||||
heap_close(typrel, RowExclusiveLock);
|
||||
@@ -2586,6 +2593,10 @@ AlterDomainValidateConstraint(List *names, char *constrName)
|
||||
copy_con->convalidated = true;
|
||||
simple_heap_update(conrel, ©Tuple->t_self, copyTuple);
|
||||
CatalogUpdateIndexes(conrel, copyTuple);
|
||||
|
||||
InvokeObjectPostAlterHook(ConstraintRelationId,
|
||||
HeapTupleGetOid(copyTuple), 0);
|
||||
|
||||
heap_freetuple(copyTuple);
|
||||
|
||||
systable_endscan(scan);
|
||||
@@ -2993,7 +3004,8 @@ domainAddConstraint(Oid domainOid, Oid domainNamespace, Oid baseTypeOid,
|
||||
ccsrc, /* Source form of check constraint */
|
||||
true, /* is local */
|
||||
0, /* inhcount */
|
||||
false); /* connoinherit */
|
||||
false, /* connoinherit */
|
||||
false); /* is_internal */
|
||||
|
||||
/*
|
||||
* Return the compiled constraint expression so the calling routine can
|
||||
@@ -3188,7 +3200,7 @@ RenameType(RenameStmt *stmt)
|
||||
* RenameRelationInternal will call RenameTypeInternal automatically.
|
||||
*/
|
||||
if (typTup->typtype == TYPTYPE_COMPOSITE)
|
||||
RenameRelationInternal(typTup->typrelid, newTypeName);
|
||||
RenameRelationInternal(typTup->typrelid, newTypeName, false);
|
||||
else
|
||||
RenameTypeInternal(typeOid, newTypeName,
|
||||
typTup->typnamespace);
|
||||
@@ -3311,6 +3323,8 @@ AlterTypeOwner(List *names, Oid newOwnerId, ObjectType objecttype)
|
||||
/* Update owner dependency reference */
|
||||
changeDependencyOnOwner(TypeRelationId, typeOid, newOwnerId);
|
||||
|
||||
InvokeObjectPostAlterHook(TypeRelationId, typeOid, 0);
|
||||
|
||||
/* If it has an array type, update that too */
|
||||
if (OidIsValid(typTup->typarray))
|
||||
AlterTypeOwnerInternal(typTup->typarray, newOwnerId, false);
|
||||
@@ -3333,6 +3347,8 @@ AlterTypeOwner(List *names, Oid newOwnerId, ObjectType objecttype)
|
||||
*
|
||||
* hasDependEntry should be TRUE if type is expected to have a pg_shdepend
|
||||
* entry (ie, it's not a table rowtype nor an array type).
|
||||
* is_primary_ops should be TRUE if this function is invoked with user's
|
||||
* direct operation (e.g, shdepReassignOwned). Elsewhere,
|
||||
*/
|
||||
void
|
||||
AlterTypeOwnerInternal(Oid typeOid, Oid newOwnerId,
|
||||
@@ -3366,6 +3382,8 @@ AlterTypeOwnerInternal(Oid typeOid, Oid newOwnerId,
|
||||
if (OidIsValid(typTup->typarray))
|
||||
AlterTypeOwnerInternal(typTup->typarray, newOwnerId, false);
|
||||
|
||||
InvokeObjectPostAlterHook(TypeRelationId, typeOid, 0);
|
||||
|
||||
/* Clean up */
|
||||
heap_close(rel, RowExclusiveLock);
|
||||
}
|
||||
@@ -3553,6 +3571,8 @@ AlterTypeNamespaceInternal(Oid typeOid, Oid nspOid,
|
||||
elog(ERROR, "failed to change schema dependency for type %s",
|
||||
format_type_be(typeOid));
|
||||
|
||||
InvokeObjectPostAlterHook(TypeRelationId, typeOid, 0);
|
||||
|
||||
heap_freetuple(tup);
|
||||
|
||||
heap_close(rel, RowExclusiveLock);
|
||||
|
@@ -777,6 +777,8 @@ AlterRole(AlterRoleStmt *stmt)
|
||||
/* Update indexes */
|
||||
CatalogUpdateIndexes(pg_authid_rel, new_tuple);
|
||||
|
||||
InvokeObjectPostAlterHook(AuthIdRelationId, roleid, 0);
|
||||
|
||||
ReleaseSysCache(tuple);
|
||||
heap_freetuple(new_tuple);
|
||||
|
||||
@@ -1161,6 +1163,8 @@ RenameRole(const char *oldname, const char *newname)
|
||||
|
||||
CatalogUpdateIndexes(rel, newtuple);
|
||||
|
||||
InvokeObjectPostAlterHook(AuthIdRelationId, roleid, 0);
|
||||
|
||||
ReleaseSysCache(oldtuple);
|
||||
|
||||
/*
|
||||
|
Reference in New Issue
Block a user