database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-03 09:13:20 +03:00
Code Activity

Fix handling of temp and unlogged tables in FOR ALL TABLES publications

Browse Source 
If a FOR ALL TABLES publication exists, temporary and unlogged tables
are ignored for publishing changes.  But CheckCmdReplicaIdentity()
would still check in that case that such a table has a replica
identity set before accepting updates.  To fix, have
GetRelationPublicationActions() return that such a table publishes no
actions.

Discussion: https://www.postgresql.org/message-id/f3f151f7-c4dd-1646-b998-f60bd6217dd3@2ndquadrant.com
This commit is contained in:
Peter Eisentraut
2019-04-16 10:37:44 +02:00
parent fea2cab70d
commit 05d151e138
2 changed files with 43 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/utils/cache/relcache.c vendored
View File

@@ -5236,6 +5236,13 @@ GetRelationPublicationActions(Relation relation)
MemoryContext oldcxt; MemoryContext oldcxt;
PublicationActions *pubactions = palloc0(sizeof(PublicationActions)); PublicationActions *pubactions = palloc0(sizeof(PublicationActions));
/*
* If not publishable, it publishes no actions. (pgoutput_change() will
* ignore it.)
*/
if (!is_publishable_relation(relation))
return pubactions;
if (relation->rd_pubactions) if (relation->rd_pubactions)
return memcpy(pubactions, relation->rd_pubactions, return memcpy(pubactions, relation->rd_pubactions,
sizeof(PublicationActions)); sizeof(PublicationActions));

37
src/test/subscription/t/100_bugs.pl
View File

@@ -3,7 +3,7 @@ use strict;
use warnings; use warnings;
use PostgresNode; use PostgresNode;
use TestLib; use TestLib;
use Test::More tests => 1; use Test::More tests => 3;
sub wait_for_caught_up sub wait_for_caught_up
{ {
@@ -72,3 +72,38 @@ $node_publisher->safe_psql('postgres',
wait_for_caught_up($node_publisher, 'sub1'); wait_for_caught_up($node_publisher, 'sub1');
pass('index predicates do not cause crash'); pass('index predicates do not cause crash');
$node_publisher->stop('fast');
$node_subscriber->stop('fast');
# Handling of temporary and unlogged tables with FOR ALL TABLES publications
# If a FOR ALL TABLES publication exists, temporary and unlogged
# tables are ignored for publishing changes. The bug was that we
# would still check in that case that such a table has a replica
# identity set before accepting updates. If it did not it would cause
# an error when an update was attempted.
$node_publisher = get_new_node('publisher2');
$node_publisher->init(allows_streaming => 'logical');
$node_publisher->start;
$node_publisher->safe_psql('postgres',
"CREATE PUBLICATION pub FOR ALL TABLES");
is( $node_publisher->psql(
'postgres',
"CREATE TEMPORARY TABLE tt1 AS SELECT 1 AS a; UPDATE tt1 SET a = 2;"),
0,
'update to temporary table without replica identity with FOR ALL TABLES publication'
);
is( $node_publisher->psql(
'postgres',
"CREATE UNLOGGED TABLE tu1 AS SELECT 1 AS a; UPDATE tu1 SET a = 2;"),
0,
'update to unlogged table without replica identity with FOR ALL TABLES publication'
);
$node_publisher->stop('fast');