database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-14 02:22:38 +03:00
Code Activity

pg_ctl: Change default to wait for all actions

Browse Source 
The different actions in pg_ctl had different defaults for -w and -W,
mostly for historical reasons.  Most users will want the -w behavior, so
make that the default.

Remove the -w option in most example and test code, so avoid confusion
and reduce verbosity.  pg_upgrade is not touched, so it can continue to
work with older installations.

Reviewed-by: Beena Emerson <memissemerson@gmail.com>
Reviewed-by: Ryan Murphy <ryanfmurphy@gmail.com>
This commit is contained in:
Peter Eisentraut
2017-01-13 12:00:00 -05:00
parent e574f15d62
commit 05cd12ed5b
10 changed files with 49 additions and 61 deletions
contrib/start-scripts
freebsdlinux
osx
PostgreSQL
doc/src/sgml/ref
pg_ctl-ref.sgml
src
bin
pg_ctl
pg_ctl.c
t
001_start_stop.pl003_promote.pl
test
modules
commit_ts
t
003_standby_2.pl
perl
PostgresNode.pm
tools
msvc
vcregress.pl

12
src/test/perl/PostgresNode.pm

@@ -632,7 +632,7 @@ port = $port
=item $node->start()
Wrapper for pg_ctl -w start
Wrapper for pg_ctl start
Start the node and wait until it is ready to accept connections.
@@ -645,7 +645,7 @@ sub start
my $pgdata = $self->data_dir;
my $name = $self->name;
print("### Starting node \"$name\"\n");
my $ret = TestLib::system_log('pg_ctl', '-w', '-D', $self->data_dir, '-l',
my $ret = TestLib::system_log('pg_ctl', '-D', $self->data_dir, '-l',
$self->logfile, 'start');
if ($ret != 0)
@@ -702,7 +702,7 @@ sub reload
=item $node->restart()
Wrapper for pg_ctl -w restart
Wrapper for pg_ctl restart
=cut
@@ -714,7 +714,7 @@ sub restart
my $logfile = $self->logfile;
my $name = $self->name;
print "### Restarting node \"$name\"\n";
TestLib::system_log('pg_ctl', '-D', $pgdata, '-w', '-l', $logfile,
TestLib::system_log('pg_ctl', '-D', $pgdata, '-l', $logfile,
'restart');
$self->_update_pid;
}
@@ -723,7 +723,7 @@ sub restart
=item $node->promote()
Wrapper for pg_ctl promote -w
Wrapper for pg_ctl promote
=cut
@@ -735,7 +735,7 @@ sub promote
my $logfile = $self->logfile;
my $name = $self->name;
print "### Promoting node \"$name\"\n";
TestLib::system_log('pg_ctl', '-D', $pgdata, '-w', '-l', $logfile,
TestLib::system_log('pg_ctl', '-D', $pgdata, '-l', $logfile,
'promote');
}