database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-07 00:36:50 +03:00
Code Activity

Attached is a patch implementing factorial(), returning numeric. Points

Browse Source 
to note:

1) arttype is numeric. I thought this was the best way of allowing
arbitarily large factorials, even though factorial(2^63) is a large
number. Happy to change to integers if this is overkill.
2) since we're accepting numeric arguments, the patch tests for floats.
If a numeric is passed with non-zero decimal portion, an error is raised
since (from memory) they are undefined.

Gavin Sherry
This commit is contained in:
Bruce Momjian
2003-12-01 21:52:38 +00:00
parent af03663878
commit 04a4821ade
9 changed files with 74 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/backend/utils/adt/int8.c
View File

@ -7,7 +7,7 @@
* Portions Copyright (c) 1994, Regents of the University of California
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/adt/int8.c,v 1.49 2003/11/29 19:51:58 pgsql Exp $
* $PostgreSQL: pgsql/src/backend/utils/adt/int8.c,v 1.50 2003/12/01 21:52:37 momjian Exp $
*
*-------------------------------------------------------------------------
*/
@ -561,26 +561,6 @@ int8mod(PG_FUNCTION_ARGS)
PG_RETURN_INT64(result);
}
/* int8fac()
* Factorial
*/
Datum
int8fac(PG_FUNCTION_ARGS)
{
int64 arg1 = PG_GETARG_INT64(0);
int64 result;
int64 i;
if (arg1 == 0)
result = 1;
else if (arg1 < 1)
result = 0;
else
for (i = arg1, result = 1; i > 0; --i)
result *= i;
PG_RETURN_INT64(result);
}
Datum
int8inc(PG_FUNCTION_ARGS)