database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-03 22:24:49 +03:00
Code

When a TAP file has non-zero exit status, retain temporary directories.

Browse Source 
PostgresNode already retained base directories in such cases.  Stop
using $SIG{__DIE__}, which is redundant with the exit status check, in
lieu of proliferating it to TestLib.  Back-patch to 9.6, where commit
88802e068017bee8cea7a5502a712794e761c7b5 introduced retention on
failure.

Reviewed by Daniel Gustafsson.

Discussion: https://postgr.es/m/20200202170155.GA3264196@rfd.leadboat.com
This commit is contained in:
Noah Misch 2020-02-05 08:26:41 -08:00
parent c15b17f927
commit 048c7ccd7d
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/test/perl/TestLib.pm
View File

@ -111,8 +111,13 @@ INIT
END END
{ {
# Preserve temporary directory for this test on failure # Test files have several ways of causing prove_check to fail:
$File::Temp::KEEP_ALL = 1 unless all_tests_passing(); # 1. Exit with a non-zero status.
# 2. Call ok(0) or similar, indicating that a constituent test failed.
# 3. Deviate from the planned number of tests.
#
# Preserve temporary directories after (1) and after (2).
$File::Temp::KEEP_ALL = 1 unless $? == 0 && all_tests_passing();
} }
sub all_tests_passing sub all_tests_passing