database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-27 00:12:01 +03:00
Code Activity

Fix leak with SMgrRelations in startup process

Browse Source 
The startup process does not process shared invalidation messages, only
sending them, and never calls AtEOXact_SMgr() which clean up any
unpinned SMgrRelations.  Hence, it is never able to free SMgrRelations
on a periodic basis, bloating its hashtable over time.

Like the checkpointer and the bgwriter, this commit takes a conservative
approach by freeing periodically SMgrRelations when replaying a
checkpoint record, either online or shutdown, so as the startup process
has a way to perform a periodic cleanup.

Issue caused by 21d9c3ee4e, so backpatch down to v17.

Author: Jingtang Zhang <mrdrivingduck@gmail.com>
Reviewed-by: Yuhang Qiu <iamqyh@gmail.com>
Discussion: https://postgr.es/m/28C687D4-F335-417E-B06C-6612A0BD5A10@gmail.com
Backpatch-through: 17
This commit is contained in:
Michael Paquier
2025-09-10 07:23:22 +09:00
parent a80b7a0547
commit 039301b3fc
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/access/transam/xlog.c
View File

@@ -8403,6 +8403,14 @@ xlog_redo(XLogReaderState *record)
checkPoint.ThisTimeLineID, replayTLI))); checkPoint.ThisTimeLineID, replayTLI)));
RecoveryRestartPoint(&checkPoint, record); RecoveryRestartPoint(&checkPoint, record);
/*
* After replaying a checkpoint record, free all smgr objects.
* Otherwise we would never do so for dropped relations, as the
* startup does not process shared invalidation messages or call
* AtEOXact_SMgr().
*/
smgrdestroyall();
} }
else if (info == XLOG_CHECKPOINT_ONLINE) else if (info == XLOG_CHECKPOINT_ONLINE)
{ {
@@ -8461,6 +8469,14 @@ xlog_redo(XLogReaderState *record)
checkPoint.ThisTimeLineID, replayTLI))); checkPoint.ThisTimeLineID, replayTLI)));
RecoveryRestartPoint(&checkPoint, record); RecoveryRestartPoint(&checkPoint, record);
/*
* After replaying a checkpoint record, free all smgr objects.
* Otherwise we would never do so for dropped relations, as the
* startup does not process shared invalidation messages or call
* AtEOXact_SMgr().
*/
smgrdestroyall();
} }
else if (info == XLOG_OVERWRITE_CONTRECORD) else if (info == XLOG_OVERWRITE_CONTRECORD)
{ {