database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-17 06:41:09 +03:00
Code Activity

Fix access through null pointer info->rule_action. Thanks Darren King.

Browse Source
This commit is contained in:
Bryan Henderson
1996-11-24 05:58:57 +00:00
parent 9602150a04
commit 02db1f58cb
1 changed files with 36 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
src/backend/rewrite/rewriteHandler.c
View File

@ -6,7 +6,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteHandler.c,v 1.1.1.1 1996/07/09 06:21:51 scrappy Exp $ * $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteHandler.c,v 1.2 1996/11/24 05:58:57 bryanh Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -57,50 +57,47 @@ gatherRewriteMeta(Query *parsetree,
info->rt_index = rt_index; info->rt_index = rt_index;
info->event = event; info->event = event;
info->instead_flag = *instead_flag; info->instead_flag = *instead_flag;
/* info->rule_action = rule_action; this needs to be a copy here, I think! - jolly*/
info->rule_action = (Query*)copyObject(rule_action); info->rule_action = (Query*)copyObject(rule_action);
info->rule_qual = (Node*)copyObject(rule_qual); info->rule_qual = (Node*)copyObject(rule_qual);
info->nothing = FALSE;
info->action = info->rule_action->commandType;
if (info->rule_action == NULL) info->nothing = TRUE; if (info->rule_action == NULL) info->nothing = TRUE;
if (info->nothing) else {
return info; info->nothing = FALSE;
info->action = info->rule_action->commandType;
info->current_varno = rt_index;
info->rt = parsetree->rtable;
rt_length = length(info->rt);
info->rt = append(info->rt, info->rule_action->rtable);
info->current_varno = rt_index; info->new_varno = PRS2_NEW_VARNO + rt_length;
info->rt = parsetree->rtable; OffsetVarNodes(info->rule_action->qual, rt_length);
rt_length = length(info->rt); OffsetVarNodes((Node*)info->rule_action->targetList, rt_length);
info->rt = append(info->rt, info->rule_action->rtable); OffsetVarNodes(info->rule_qual, rt_length);
ChangeVarNodes((Node*)info->rule_action->qual,
PRS2_CURRENT_VARNO+rt_length, rt_index);
ChangeVarNodes((Node*)info->rule_action->targetList,
PRS2_CURRENT_VARNO+rt_length, rt_index);
ChangeVarNodes(info->rule_qual,
PRS2_CURRENT_VARNO+rt_length, rt_index);
/*
info->new_varno = PRS2_NEW_VARNO + rt_length; * bug here about replace CURRENT -- sort of
OffsetVarNodes(info->rule_action->qual, rt_length); * replace current is deprecated now so this code shouldn't really
OffsetVarNodes((Node*)info->rule_action->targetList, rt_length); * need to be so clutzy but.....
OffsetVarNodes(info->rule_qual, rt_length); */
ChangeVarNodes((Node*)info->rule_action->qual, if (info->action != CMD_SELECT) { /* i.e update XXXXX */
PRS2_CURRENT_VARNO+rt_length, rt_index); int new_result_reln = 0;
ChangeVarNodes((Node*)info->rule_action->targetList, result_reln = info->rule_action->resultRelation;
PRS2_CURRENT_VARNO+rt_length, rt_index); switch (result_reln) {
ChangeVarNodes(info->rule_qual, PRS2_CURRENT_VARNO+rt_length, rt_index); case PRS2_CURRENT_VARNO: new_result_reln = rt_index;
break;
/* case PRS2_NEW_VARNO: /* XXX */
* bug here about replace CURRENT -- sort of default:
* replace current is deprecated now so this code shouldn't really new_result_reln = result_reln + rt_length;
* need to be so clutzy but..... break;
*/ }
if (info->action != CMD_SELECT) { /* i.e update XXXXX */ info->rule_action->resultRelation = new_result_reln;
int new_result_reln = 0; }
result_reln = info->rule_action->resultRelation;
switch (result_reln) {
case PRS2_CURRENT_VARNO: new_result_reln = rt_index;
break;
case PRS2_NEW_VARNO: /* XXX */
default:
new_result_reln = result_reln + rt_length;
break;
}
info->rule_action->resultRelation = new_result_reln;
} }
return info; return info;
} }