database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

Avoid use of CREATE OR REPLACE FUNCTION in extension installation files.

Browse Source 
It was never terribly consistent to use OR REPLACE (because of the lack of
comparable functionality for data types, operators, etc), and
experimentation shows that it's now positively pernicious in the extension
world.  We really want a failure to occur if there are any conflicts, else
it's unclear what the extension-ownership state of the conflicted object
ought to be.  Most of the time, CREATE EXTENSION will fail anyway because
of conflicts on other object types, but an extension defining only
functions can succeed, with bad results.
This commit is contained in:
Tom Lane
2011-02-13 21:24:14 -05:00
parent 629b3af27d
commit 029fac2264
37 changed files with 922 additions and 922 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
contrib/pgstattuple/pgstattuple--1.0.sql
View File

@ -1,6 +1,6 @@
/* contrib/pgstattuple/pgstattuple--1.0.sql */
CREATE OR REPLACE FUNCTION pgstattuple(IN relname text,
CREATE FUNCTION pgstattuple(IN relname text,
OUT table_len BIGINT, -- physical table length in bytes
OUT tuple_count BIGINT, -- number of live tuples
OUT tuple_len BIGINT, -- total tuples length in bytes
@ -13,7 +13,7 @@ CREATE OR REPLACE FUNCTION pgstattuple(IN relname text,
AS 'MODULE_PATHNAME', 'pgstattuple'
LANGUAGE C STRICT;
CREATE OR REPLACE FUNCTION pgstattuple(IN reloid oid,
CREATE FUNCTION pgstattuple(IN reloid oid,
OUT table_len BIGINT, -- physical table length in bytes
OUT tuple_count BIGINT, -- number of live tuples
OUT tuple_len BIGINT, -- total tuples length in bytes
@ -26,7 +26,7 @@ CREATE OR REPLACE FUNCTION pgstattuple(IN reloid oid,
AS 'MODULE_PATHNAME', 'pgstattuplebyid'
LANGUAGE C STRICT;
CREATE OR REPLACE FUNCTION pgstatindex(IN relname text,
CREATE FUNCTION pgstatindex(IN relname text,
OUT version INT,
OUT tree_level INT,
OUT index_size BIGINT,
@ -40,7 +40,7 @@ CREATE OR REPLACE FUNCTION pgstatindex(IN relname text,
AS 'MODULE_PATHNAME', 'pgstatindex'
LANGUAGE C STRICT;
CREATE OR REPLACE FUNCTION pg_relpages(IN relname text)
CREATE FUNCTION pg_relpages(IN relname text)
RETURNS BIGINT
AS 'MODULE_PATHNAME', 'pg_relpages'
LANGUAGE C STRICT;