database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-19 23:22:23 +03:00
Code Activity

Ensure dummy paths have correct required_outer if rel is parameterized.

Browse Source 
The assertions added by commits 34ea1ab7f et al found another problem:
set_dummy_rel_pathlist and mark_dummy_rel were failing to label
the dummy paths they create with the correct outer_relids, in case
the relation is necessarily parameterized due to having lateral
references in its tlist.  It's likely that this has no user-visible
consequences in production builds, at the moment; but still an assertion
failure is a bad thing, so back-patch the fix.

Per bug #15694 from Roman Zharkov (via Alexander Lakhin)
and an independent report by Tushar Ahuja.

Discussion: https://postgr.es/m/15694-74f2ca97e7044f7f@postgresql.org
Discussion: https://postgr.es/m/7d72ab20-c725-3ce2-f99d-4e64dd8a0de6@enterprisedb.com
This commit is contained in:
Tom Lane
2019-03-14 12:16:09 -04:00
parent e2e441c763
commit 0255329a78
4 changed files with 43 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/optimizer/path/allpaths.c
View File

@@ -1595,7 +1595,9 @@ set_dummy_rel_pathlist(RelOptInfo *rel)
rel->pathlist = NIL;
rel->partial_pathlist = NIL;
add_path(rel, (Path *) create_append_path(rel, NIL, NULL, 0));
add_path(rel, (Path *) create_append_path(rel, NIL,
rel->lateral_relids,
0));
/*
* We set the cheapest path immediately, to ensure that IS_DUMMY_REL()

4
src/backend/optimizer/path/joinrels.c
View File

@@ -1198,7 +1198,9 @@ mark_dummy_rel(RelOptInfo *rel)
rel->partial_pathlist = NIL;
/* Set up the dummy path */
add_path(rel, (Path *) create_append_path(rel, NIL, NULL, 0));
add_path(rel, (Path *) create_append_path(rel, NIL,
rel->lateral_relids,
0));
/* Set or update cheapest_total_path and related fields */
set_cheapest(rel);