From 0229e087df2ac050f53140fd7497d0e70943d16f Mon Sep 17 00:00:00 2001 From: Peter Geoghegan Date: Fri, 3 Aug 2018 14:44:26 -0700 Subject: [PATCH] Add table relcache invalidation to index builds. It's necessary to make sure that owning tables have a relcache invalidation prior to advancing the command counter to make newly-entered catalog tuples for the index visible. inval.c must be able to maintain the consistency of the local caches in the event of transaction abort. There is usually only a problem when CREATE INDEX transactions abort, since there is a generic invalidation once we reach index_update_stats(). This bug is of long standing. Problems were made much more likely by the addition of parallel CREATE INDEX (commit 9da0cc35284), but it is strongly suspected that similar problems can be triggered without involving plan_create_index_workers(). (plan_create_index_workers() triggers a relcache build or rebuild, which previously only happened in rare edge cases.) Author: Peter Geoghegan Reported-By: Luca Ferrari Diagnosed-By: Andres Freund Reviewed-By: Andres Freund Discussion: https://postgr.es/m/CAKoxK+5fVodiCtMsXKV_1YAKXbzwSfp7DgDqUmcUAzeAhf=HEQ@mail.gmail.com Backpatch: 9.3- --- src/backend/catalog/index.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c index 1df6602e5a5..2f919df4d24 100644 --- a/src/backend/catalog/index.c +++ b/src/backend/catalog/index.c @@ -885,6 +885,12 @@ index_create(Relation heapRelation, !deferrable, !concurrent); + /* + * Register relcache invalidation on the indexes' heap relation, to + * maintain consistency of its index list + */ + CacheInvalidateRelcache(heapRelation); + /* * Register constraint and dependencies for the index. *