1
0
mirror of https://github.com/postgres/postgres.git synced 2025-07-14 08:21:07 +03:00

TOAST mop-up work: update comments for tuple-size-related symbols such

as MaxHeapAttributeNumber.  Increase MaxAttrSize to something more
reasonable (given what it's used for, namely checking char(n) declarations,
I didn't make it the full 1G that it could theoretically be --- 10Mb
seemed a more reasonable number).  Improve calculation of MaxTupleSize.
This commit is contained in:
Tom Lane
2000-08-07 20:16:13 +00:00
parent d2165a4a5d
commit 0224177400
8 changed files with 96 additions and 63 deletions

View File

@ -11,7 +11,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.183 2000/08/07 06:54:51 thomas Exp $
* $Header: /cvsroot/pgsql/src/backend/parser/gram.y,v 2.184 2000/08/07 20:16:13 tgl Exp $
*
* HISTORY
* AUTHOR DATE MAJOR EVENT
@ -4153,10 +4153,11 @@ Bit: bit '(' Iconst ')'
$$ = makeNode(TypeName);
$$->name = $1;
if ($3 < 1)
elog(ERROR,"length for type '%s' must be at least 1",$1);
else if ($3 > (MaxAttrSize * sizeof(char)))
elog(ERROR,"length for type '%s' cannot exceed %ld",$1,
(MaxAttrSize * sizeof(char)));
elog(ERROR,"length for type '%s' must be at least 1",
$1);
else if ($3 > (MaxAttrSize * BITSPERBYTE))
elog(ERROR,"length for type '%s' cannot exceed %d",
$1, (MaxAttrSize * BITSPERBYTE));
$$->typmod = $3;
}
| bit
@ -4187,10 +4188,11 @@ Character: character '(' Iconst ')'
$$ = makeNode(TypeName);
$$->name = $1;
if ($3 < 1)
elog(ERROR,"length for type '%s' must be at least 1",$1);
elog(ERROR,"length for type '%s' must be at least 1",
$1);
else if ($3 > MaxAttrSize)
elog(ERROR,"length for type '%s' cannot exceed %ld",$1,
MaxAttrSize);
elog(ERROR,"length for type '%s' cannot exceed %d",
$1, MaxAttrSize);
/* we actually implement these like a varlen, so
* the first 4 bytes is the length. (the difference