database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-30 11:03:19 +03:00
Code Activity

Still further rethinking of build changes for macOS Mojave.

Browse Source 
To avoid the sorts of problems complained of by Jakob Egger, it'd be
best if configure didn't emit any references to the sysroot path at all.
In the case of PL/Tcl, we can do that just by keeping our hands off the
TCL_INCLUDE_SPEC string altogether.  In the case of PL/Perl, we need to
substitute -iwithsysroot for -I in the compile commands, which is easily
handled if we change to using a configure output variable that includes
the switch not only the directory name.  Since PL/Tcl and PL/Python
already do it like that, this seems like good consistency cleanup anyway.

Hence, this replaces the advice given to Perl-related extensions in commit
5e2217131; instead of writing "-I$(perl_archlibexp)/CORE", they should
just write "$(perl_includespec)".  (The old way continues to work, but not
on recent macOS.)

It's still the case that configure needs to be aware of the sysroot
path internally, but that's cleaner than what we had before.

As before, back-patch to all supported versions.

Discussion: https://postgr.es/m/20840.1537850987@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2018-10-18 14:55:23 -04:00
parent e2501d8013
commit 015fd381fe
5 changed files with 21 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
configure vendored
View File

@ -683,7 +683,7 @@ python_majorversion
PYTHON
perl_embed_ldflags
perl_embed_ccflags
perl_includedir
perl_includespec
perl_useshrplib
perl_privlibexp
perl_archlibexp
@ -7793,11 +7793,12 @@ test "$PORTNAME" = "win32" && perl_useshrplib=`echo $perl_useshrplib | sed 's,\\
{ $as_echo "$as_me:$LINENO: result: $perl_useshrplib" >&5
$as_echo "$perl_useshrplib" >&6; }
# On most platforms, archlibexp is also where the Perl include files live ...
perl_includedir="$perl_archlibexp"
# ... but on some macOS versions, we must look under $PG_SYSROOT instead
if test x"$PG_SYSROOT" != x"" ; then
perl_includespec="-I$perl_archlibexp/CORE"
# ... but on newer macOS versions, we must use -iwithsysroot to look
# under $PG_SYSROOT
if test \! -f "$perl_archlibexp/CORE/perl.h" ; then
if test -f "$PG_SYSROOT$perl_archlibexp/CORE/perl.h" ; then
perl_includedir="$PG_SYSROOT$perl_archlibexp"
perl_includespec="-iwithsysroot $perl_archlibexp/CORE"
fi
fi
@ -30257,12 +30258,7 @@ eval TCL_LIBS=\"$TCL_LIBS\"
eval TCL_LIB_SPEC=\"$TCL_LIB_SPEC\"
eval TCL_SHARED_BUILD=\"$TCL_SHARED_BUILD\"
# Some macOS versions report an include spec that uses -iwithsysroot.
# We don't really want to use -isysroot, so translate that if we can.
if test x"$PG_SYSROOT" != x"" ; then
TCL_INCLUDE_SPEC="`echo "$TCL_INCLUDE_SPEC" | sed "s|-iwithsysroot */|-I $PG_SYSROOT/|"`"
fi
# now that we have TCL_INCLUDE_SPEC, we can check for <tcl.h>
# now that we have TCL_INCLUDE_SPEC, we can check for <tcl.h>
ac_save_CPPFLAGS=$CPPFLAGS
CPPFLAGS="$TCL_INCLUDE_SPEC $CPPFLAGS"
if test "${ac_cv_header_tcl_h+set}" = set; then
@ -30412,7 +30408,7 @@ fi
# check for <perl.h>
if test "$with_perl" = yes; then
ac_save_CPPFLAGS=$CPPFLAGS
CPPFLAGS="$CPPFLAGS -I$perl_includedir/CORE"
CPPFLAGS="$CPPFLAGS $perl_includespec"
{ $as_echo "$as_me:$LINENO: checking for perl.h" >&5
$as_echo_n "checking for perl.h... " >&6; }
if test "${ac_cv_header_perl_h+set}" = set; then