database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-05 07:41:25 +03:00
Code Activity

Be less wishy-washy in the documentation and comments about whether a

Browse Source 
ParameterStatus message can be sent during COPY OUT: it's definitely
possible, since COPY from a SELECT subquery can trigger any user-defined
function.
This commit is contained in:
Tom Lane
2008-01-15 22:18:20 +00:00
parent 14e2a260a5
commit 0153c4c466
2 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
doc/src/sgml/protocol.sgml
View File

@@ -1,4 +1,4 @@
<!-- $PostgreSQL: pgsql/doc/src/sgml/protocol.sgml,v 1.71 2008/01/14 18:46:17 tgl Exp $ --> <!-- $PostgreSQL: pgsql/doc/src/sgml/protocol.sgml,v 1.72 2008/01/15 22:18:20 tgl Exp $ -->
<chapter id="protocol"> <chapter id="protocol">
<title>Frontend/Backend Protocol</title> <title>Frontend/Backend Protocol</title>
@@ -1044,10 +1044,10 @@
</para> </para>
<para> <para>
It is possible for NoticeResponse messages to be interspersed between It is possible for NoticeResponse and ParameterStatus messages to be
CopyData messages; frontends must handle this case, and should be interspersed between CopyData messages; frontends must handle these cases,
prepared for other asynchronous message types as well (see <xref and should be prepared for other asynchronous message types as well (see
linkend="protocol-async">). Otherwise, any message type other than <xref linkend="protocol-async">). Otherwise, any message type other than
CopyData or CopyDone may be treated as terminating copy-out mode. CopyData or CopyDone may be treated as terminating copy-out mode.
</para> </para>

7
src/interfaces/libpq/fe-protocol3.c
View File

@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.32 2008/01/14 18:46:17 tgl Exp $ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.33 2008/01/15 22:18:20 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@@ -1310,9 +1310,8 @@ getCopyDataMessage(PGconn *conn)
/* /*
* If it's a legitimate async message type, process it. (NOTIFY * If it's a legitimate async message type, process it. (NOTIFY
* messages are not currently possible here, but we handle them for * messages are not currently possible here, but we handle them for
* completeness. NOTICE is definitely possible, and ParameterStatus * completeness.) Otherwise, if it's anything except Copy Data,
* could probably be made to happen.) Otherwise, if it's anything * report end-of-copy.
* except Copy Data, report end-of-copy.
*/ */
switch (id) switch (id)
{ {