mirror of
https://github.com/postgres/postgres.git
synced 2025-06-30 21:42:05 +03:00
Allow on-detach callbacks for dynamic shared memory segments.
Just as backends must clean up their shared memory state (releasing lwlocks, buffer pins, etc.) before exiting, they must also perform any similar cleanups related to dynamic shared memory segments they have mapped before unmapping those segments. So add a mechanism to ensure that. Existing on_shmem_exit hooks include both "user level" cleanup such as transaction abort and removal of leftover temporary relations and also "low level" cleanup that forcibly released leftover shared memory resources. On-detach callbacks should run after the first group but before the second group, so create a new before_shmem_exit function for registering the early callbacks and keep on_shmem_exit for the regular callbacks. (An earlier draft of this patch added an additional argument to on_shmem_exit, but that had a much larger footprint and probably a substantially higher risk of breaking third party code for no real gain.) Patch by me, reviewed by KaiGai Kohei and Andres Freund.
This commit is contained in:
@ -587,15 +587,14 @@ InitPostgres(const char *in_dbname, Oid dboid, const char *username,
|
||||
RelationCacheInitializePhase2();
|
||||
|
||||
/*
|
||||
* Set up process-exit callback to do pre-shutdown cleanup. This has to
|
||||
* be after we've initialized all the low-level modules like the buffer
|
||||
* manager, because during shutdown this has to run before the low-level
|
||||
* modules start to close down. On the other hand, we want it in place
|
||||
* before we begin our first transaction --- if we fail during the
|
||||
* initialization transaction, as is entirely possible, we need the
|
||||
* AbortTransaction call to clean up.
|
||||
* Set up process-exit callback to do pre-shutdown cleanup. This is the
|
||||
* first before_shmem_exit callback we register; thus, this will be the
|
||||
* last thing we do before low-level modules like the buffer manager begin
|
||||
* to close down. We need to have this in place before we begin our first
|
||||
* transaction --- if we fail during the initialization transaction, as is
|
||||
* entirely possible, we need the AbortTransaction call to clean up.
|
||||
*/
|
||||
on_shmem_exit(ShutdownPostgres, 0);
|
||||
before_shmem_exit(ShutdownPostgres, 0);
|
||||
|
||||
/* The autovacuum launcher is done here */
|
||||
if (IsAutoVacuumLauncherProcess())
|
||||
|
Reference in New Issue
Block a user