From 132b304811f3ab47a057e51cb90b4050a72a3ff3 Mon Sep 17 00:00:00 2001 From: Usamoi Date: Mon, 22 Jan 2024 18:02:48 +0800 Subject: [PATCH] fix: checking of user options (#297) Signed-off-by: usamoi --- crates/service/src/algorithms/quantization/product.rs | 1 + crates/service/src/index/optimizing/mod.rs | 4 ++-- src/gucs/executing.rs | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/crates/service/src/algorithms/quantization/product.rs b/crates/service/src/algorithms/quantization/product.rs index bbc1905..9e0820c 100644 --- a/crates/service/src/algorithms/quantization/product.rs +++ b/crates/service/src/algorithms/quantization/product.rs @@ -19,6 +19,7 @@ use validator::Validate; #[serde(deny_unknown_fields)] pub struct ProductQuantizationOptions { #[serde(default = "ProductQuantizationOptions::default_sample")] + #[validate(range(min = 1, max = 1_000_000))] pub sample: u32, #[serde(default)] pub ratio: ProductQuantizationOptionsRatio, diff --git a/crates/service/src/index/optimizing/mod.rs b/crates/service/src/index/optimizing/mod.rs index 92c4afc..67972a9 100644 --- a/crates/service/src/index/optimizing/mod.rs +++ b/crates/service/src/index/optimizing/mod.rs @@ -9,7 +9,7 @@ use validator::Validate; #[serde(deny_unknown_fields)] pub struct OptimizingOptions { #[serde(default = "OptimizingOptions::default_sealing_secs")] - #[validate(range(min = 0, max = 60))] + #[validate(range(min = 1, max = 60))] pub sealing_secs: u64, #[serde(default = "OptimizingOptions::default_sealing_size")] #[validate(range(min = 1, max = 4_000_000_000))] @@ -18,7 +18,7 @@ pub struct OptimizingOptions { #[validate(range(min = 0.01, max = 1.00))] pub deleted_threshold: f64, #[serde(default = "OptimizingOptions::default_optimizing_threads")] - #[validate(range(min = 0, max = 65535))] + #[validate(range(min = 1, max = 65535))] pub optimizing_threads: usize, } diff --git a/src/gucs/executing.rs b/src/gucs/executing.rs index c57e9e1..9a42e01 100644 --- a/src/gucs/executing.rs +++ b/src/gucs/executing.rs @@ -11,7 +11,7 @@ static HNSW_EF_SEARCH: GucSetting = GucSetting::::new(100); pub unsafe fn init() { GucRegistry::define_bool_guc( "vectors.enable_prefilter", - "Enables or disables the prfiltering.", + "Enables or disables the prefiltering.", "https://docs.pgvecto.rs/usage/search.html", &ENABLE_PREFILTER, GucContext::Userset,