database/pgbackrest
1
0
Fork 0
mirror of https://github.com/pgbackrest/pgbackrest.git synced 2025-07-29 08:21:11 +03:00
Code Activity

Add missing ToLog() coverage to String, List, and PgControl.

Browse Source 
Missing coverage is exposed in the next commit which disables test tracing by default.
This commit is contained in:
David Steele
2019-02-22 11:31:37 +02:00
parent a7c8906581
commit ae86e6d5b2
5 changed files with 39 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
doc/xml/release.xml
View File

@ -90,6 +90,14 @@
</release-item>
</release-development-list>
</release-doc-list>
<release-test-list>
<release-development-list>
<release-item>
<p>Add missing ToLog() coverage to <code>String</code>, <code>List</code>, and <code>PgControl</code>.</p>
</release-item>
</release-development-list>
</release-test-list>
</release>
<release date="2019-02-09" version="2.10" title="Bug Fixes">

2
test/define.yaml
View File

@ -350,7 +350,7 @@ unit:
test:
# ----------------------------------------------------------------------------------------------------------------------------
- name: interface
total: 2
total: 3
coverage:
postgres/interface: full

4
test/src/module/common/typeListTest.c
View File

@ -29,7 +29,7 @@ testRun(void)
FUNCTION_HARNESS_VOID();
// *****************************************************************************************************************************
if (testBegin("lstNew(), lstMemContext(), and lstFree()"))
if (testBegin("lstNew(), lstMemContext(), lstToLog(), and lstFree()"))
{
List *list = lstNew(sizeof(void *));
@ -41,6 +41,8 @@ testRun(void)
void *ptr = NULL;
TEST_RESULT_PTR(lstAdd(list, &ptr), list, "add item");
TEST_RESULT_STR(strPtr(lstToLog(list)), "{size: 1}", "check log");
TEST_RESULT_VOID(lstFree(list), "free list");
TEST_RESULT_VOID(lstFree(lstNew(1)), "free empty list");
TEST_RESULT_VOID(lstFree(NULL), "free null list");

12
test/src/module/common/typeStringTest.c
View File

@ -81,8 +81,11 @@ testRun(void)
String *string2 = strNew("ZZZZ");
TEST_RESULT_STR(strPtr(strCat(string, "YYYY")), "XXXXYYYY", "cat string");
TEST_RESULT_SIZE(string->common.extra, 4, "check extra");
TEST_RESULT_STR(strPtr(strCatFmt(string, "%05d", 777)), "XXXXYYYY00777", "cat formatted string");
TEST_RESULT_SIZE(string->common.extra, 6, "check extra");
TEST_RESULT_STR(strPtr(strCatChr(string, '!')), "XXXXYYYY00777!", "cat chr");
TEST_RESULT_SIZE(string->common.extra, 5, "check extra");
TEST_RESULT_STR(strPtr(string2), "ZZZZ", "check unaltered string");
}
@ -213,10 +216,17 @@ testRun(void)
}
// *****************************************************************************************************************************
if (testBegin("strToLog()"))
if (testBegin("strToLog() and strObjToLog()"))
{
TEST_RESULT_STR(strPtr(strToLog(strNew("test"))), "{\"test\"}", "format string");
TEST_RESULT_STR(strPtr(strToLog(NULL)), "null", "format null string");
char buffer[256];
TEST_RESULT_UINT(strObjToLog(NULL, (StrObjToLogFormat)strToLog, buffer, sizeof(buffer)), 4, "format null string");
TEST_RESULT_STR(buffer, "null", "check null string");
TEST_RESULT_UINT(strObjToLog(strNew("teststr"), (StrObjToLogFormat)strToLog, buffer, sizeof(buffer)), 11, "format string");
TEST_RESULT_STR(buffer, "{\"teststr\"}", "check string");
}
// *****************************************************************************************************************************

16
test/src/module/postgres/interfaceTest.c
View File

@ -89,5 +89,21 @@ testRun(void)
TEST_RESULT_INT(info.version, PG_VERSION_83, " check version");
}
// *****************************************************************************************************************************
if (testBegin("pgControlToLog()"))
{
PgControl pgControl =
{
.version = PG_VERSION_11,
.systemId = 0xEFEFEFEFEF,
.walSegmentSize= 16 * 1024 * 1024,
.pageChecksum = true
};
TEST_RESULT_STR(
strPtr(pgControlToLog(&pgControl)),
"{version: 110000, systemId: 1030522662895, walSegmentSize: 16777216, pageChecksum: true}", "check log");
}
FUNCTION_HARNESS_RESULT_VOID();
}