mirror of
https://github.com/MariaDB/server.git
synced 2025-10-31 15:50:51 +03:00
d665e79c5b
for InnoDB tables" Don't use thr_lock.c locks for InnoDB tables. Below is list of changes that were needed to implement this: - HANDLER OPEN acquireis MDL_SHARED_READ instead of MDL_SHARED - HANDLER READ calls external_lock() even if SE is not going to be locked by THR_LOCK - InnoDB lock wait timeouts are now honored which are much shorter by default than server lock wait timeouts (1 year vs 50 seconds) - with @@autocommit= 1 LOCK TABLES disables autocommit implicitely, though user still sees @@autocommt= 1 - the above starts implicit transaction - transactions started by LOCK TABLES are now rolled back on disconnect (previously everything was committed due to autocommit) - transactions started by LOCK TABLES are now rolled back by ROLLBACK (previously everything was committed due to autocommit) - it is now impossible to change BINLOG_FORMAT under LOCK TABLES (at least to statement) due to running transaction - LOCK TABLES WRITE is additionally handled by MDL - ...in contrast LOCK TABLES READ protection against DML is pure InnoDB - combining transactional and non-transactional tables under LOCK TABLES may cause rolled back changes in transactional table and "committed" changes in non-transactional table - user may disable innodb_table_locks, which will cause LOCK TABLES to be noop basically Removed tests for BUG#45143 and BUG#55930 which cover InnoDB + THR_LOCK. To operate properly these tests require code flow to go through THR_LOCK debug sync points, which is not the case after this patch. These tests are removed by WL#6671 as well. An alternative is to port them to different storage engine.
67 lines
2.5 KiB
Plaintext
67 lines
2.5 KiB
Plaintext
DROP TABLE IF EXISTS t1, t2;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
#
|
|
# Bug#42438: Crash ha_partition::change_table_ptr
|
|
# Test when remove partitioning is done while drop table is waiting
|
|
# for the table.
|
|
# After MDL was introduced, there is no longer any race, so test is done
|
|
# by adding a small sleep to verify that the delete waits. This happens
|
|
# only until ALTER tries to upgrade its MDL lock, which ends up in MDL
|
|
# deadlock which is correctly reported.
|
|
connect con1, localhost, root,,;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
CREATE TABLE t1
|
|
(a INTEGER,
|
|
b INTEGER NOT NULL,
|
|
KEY (b))
|
|
ENGINE = MYISAM
|
|
/*!50100 PARTITION BY RANGE (a)
|
|
(PARTITION p0 VALUES LESS THAN (2),
|
|
PARTITION p1 VALUES LESS THAN (20),
|
|
PARTITION p2 VALUES LESS THAN (100),
|
|
PARTITION p3 VALUES LESS THAN MAXVALUE ) */;
|
|
SET DEBUG_SYNC= 'alter_table_before_create_table_no_lock SIGNAL removing_partitioning WAIT_FOR waiting_for_alter';
|
|
SET DEBUG_SYNC= 'mdl_acquire_lock_wait SIGNAL waiting_for_upgrade';
|
|
ALTER TABLE t1 REMOVE PARTITIONING;
|
|
connection default;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR removing_partitioning';
|
|
SET DEBUG_SYNC= 'mdl_acquire_lock_wait SIGNAL waiting_for_alter';
|
|
SET DEBUG_SYNC= 'rm_table_no_locks_before_delete_table WAIT_FOR waiting_for_upgrade';
|
|
DROP TABLE IF EXISTS t1;
|
|
connection con1;
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
connection default;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
connection con1;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
#
|
|
# Bug#42438: Crash ha_partition::change_table_ptr
|
|
# Test when remove partitioning is failing due to drop table is already
|
|
# in progress.
|
|
# After MDL was introduced, there is no longer any race, so test is done
|
|
# by adding a small sleep to verify that the alter waits.
|
|
CREATE TABLE t2
|
|
(a INTEGER,
|
|
b INTEGER NOT NULL,
|
|
KEY (b))
|
|
ENGINE = MYISAM
|
|
PARTITION BY RANGE (a) (PARTITION p0 VALUES LESS THAN (2),
|
|
PARTITION p1 VALUES LESS THAN (20),
|
|
PARTITION p2 VALUES LESS THAN (100),
|
|
PARTITION p3 VALUES LESS THAN MAXVALUE);
|
|
SET DEBUG_SYNC= 'alter_table_before_open_tables SIGNAL removing_partitions WAIT_FOR waiting_for_alter';
|
|
SET DEBUG_SYNC= 'alter_table_before_rename_result_table WAIT_FOR delete_done';
|
|
ALTER TABLE t2 REMOVE PARTITIONING;
|
|
connection default;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR removing_partitions';
|
|
SET DEBUG_SYNC= 'rm_table_no_locks_before_delete_table SIGNAL waiting_for_alter';
|
|
SET DEBUG_SYNC= 'rm_table_no_locks_before_binlog SIGNAL delete_done';
|
|
DROP TABLE IF EXISTS t2;
|
|
connection con1;
|
|
ERROR 42S02: Table 'test.t2' doesn't exist
|
|
SET DEBUG_SYNC= 'RESET';
|
|
disconnect con1;
|
|
connection default;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
End of 5.1 tests
|