mirror of
https://github.com/MariaDB/server.git
synced 2025-11-02 02:53:04 +03:00
e056efdd6c
1. In case of system-versioned table add row_end into FTS_DOC_ID index
in fts_create_common_tables() and innobase_create_key_defs().
fts_n_uniq() returns 1 or 2 depending on whether the table is
system-versioned.
After this patch recreate of FTS_DOC_ID index is required for
existing system-versioned tables. If you see this message in error
log or server warnings: "InnoDB: Table db/t1 contains 2 indexes
inside InnoDB, which is different from the number of indexes 1
defined in the MariaDB" use this command to fix the table:
ALTER TABLE db.t1 FORCE;
2. Fix duplicate history for secondary unique index like it was done
in MDEV-23644 for clustered index (932ec586aa). In case of
existing history row which conflicts with currently inseted row we
check in row_ins_scan_sec_index_for_duplicate() whether that row
was inserted as part of current transaction. In that case we
indicate with DB_FOREIGN_DUPLICATE_KEY that new history row is not
needed and should be silently skipped.
3. Some parts of MDEV-21138 (7410ff436e) reverted. Skipping of
FTS_DOC_ID index for history rows made problems with purge
system. Now this is fixed differently by p.2.
4. wait_all_purged.inc checks that we didn't affect non-history rows
so they are deleted and purged correctly.
Additional FTS fixes
fts_init_get_doc_id(): exclude history rows from max_doc_id
calculation. fts_init_get_doc_id() callback is used only for crash
recovery.
fts_add_doc_by_id(): set max value for row_end field.
fts_read_stopword(): stopwords table can be system-versioned too. We
now read stopwords only for current data.
row_insert_for_mysql(): exclude history rows from doc_id validation.
row_merge_read_clustered_index(): exclude history_rows from doc_id
processing.
fts_load_user_stopword(): for versioned table retrieve row_end field
and skip history rows. For non-versioned table we retrieve 'value'
field twice (just for uniformity).
FTS tests for System Versioning now include maybe_versioning.inc which
adds 3 combinations:
'vers' for debug build sets sysvers_force and
sysvers_hide. sysvers_force makes every created table
system-versioned, sysvers_hide hides WITH SYSTEM VERSIONING
for SHOW CREATE.
Note: basic.test, stopword.test and versioning.test do not
require debug for 'vers' combination. This is controlled by
$modify_create_table in maybe_versioning.inc and these
tests run WITH SYSTEM VERSIONING explicitly which allows to
test 'vers' combination on non-debug builds.
'vers_trx' like 'vers' sets sysvers_force_trx and sysvers_hide. That
tests FTS with trx_id-based System Versioning.
'orig' works like before: no System Versioning is added, no debug is
required.
Upgrade/downgrade test for System Versioning is done by
innodb_fts.versioning. It has 2 combinations:
'prepare' makes binaries in std_data (requires old server and OLD_BINDIR).
It tests upgrade/downgrade against old server as well.
'upgrade' tests upgrade against binaries in std_data.
Cleanups:
Removed innodb-fts-stopword.test as it duplicates stopword.test
190 lines
5.1 KiB
Plaintext
190 lines
5.1 KiB
Plaintext
set @saved_frequency= @@global.innodb_purge_rseg_truncate_frequency;
|
|
set global innodb_purge_rseg_truncate_frequency= 1;
|
|
create table t (a int);
|
|
delete history from t before system_time now();
|
|
ERROR HY000: Table `t` is not system-versioned
|
|
create or replace table t (
|
|
a int,
|
|
row_start SYS_TYPE as row start invisible,
|
|
row_end SYS_TYPE as row end invisible,
|
|
period for system_time (row_start, row_end))
|
|
with system versioning;
|
|
insert into t values (1);
|
|
update t set a=2;
|
|
set @test = 'correct';
|
|
create trigger trg_before before delete on t for each row set @test = 'incorrect';
|
|
create trigger trg_after after delete on t for each row set @test = 'incorrect';
|
|
delete history from t;
|
|
select @test from t;
|
|
@test
|
|
correct
|
|
drop table t;
|
|
create or replace table t (
|
|
a int,
|
|
row_start SYS_TYPE as row start invisible,
|
|
row_end SYS_TYPE as row end invisible,
|
|
period for system_time (row_start, row_end))
|
|
with system versioning;
|
|
insert into t values (1), (2);
|
|
update t set a=11 where a=1;
|
|
set @ts1=now(6);
|
|
update t set a=22 where a=2;
|
|
select * from t for system_time all;
|
|
a
|
|
11
|
|
22
|
|
1
|
|
2
|
|
delete history from t before system_time timestamp @ts1;
|
|
select * from t for system_time all;
|
|
a
|
|
11
|
|
22
|
|
2
|
|
prepare stmt from 'delete history from t';
|
|
execute stmt;
|
|
drop prepare stmt;
|
|
select * from t for system_time all;
|
|
a
|
|
11
|
|
22
|
|
delete from t;
|
|
create or replace procedure truncate_sp()
|
|
begin
|
|
delete history from t before system_time timestamp now(6);
|
|
end~~
|
|
call truncate_sp;
|
|
select * from t for system_time all;
|
|
a
|
|
drop procedure truncate_sp;
|
|
# Truncate partitioned
|
|
create or replace table t (a int)
|
|
with system versioning
|
|
partition by system_time limit 1 (
|
|
partition p0 history,
|
|
partition p1 history,
|
|
partition pn current);
|
|
insert into t values (1);
|
|
update t set a= 2;
|
|
update t set a= 3;
|
|
Warnings:
|
|
Warning 4114 Versioned table `test`.`t`: partition `p1` is full, add more HISTORY partitions
|
|
# You see warning above ^
|
|
delete history from t;
|
|
select * from t for system_time all;
|
|
a
|
|
3
|
|
# VIEW
|
|
create or replace table t (
|
|
i int,
|
|
row_start SYS_TYPE as row start invisible,
|
|
row_end SYS_TYPE as row end invisible,
|
|
period for system_time (row_start, row_end))
|
|
with system versioning;
|
|
delete history from t;
|
|
create or replace view v as select * from t;
|
|
delete history from v;
|
|
ERROR 42S02: 'v' is a view
|
|
create or replace table t (i int);
|
|
delete history from t;
|
|
ERROR HY000: Table `t` is not system-versioned
|
|
create or replace view v as select * from t;
|
|
delete history from v;
|
|
ERROR 42S02: 'v' is a view
|
|
prepare stmt from 'delete history from t';
|
|
ERROR HY000: Table `t` is not system-versioned
|
|
drop table t;
|
|
drop view v;
|
|
create or replace table t (i int);
|
|
create or replace view v as select * from t;
|
|
drop table v;
|
|
ERROR 42S02: 'test.v' is a view
|
|
lock table v write;
|
|
delete history from v before system_time now(6);
|
|
ERROR 42S02: 'v' is a view
|
|
unlock tables;
|
|
drop view v;
|
|
drop table t;
|
|
create table t1 (i int) with system versioning;
|
|
create procedure pr() delete history from t1 before system_time now();
|
|
call pr;
|
|
call pr;
|
|
drop procedure pr;
|
|
drop table t1;
|
|
#
|
|
# MDEV-19814 Assertion `update->n_fields < ulint(table->n_cols + table->n_v_cols)' on DELETE HISTORY
|
|
#
|
|
create or replace table t1 (
|
|
f varchar(1),
|
|
row_start SYS_TYPE as row start,
|
|
row_end SYS_TYPE as row end,
|
|
period for system_time (row_start, row_end))
|
|
with system versioning;
|
|
insert into t1 (f) values ('a'), ('b'), ('c'), ('d'), ('e'), ('f'), ('g'), ('h');
|
|
delete from t1;
|
|
delete history from t1;
|
|
drop table t1;
|
|
#
|
|
# MDEV-20186 Wrong result or Assertion on INSERT after DELETE HISTORY
|
|
#
|
|
create or replace table t1 (a int check (a > 0)) with system versioning;
|
|
delete history from t1;
|
|
insert into t1 values (1);
|
|
select * from t1;
|
|
a
|
|
1
|
|
drop table t1;
|
|
#
|
|
# MDEV-25468 DELETE HISTORY may delete current data on system-versioned table
|
|
#
|
|
create or replace table t1 (x int) with system versioning;
|
|
insert into t1 values (1);
|
|
delete history from t1 before system_time '2039-01-01 23:00';
|
|
select * from t1;
|
|
x
|
|
1
|
|
explain extended delete history from t1 before system_time '2039-01-01 23:00';
|
|
id select_type table type possible_keys key key_len ref rows filtered Extra
|
|
1 SIMPLE t1 ALL NULL NULL NULL NULL 1 100.00 Using where
|
|
create or replace procedure p() delete history from t1 before system_time '2039-01-01 23:00';
|
|
call p;
|
|
select * from t1;
|
|
x
|
|
1
|
|
call p;
|
|
select * from t1;
|
|
x
|
|
1
|
|
drop procedure p;
|
|
prepare stmt from "delete history from t1 before system_time '2039-01-01 23:00'";
|
|
execute stmt;
|
|
select * from t1;
|
|
x
|
|
1
|
|
execute stmt;
|
|
select * from t1;
|
|
x
|
|
1
|
|
drop prepare stmt;
|
|
drop table t1;
|
|
#
|
|
# MDEV-25004 Missing row in FTS_DOC_ID_INDEX during DELETE HISTORY
|
|
#
|
|
create table t1 (a integer, c0 varchar(255), fulltext key (c0))
|
|
with system versioning engine innodb;
|
|
set system_versioning_alter_history= keep;
|
|
alter table t1 drop system versioning;
|
|
alter table t1 add system versioning;
|
|
insert into t1 values (1, 'politician');
|
|
update t1 set c0= 'criminal';
|
|
InnoDB 0 transactions not purged
|
|
delete history from t1;
|
|
drop table t1;
|
|
create table t1 (id int primary key, ftx varchar(255))
|
|
with system versioning engine innodb;
|
|
insert into t1 values (1, 'c');
|
|
delete from t1;
|
|
alter table t1 add fulltext key(ftx);
|
|
drop table t1;
|
|
set global innodb_purge_rseg_truncate_frequency= @saved_frequency;
|