mirror of
https://github.com/MariaDB/server.git
synced 2025-09-02 09:41:40 +03:00
f3985c649d
General overview: The logic for switching to row format when binlog_format=MIXED had numerous flaws. The underlying problem was the lack of a consistent architecture. General purpose of this changeset: This changeset introduces an architecture for switching to row format when binlog_format=MIXED. It enforces the architecture where it has to. It leaves some bugs to be fixed later. It adds extensive tests to verify that unsafe statements work as expected and that appropriate errors are produced by problems with the selection of binlog format. It was not practical to split this into smaller pieces of work. Problem 1: To determine the logging mode, the code has to take several parameters into account (namely: (1) the value of binlog_format; (2) the capabilities of the engines; (3) the type of the current statement: normal, unsafe, or row injection). These parameters may conflict in several ways, namely: - binlog_format=STATEMENT for a row injection - binlog_format=STATEMENT for an unsafe statement - binlog_format=STATEMENT for an engine only supporting row logging - binlog_format=ROW for an engine only supporting statement logging - statement is unsafe and engine does not support row logging - row injection in a table that does not support statement logging - statement modifies one table that does not support row logging and one that does not support statement logging Several of these conflicts were not detected, or were detected with an inappropriate error message. The problem of BUG#39934 was that no appropriate error message was written for the case when an engine only supporting row logging executed a row injection with binlog_format=ROW. However, all above cases must be handled. Fix 1: Introduce new error codes (sql/share/errmsg.txt). Ensure that all conditions are detected and handled in decide_logging_format() Problem 2: The binlog format shall be determined once per statement, in decide_logging_format(). It shall not be changed before or after that. Before decide_logging_format() is called, all information necessary to determine the logging format must be available. This principle ensures that all unsafe statements are handled in a consistent way. However, this principle is not followed: thd->set_current_stmt_binlog_row_based_if_mixed() is called in several places, including from code executing UPDATE..LIMIT, INSERT..SELECT..LIMIT, DELETE..LIMIT, INSERT DELAYED, and SET @@binlog_format. After Problem 1 was fixed, that caused inconsistencies where these unsafe statements would not print the appropriate warnings or errors for some of the conflicts. Fix 2: Remove calls to THD::set_current_stmt_binlog_row_based_if_mixed() from code executed after decide_logging_format(). Compensate by calling the set_current_stmt_unsafe() at parse time. This way, all unsafe statements are detected by decide_logging_format(). Problem 3: INSERT DELAYED is not unsafe: it is logged in statement format even if binlog_format=MIXED, and no warning is printed even if binlog_format=STATEMENT. This is BUG#45825. Fix 3: Made INSERT DELAYED set itself to unsafe at parse time. This allows decide_logging_format() to detect that a warning should be printed or the binlog_format changed. Problem 4: LIMIT clause were not marked as unsafe when executed inside stored functions/triggers/views/prepared statements. This is BUG#45785. Fix 4: Make statements containing the LIMIT clause marked as unsafe at parse time, instead of at execution time. This allows propagating unsafe-ness to the view.
122 lines
3.4 KiB
Plaintext
122 lines
3.4 KiB
Plaintext
source include/have_binlog_format_statement.inc;
|
|
source include/master-slave.inc;
|
|
|
|
# It is not possible to replicate FOUND_ROWS() using statement-based
|
|
# replication, but there is a workaround that stores the result of
|
|
# FOUND_ROWS() into a user variable and then replicates this instead.
|
|
|
|
# The purpose of this test case is to test that the workaround
|
|
# function properly even when inside stored programs (i.e., stored
|
|
# routines and triggers).
|
|
|
|
--echo ==== Initialize ====
|
|
|
|
--echo **** On Master ****
|
|
connection master;
|
|
CREATE TABLE t1 (a INT);
|
|
CREATE TABLE logtbl (sect INT, test INT, count INT);
|
|
|
|
INSERT INTO t1 VALUES (1),(2),(3);
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
INSERT INTO t1 SELECT 2*a+3 FROM t1;
|
|
|
|
|
|
--echo ==== Simple test ====
|
|
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
|
|
# Instead of
|
|
# INSERT INTO logtbl VALUES(1, 1, FOUND_ROWS());
|
|
# we write
|
|
SELECT FOUND_ROWS() INTO @a;
|
|
INSERT INTO logtbl VALUES(1,1,@a);
|
|
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
# Instead of
|
|
# INSERT INTO logtbl VALUES(1, 2, FOUND_ROWS());
|
|
# we write
|
|
SELECT FOUND_ROWS() INTO @a;
|
|
INSERT INTO logtbl VALUES(1,2,@a);
|
|
|
|
SELECT * FROM logtbl WHERE sect = 1 ORDER BY sect,test;
|
|
--echo **** On Slave ****
|
|
sync_slave_with_master;
|
|
SELECT * FROM logtbl WHERE sect = 1 ORDER BY sect,test;
|
|
|
|
|
|
--echo ==== Stored procedure ====
|
|
|
|
# Here we do both the calculation and the logging. We also do it twice
|
|
# to make sure that there are no limitations on how many times it can
|
|
# be used.
|
|
|
|
--echo **** On Master ****
|
|
connection master;
|
|
--delimiter $$
|
|
CREATE PROCEDURE calc_and_log(sect INT, test INT) BEGIN
|
|
DECLARE cnt INT;
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a < 5 ORDER BY a LIMIT 1;
|
|
SELECT FOUND_ROWS() INTO cnt;
|
|
INSERT INTO logtbl VALUES(sect,test,cnt);
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
SELECT FOUND_ROWS() INTO cnt;
|
|
INSERT INTO logtbl VALUES(sect,test+1,cnt);
|
|
END $$
|
|
--delimiter ;
|
|
|
|
CALL calc_and_log(2,1);
|
|
|
|
--delimiter $$
|
|
CREATE PROCEDURE just_log(sect INT, test INT, found_rows INT) BEGIN
|
|
INSERT INTO logtbl VALUES (sect,test,found_rows);
|
|
END $$
|
|
--delimiter ;
|
|
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
SELECT FOUND_ROWS() INTO @found_rows;
|
|
CALL just_log(2,3,@found_rows);
|
|
|
|
SELECT * FROM logtbl WHERE sect = 2 ORDER BY sect,test;
|
|
--echo **** On Slave ****
|
|
sync_slave_with_master;
|
|
SELECT * FROM logtbl WHERE sect = 2 ORDER BY sect,test;
|
|
|
|
|
|
--echo ==== Stored functions ====
|
|
--echo **** On Master ****
|
|
connection master;
|
|
--delimiter $$
|
|
CREATE FUNCTION log_rows(sect INT, test INT, found_rows INT)
|
|
RETURNS INT
|
|
BEGIN
|
|
INSERT INTO logtbl VALUES(sect,test,found_rows);
|
|
RETURN found_rows;
|
|
END $$
|
|
--delimiter ;
|
|
|
|
SELECT SQL_CALC_FOUND_ROWS * FROM t1 WHERE a > 5 ORDER BY a LIMIT 1;
|
|
SELECT FOUND_ROWS() INTO @found_rows;
|
|
SELECT log_rows(3,1,@found_rows), log_rows(3,2,@found_rows);
|
|
|
|
SELECT * FROM logtbl WHERE sect = 3 ORDER BY sect,test;
|
|
--echo **** On Slave ****
|
|
sync_slave_with_master;
|
|
SELECT * FROM logtbl WHERE sect = 3 ORDER BY sect,test;
|
|
|
|
|
|
--echo ==== Cleanup ====
|
|
--echo **** On Master ****
|
|
connection master;
|
|
DROP TABLE t1, logtbl;
|
|
DROP PROCEDURE just_log;
|
|
DROP PROCEDURE calc_and_log;
|
|
DROP FUNCTION log_rows;
|
|
sync_slave_with_master;
|
|
|
|
source include/reset_master_and_slave.inc;
|
|
|