mirror of
https://github.com/MariaDB/server.git
synced 2025-08-26 01:44:06 +03:00
f3985c649d
General overview: The logic for switching to row format when binlog_format=MIXED had numerous flaws. The underlying problem was the lack of a consistent architecture. General purpose of this changeset: This changeset introduces an architecture for switching to row format when binlog_format=MIXED. It enforces the architecture where it has to. It leaves some bugs to be fixed later. It adds extensive tests to verify that unsafe statements work as expected and that appropriate errors are produced by problems with the selection of binlog format. It was not practical to split this into smaller pieces of work. Problem 1: To determine the logging mode, the code has to take several parameters into account (namely: (1) the value of binlog_format; (2) the capabilities of the engines; (3) the type of the current statement: normal, unsafe, or row injection). These parameters may conflict in several ways, namely: - binlog_format=STATEMENT for a row injection - binlog_format=STATEMENT for an unsafe statement - binlog_format=STATEMENT for an engine only supporting row logging - binlog_format=ROW for an engine only supporting statement logging - statement is unsafe and engine does not support row logging - row injection in a table that does not support statement logging - statement modifies one table that does not support row logging and one that does not support statement logging Several of these conflicts were not detected, or were detected with an inappropriate error message. The problem of BUG#39934 was that no appropriate error message was written for the case when an engine only supporting row logging executed a row injection with binlog_format=ROW. However, all above cases must be handled. Fix 1: Introduce new error codes (sql/share/errmsg.txt). Ensure that all conditions are detected and handled in decide_logging_format() Problem 2: The binlog format shall be determined once per statement, in decide_logging_format(). It shall not be changed before or after that. Before decide_logging_format() is called, all information necessary to determine the logging format must be available. This principle ensures that all unsafe statements are handled in a consistent way. However, this principle is not followed: thd->set_current_stmt_binlog_row_based_if_mixed() is called in several places, including from code executing UPDATE..LIMIT, INSERT..SELECT..LIMIT, DELETE..LIMIT, INSERT DELAYED, and SET @@binlog_format. After Problem 1 was fixed, that caused inconsistencies where these unsafe statements would not print the appropriate warnings or errors for some of the conflicts. Fix 2: Remove calls to THD::set_current_stmt_binlog_row_based_if_mixed() from code executed after decide_logging_format(). Compensate by calling the set_current_stmt_unsafe() at parse time. This way, all unsafe statements are detected by decide_logging_format(). Problem 3: INSERT DELAYED is not unsafe: it is logged in statement format even if binlog_format=MIXED, and no warning is printed even if binlog_format=STATEMENT. This is BUG#45825. Fix 3: Made INSERT DELAYED set itself to unsafe at parse time. This allows decide_logging_format() to detect that a warning should be printed or the binlog_format changed. Problem 4: LIMIT clause were not marked as unsafe when executed inside stored functions/triggers/views/prepared statements. This is BUG#45785. Fix 4: Make statements containing the LIMIT clause marked as unsafe at parse time, instead of at execution time. This allows propagating unsafe-ness to the view.
105 lines
2.8 KiB
Plaintext
105 lines
2.8 KiB
Plaintext
# Test to test how logging is done depending on the capabilities of
|
|
# the engines. Unfortunately, we don't have a good row-only logging
|
|
# engine, and NDB does not really cut is since it is also
|
|
# self-logging. I'm using it nevertheless.
|
|
|
|
source include/have_blackhole.inc;
|
|
source include/have_ndb.inc;
|
|
source include/have_log_bin.inc;
|
|
|
|
CREATE TABLE t1m (m INT, n INT) ENGINE=MYISAM;
|
|
CREATE TABLE t1b (b INT, c INT) ENGINE=BLACKHOLE;
|
|
CREATE TABLE t1n (e INT, f INT) ENGINE=NDB;
|
|
|
|
RESET MASTER;
|
|
|
|
SET SESSION BINLOG_FORMAT=STATEMENT;
|
|
|
|
INSERT INTO t1b VALUES (1,1), (1,2), (2,1), (2,2);
|
|
INSERT INTO t1m VALUES (1,1), (1,2), (2,1), (2,2);
|
|
|
|
UPDATE t1m, t1b SET m = 2, b = 3 WHERE n = c;
|
|
|
|
# Here and below we need to wait when some event appears in binlog
|
|
# to avoid unsrted mixing local events and from NDB
|
|
let $wait_binlog_event= t1m, t1b;
|
|
source include/wait_for_binlog_event.inc;
|
|
|
|
echo *** Please look in binlog_multi_engine.test if you have a diff here ****;
|
|
START TRANSACTION;
|
|
INSERT INTO t1n VALUES (1,1), (1,2), (2,1), (2,2);
|
|
UPDATE t1m, t1n SET m = 2, e = 3 WHERE n = f;
|
|
UPDATE t1n, t1b SET e = 2, b = 3 WHERE f = c;
|
|
COMMIT;
|
|
|
|
let $wait_binlog_event= COMMIT;
|
|
source include/wait_for_binlog_event.inc;
|
|
|
|
TRUNCATE t1m;
|
|
TRUNCATE t1b;
|
|
TRUNCATE t1n;
|
|
|
|
let $wait_binlog_event= t1n;
|
|
source include/wait_for_binlog_event.inc;
|
|
|
|
source include/show_binlog_events.inc;
|
|
|
|
RESET MASTER;
|
|
|
|
SET SESSION BINLOG_FORMAT=MIXED;
|
|
|
|
INSERT INTO t1b VALUES (1,1), (1,2), (2,1), (2,2);
|
|
INSERT INTO t1m VALUES (1,1), (1,2), (2,1), (2,2);
|
|
|
|
let $wait_binlog_event= t1m;
|
|
source include/wait_for_binlog_event.inc;
|
|
|
|
INSERT INTO t1n VALUES (1,1), (1,2), (2,1), (2,2);
|
|
|
|
let $wait_binlog_event= COMMIT;
|
|
source include/wait_for_binlog_event.inc;
|
|
|
|
UPDATE t1m, t1b SET m = 2, b = 3 WHERE n = c;
|
|
error ER_BINLOG_MULTIPLE_ENGINES_AND_SELF_LOGGING_ENGINE;
|
|
UPDATE t1m, t1n SET m = 2, e = 3 WHERE n = f;
|
|
|
|
# Not possible to test this since NDB writes its own binlog, which
|
|
# might cause it to be out of sync with the results from MyISAM.
|
|
# This will generate an error once BUG#28722 is fixed.
|
|
|
|
#UPDATE t1m, t1n SET m = 2, e = 3 WHERE n = f;
|
|
|
|
TRUNCATE t1m;
|
|
TRUNCATE t1b;
|
|
TRUNCATE t1n;
|
|
|
|
source include/show_binlog_events.inc;
|
|
|
|
RESET MASTER;
|
|
|
|
SET SESSION BINLOG_FORMAT=ROW;
|
|
|
|
INSERT INTO t1m VALUES (1,1), (1,2), (2,1), (2,2);
|
|
|
|
INSERT INTO t1b VALUES (1,1), (1,2), (2,1), (2,2);
|
|
INSERT INTO t1n VALUES (1,1), (1,2), (2,1), (2,2);
|
|
|
|
error ER_BINLOG_MULTIPLE_ENGINES_AND_SELF_LOGGING_ENGINE;
|
|
UPDATE t1m, t1n SET m = 2, e = 3 WHERE n = f;
|
|
|
|
# Not possible to test this since NDB writes its own binlog, which
|
|
# might cause it to be out of sync with the results from MyISAM.
|
|
# This will generate an error once BUG#28722 is fixed.
|
|
|
|
#UPDATE t1m, t1n SET m = 2, e = 3 WHERE n = f;
|
|
|
|
error ER_BINLOG_MULTIPLE_ENGINES_AND_SELF_LOGGING_ENGINE;
|
|
UPDATE t1n, t1b SET e = 2, b = 3 WHERE f = c;
|
|
|
|
source include/show_binlog_events.inc;
|
|
|
|
RESET MASTER;
|
|
|
|
DROP TABLE t1m, t1b, t1n;
|
|
|