mirror of
https://github.com/MariaDB/server.git
synced 2025-08-30 11:22:14 +03:00
Fix mysql-test-run.pl to not terminate early when warnings in error logs are detected during server shutdown. Instead, give a nice summary report at the end of the failures. Fix code to make 100% sure no failures will go undetected. Revert earlier wrong change. Fix race with port allocation semaphore file permissions. Adjust testsuite to copy with new PBXT engine now in the tree. The PBXT engine causes an extra table to appear in the INFORMATION_SCHEMA. This causes different output for a few test cases. dbug/dbug.c: If DbugParse() is called multiple times, the stack->keywords for the top stack frame could be overwritten without being freed, causing a memory leak reported by Valgrind. include/my_global.h: Add useful macro for different values when Valgrind (HAVE_purify) and not. mysql-test/extra/rpl_tests/rpl_auto_increment.test: Omit pbxt variables from show variables output. mysql-test/include/have_pbxt.inc: Add facility to disable test if PBXT engine is not available. mysql-test/lib/mtr_report.pm: Give a nice summary report at the end of tests of any warnings seen in logs during server shutdowns. mysql-test/lib/mtr_unique.pm: Move chmod 777 to greatly reduce the risk of leaving the port semaphore file unaccessible bu other users. mysql-test/mysql-test-run.pl: Don't abort in case of warnings detected, instead give a nice summary report. Fix code to make 100% sure no failures will go undetected. Revert earlier wrong change when master disconnects early. mysql-test/r/information_schema.result: Omit PBXT INFORMATION_SCHEMA table from output. Move part of test to information_schema_all_engines. mysql-test/r/information_schema_all_engines.result: New file for information_schema tests that depend on which engines are available. mysql-test/r/information_schema_db.result: Move part of test to information_schema_all_engines. mysql-test/r/innodb-autoinc.result: Omit pbxt variables from show variables output. mysql-test/r/mysqlshow.result: Move part of test to information_schema_all_engines. mysql-test/suite/rpl/r/rpl_auto_increment.result: Omit pbxt variables from show variables output. mysql-test/t/information_schema.test: Omit PBXT INFORMATION_SCHEMA table from output. Move part of test to information_schema_all_engines. mysql-test/t/information_schema_all_engines.test: New file for information_schema tests that depend on which engines are available. mysql-test/t/information_schema_db.test: Move part of test to information_schema_all_engines. mysql-test/t/innodb-autoinc.test: Omit pbxt variables from show variables output. mysql-test/t/mysqlshow.test: Move part of test to information_schema_all_engines. mysql-test/valgrind.supp: Add variant suppression (different system library versions). Add suppression for problem with inet_ntoa(). sql/mysqld.cc: Fix missing DBUG_RETURN. Fix uninitialised thd->connect_utime, likely introduced by pool_of_threads. sql/set_var.cc: Fix one-byte buffer overflow in several places. Fix unsafe use of String::c_ptr() of stack-allocated String buffer. sql/sql_select.cc: Silence valgrind warning due to GCC bug. sql/sql_string.h: Document potential problem with String::c_ptr() and String() constructor with caller-supplied buffer. storage/archive/azio.c: Silence Valgrind false warning for libz.
620 lines
9.7 KiB
Plaintext
620 lines
9.7 KiB
Plaintext
#
|
|
# Suppress some common (not fatal) errors in system libraries found by valgrind
|
|
#
|
|
|
|
#
|
|
# Pthread doesn't free all thread specific memory before program exists
|
|
#
|
|
{
|
|
pthread allocate_tls memory loss
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dl_allocate_tls
|
|
fun:allocate_stack
|
|
fun:pthread_create*
|
|
}
|
|
|
|
{
|
|
pthread allocate_tls memory loss
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dl_allocate_tls
|
|
fun:pthread_create*
|
|
|
|
}
|
|
|
|
{
|
|
pthread allocate_tls memory loss
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
obj:/lib*/ld*.so
|
|
fun:_dl_allocate_tls
|
|
fun:pthread_create*
|
|
}
|
|
|
|
{
|
|
pthead_exit memory loss 1
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:_dl_new_object
|
|
fun:_dl_map_object_from_fd
|
|
}
|
|
|
|
{
|
|
pthread_exit memory loss 2
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:_dl_map_object
|
|
fun:dl_open_worker
|
|
}
|
|
|
|
{
|
|
pthread_exit memory loss 3
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:_dl_map_object_deps
|
|
fun:dl_open_worker
|
|
}
|
|
|
|
{
|
|
pthread_exit memory loss 4
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dl_check_map_versions
|
|
fun:dl_open_worker
|
|
}
|
|
|
|
{
|
|
pthread_exit memory loss 5
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dl_new_object
|
|
fun:_dl_map_object_from_fd
|
|
}
|
|
|
|
{
|
|
pthread allocate_dtv memory loss
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:allocate_dtv
|
|
fun:_dl_allocate_tls_storage
|
|
fun:__GI__dl_allocate_tls
|
|
fun:pthread_create
|
|
}
|
|
|
|
{
|
|
pthread allocate_dtv memory loss second
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:allocate_dtv
|
|
fun:_dl_allocate_tls
|
|
fun:pthread_create*
|
|
}
|
|
|
|
{
|
|
pthread memalign memory loss
|
|
Memcheck:Leak
|
|
fun:memalign
|
|
fun:_dl_allocate_tls_storage
|
|
fun:__GI__dl_allocate_tls
|
|
fun:pthread_create
|
|
}
|
|
|
|
{
|
|
pthread pthread_key_create
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:*
|
|
fun:*
|
|
fun:pthread_key_create
|
|
fun:my_thread_global_init
|
|
}
|
|
|
|
{
|
|
pthread strstr uninit
|
|
Memcheck:Cond
|
|
fun:strstr
|
|
obj:/lib/tls/libpthread.so.*
|
|
obj:/lib/tls/libpthread.so.*
|
|
fun:call_init
|
|
fun:_dl_init
|
|
obj:/lib/ld-*.so
|
|
}
|
|
|
|
{
|
|
pthread strstr uninit
|
|
Memcheck:Cond
|
|
fun:strstr
|
|
obj:/lib/tls/libpthread.so.*
|
|
obj:/lib/tls/libpthread.so.*
|
|
fun:call_init
|
|
fun:_dl_init
|
|
obj:/lib/ld-*.so
|
|
}
|
|
|
|
{
|
|
strlen/_dl_init_paths/dl_main/_dl_sysdep_start(Cond)
|
|
Memcheck:Cond
|
|
fun:strlen
|
|
fun:_dl_init_paths
|
|
fun:dl_main
|
|
fun:_dl_sysdep_start
|
|
}
|
|
|
|
{
|
|
pthread errno
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dlerror_run
|
|
fun:dlsym
|
|
fun:__errno_location
|
|
}
|
|
|
|
|
|
#
|
|
# Warnings in libz becasue it works with aligned memory(?)
|
|
#
|
|
|
|
{
|
|
libz tr_flush_block
|
|
Memcheck:Cond
|
|
fun:_tr_flush_block
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:do_flush
|
|
fun:gzclose
|
|
}
|
|
|
|
{
|
|
libz tr_flush_block2
|
|
Memcheck:Cond
|
|
fun:_tr_flush_block
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:compress2
|
|
}
|
|
|
|
{
|
|
libz longest_match
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:do_flush
|
|
}
|
|
|
|
{
|
|
libz longest_match2
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:compress2
|
|
}
|
|
|
|
{
|
|
libz longest_match 3
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:gzclose
|
|
}
|
|
|
|
{
|
|
libz longest_match 4
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:gzflush
|
|
}
|
|
|
|
{
|
|
libz longest_match3
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:azflush
|
|
}
|
|
|
|
{
|
|
libz longest_match3
|
|
Memcheck:Cond
|
|
fun:longest_match
|
|
fun:deflate_slow
|
|
fun:deflate
|
|
fun:azclose
|
|
}
|
|
|
|
{
|
|
libz deflate
|
|
Memcheck:Cond
|
|
obj:*/libz.so.*
|
|
obj:*/libz.so.*
|
|
fun:deflate
|
|
fun:compress2
|
|
}
|
|
|
|
{
|
|
libz deflate2
|
|
Memcheck:Cond
|
|
obj:*/libz.so.*
|
|
obj:*/libz.so.*
|
|
fun:deflate
|
|
obj:*/libz.so.*
|
|
fun:gzflush
|
|
}
|
|
|
|
{
|
|
libz deflate3
|
|
Memcheck:Cond
|
|
obj:*/libz.so.*
|
|
obj:*/libz.so.*
|
|
fun:deflate
|
|
fun:do_flush
|
|
}
|
|
|
|
#
|
|
# Warning from my_thread_init becasue mysqld dies before kill thread exists
|
|
#
|
|
|
|
{
|
|
my_thread_init kill thread memory loss second
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:my_thread_init
|
|
fun:kill_server_thread
|
|
}
|
|
|
|
|
|
# Red Hat AS 4 32 bit
|
|
{
|
|
dl_relocate_object
|
|
Memcheck:Cond
|
|
fun:_dl_relocate_object
|
|
}
|
|
|
|
#
|
|
# Leaks reported in _dl_* internal functions on Linux amd64 / glibc2.3.2.
|
|
#
|
|
|
|
{
|
|
_dl_start invalid write8
|
|
Memcheck:Addr8
|
|
fun:_dl_start
|
|
}
|
|
|
|
{
|
|
_dl_start invalid write4
|
|
Memcheck:Addr4
|
|
fun:_dl_start
|
|
}
|
|
|
|
{
|
|
_dl_start/_dl_setup_hash invalid read8
|
|
Memcheck:Addr8
|
|
fun:_dl_setup_hash
|
|
fun:_dl_start
|
|
}
|
|
|
|
{
|
|
_dl_sysdep_start invalid write8
|
|
Memcheck:Addr8
|
|
fun:_dl_sysdep_start
|
|
}
|
|
|
|
{
|
|
_dl_init invalid write8
|
|
Memcheck:Addr8
|
|
fun:_dl_init
|
|
}
|
|
|
|
{
|
|
_dl_init invalid write4
|
|
Memcheck:Addr4
|
|
fun:_dl_init
|
|
}
|
|
|
|
{
|
|
_dl_init/_dl_init invalid read8
|
|
Memcheck:Addr8
|
|
fun:_dl_debug_initialize
|
|
fun:_dl_init
|
|
}
|
|
|
|
{
|
|
_dl_init/_dl_debug_state invalid read8
|
|
Memcheck:Addr8
|
|
fun:_dl_debug_state
|
|
fun:_dl_init
|
|
}
|
|
|
|
{
|
|
init invalid write8
|
|
Memcheck:Addr8
|
|
fun:init
|
|
}
|
|
|
|
{
|
|
fixup invalid write8
|
|
Memcheck:Addr8
|
|
fun:fixup
|
|
}
|
|
|
|
{
|
|
fixup/_dl_lookup_versioned_symbol invalid read8
|
|
Memcheck:Addr8
|
|
fun:_dl_lookup_versioned_symbol
|
|
fun:fixup
|
|
}
|
|
|
|
{
|
|
_dl_runtime_resolve invalid read8
|
|
Memcheck:Addr8
|
|
fun:_dl_runtime_resolve
|
|
}
|
|
|
|
{
|
|
__libc_start_main invalid write8
|
|
Memcheck:Addr8
|
|
fun:__libc_start_main
|
|
}
|
|
|
|
{
|
|
__libc_start_main/__sigjmp_save invalid write4
|
|
Memcheck:Addr4
|
|
fun:__sigjmp_save
|
|
fun:__libc_start_main
|
|
}
|
|
|
|
{
|
|
dlclose memory loss from udf_free
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dlerror_run
|
|
fun:dlclose
|
|
fun:_Z8udf_freev
|
|
}
|
|
|
|
{
|
|
dlclose memory loss from plugin variant 1
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dlerror_run
|
|
fun:dlclose
|
|
fun:plugin_dl_del(st_mysql_lex_string const*)
|
|
}
|
|
|
|
{
|
|
dlclose memory loss from plugin variant 2
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:_dl_close_worker
|
|
fun:_dl_close
|
|
fun:_dl_catch_error
|
|
fun:_dlerror_run
|
|
fun:dlclose
|
|
fun:_Z15free_plugin_memP12st_plugin_dl
|
|
fun:_Z13plugin_dl_delPK19st_mysql_lex_string
|
|
}
|
|
|
|
{
|
|
dlopen / ptread_cancel_init memory loss on Suse Linux 10.3 32/64 bit
|
|
Memcheck:Leak
|
|
fun:*alloc
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/libc-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/libc-*.so
|
|
fun:__libc_dlopen_mode
|
|
fun:pthread_cancel_init
|
|
fun:_Unwind_ForcedUnwind
|
|
}
|
|
|
|
{
|
|
dlopen / ptread_cancel_init memory loss on Suse Linux 10.3 32/64 bit
|
|
Memcheck:Leak
|
|
fun:*alloc
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/libc-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/libc-*.so
|
|
fun:__libc_dlopen_mode
|
|
fun:pthread_cancel_init
|
|
fun:_Unwind_ForcedUnwind
|
|
}
|
|
|
|
#
|
|
# Reading wrong addresses on SuSe Linux 10.3 32 bit
|
|
#
|
|
|
|
{
|
|
Reading wrong data in libc_dlopen
|
|
Memcheck:Addr4
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/libc-*.so
|
|
obj:/lib*/ld-*.so
|
|
obj:/lib*/libc-*.so
|
|
fun:__libc_dlopen_mode
|
|
fun:pthread_cancel_init
|
|
}
|
|
|
|
#
|
|
# These seem to be libc threading stuff, not related to MySQL code (allocations
|
|
# during pthread_exit()). Googling shows other projects also using these
|
|
# suppressions.
|
|
#
|
|
# Note that these all stem from pthread_exit() deeper in the call stack, but
|
|
# Valgrind only allows the top four calls in the suppressions.
|
|
#
|
|
|
|
{
|
|
libc pthread_exit 1
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:_dl_new_object
|
|
fun:_dl_map_object_from_fd
|
|
fun:_dl_map_object
|
|
}
|
|
|
|
{
|
|
libc pthread_exit 2
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:_dl_map_object
|
|
fun:dl_open_worker
|
|
fun:_dl_catch_error
|
|
}
|
|
|
|
{
|
|
libc pthread_exit 3
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:_dl_map_object_deps
|
|
fun:dl_open_worker
|
|
fun:_dl_catch_error
|
|
}
|
|
|
|
{
|
|
libc pthread_exit 4
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dl_check_map_versions
|
|
fun:dl_open_worker
|
|
fun:_dl_catch_error
|
|
}
|
|
|
|
{
|
|
libc pthread_exit 5
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
fun:_dl_new_object
|
|
fun:_dl_map_object_from_fd
|
|
fun:_dl_map_object
|
|
}
|
|
|
|
{
|
|
libc pthread_exit 6
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:_dl_map_object
|
|
fun:openaux
|
|
fun:_dl_catch_error
|
|
}
|
|
|
|
{
|
|
libc pthread_exit 7
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:dl_open_worker
|
|
fun:_dl_catch_error
|
|
fun:_dl_open
|
|
}
|
|
|
|
{
|
|
libc pthread_exit 8
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:local_strdup
|
|
fun:_dl_map_object
|
|
fun:dl_open_worker
|
|
}
|
|
|
|
#
|
|
# This is seen internally in the system libraries on 64-bit RHAS3.
|
|
#
|
|
|
|
{
|
|
__lll_mutex_unlock_wake uninitialized
|
|
Memcheck:Param
|
|
futex(utime)
|
|
fun:__lll_mutex_unlock_wake
|
|
}
|
|
|
|
#
|
|
# BUG#19940: NDB sends uninitialized parts of field buffers across the wire.
|
|
# This is "works as designed"; the uninitialized part is not used at the
|
|
# other end (but Valgrind cannot see this).
|
|
#
|
|
{
|
|
bug19940
|
|
Memcheck:Param
|
|
socketcall.sendto(msg)
|
|
fun:send
|
|
fun:_ZN15TCP_Transporter6doSendEv
|
|
fun:_ZN19TransporterRegistry11performSendEv
|
|
fun:_ZN19TransporterRegistry14forceSendCheckEi
|
|
}
|
|
|
|
#
|
|
# Warning when printing stack trace (to suppress some not needed warnings)
|
|
#
|
|
|
|
{
|
|
vprintf on stacktrace
|
|
Memcheck:Cond
|
|
fun:vfprintf
|
|
fun:uffered_vfprintf
|
|
fun:vfprintf
|
|
fun:fprintf
|
|
fun:print_stacktrace
|
|
}
|
|
|
|
#
|
|
# Safe warnings, that may happen because of thread scheduling
|
|
#
|
|
|
|
{
|
|
dbug initialization by kill_server
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:DbugMalloc
|
|
fun:code_state
|
|
fun:_db_enter_
|
|
fun:kill_server
|
|
}
|
|
|
|
#
|
|
# Warning caused by small memory leak in threaded dlopen
|
|
#
|
|
|
|
{
|
|
dlopen threaded memory leak
|
|
Memcheck:Leak
|
|
fun:calloc
|
|
obj:*/libdl-*.so
|
|
fun:dlopen*
|
|
}
|
|
|
|
#
|
|
# In glibc (checked version 2.7), inet_ntoa allocates an 18-byte
|
|
# per-thread static buffer for the return value. That memory is freed
|
|
# at thread exit, however if called from the main thread, Valgrind
|
|
# does not see the free (test main.no-threads).
|
|
#
|
|
# Since inet_ntoa() does not allocate memory dynamically per-call, this
|
|
# suppression is safe.
|
|
#
|
|
|
|
{
|
|
inet_ntoa thread local storage
|
|
Memcheck:Leak
|
|
fun:malloc
|
|
fun:inet_ntoa
|
|
}
|