mirror of
https://github.com/MariaDB/server.git
synced 2025-08-31 22:22:30 +03:00
e662b51eef
BUG#54872 MBR: replication failure caused by using tmp table inside transaction
Changed criteria to classify a statement as unsafe in order to reduce the
number of spurious warnings. So a statement is classified as unsafe when
there is on-going transaction at any point of the execution if:
1. The mixed statement is about to update a transactional table and
a non-transactional table.
2. The mixed statement is about to update a temporary transactional
table and a non-transactional table.
3. The mixed statement is about to update a transactional table and
read from a non-transactional table.
4. The mixed statement is about to update a temporary transactional
table and read from a non-transactional table.
5. The mixed statement is about to update a non-transactional table
and read from a transactional table when the isolation level is
lower than repeatable read.
After updating a transactional table if:
6. The mixed statement is about to update a non-transactional table
and read from a temporary transactional table.
7. The mixed statement is about to update a non-transactional table
and read from a temporary transactional table.
8. The mixed statement is about to update a non-transactionala table
and read from a temporary non-transactional table.
9. The mixed statement is about to update a temporary non-transactional
table and update a non-transactional table.
10. The mixed statement is about to update a temporary non-transactional
table and read from a non-transactional table.
11. A statement is about to update a non-transactional table and the
option variables.binlog_direct_non_trans_update is OFF.
The reason for this is that locks acquired may not protected a concurrent
transaction of interfering in the current execution and by consequence in
the result. So the patch reduced the number of spurious unsafe warnings.
Besides we fixed a regression caused by BUG#51894, which makes temporary
tables to go into the trx-cache if there is an on-going transaction. In
MIXED mode, the patch for BUG#51894 ignores that the trx-cache may have
updates to temporary non-transactional tables that must be written to the
binary log while rolling back the transaction.
So we fix this problem by writing the content of the trx-cache to the
binary log while rolling back a transaction if a non-transactional
temporary table was updated and the binary logging format is MIXED.
179 lines
5.0 KiB
Plaintext
179 lines
5.0 KiB
Plaintext
stop slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
reset master;
|
|
reset slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
start slave;
|
|
call mtr.add_suppression("Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT");
|
|
call mtr.add_suppression("Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT");
|
|
SET @@session.binlog_direct_non_transactional_updates= FALSE;
|
|
DROP DATABASE IF EXISTS db1;
|
|
DROP DATABASE IF EXISTS db2;
|
|
CREATE DATABASE db1;
|
|
CREATE DATABASE db2;
|
|
use db1;
|
|
CREATE TABLE db1.t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE db1.t2 (s CHAR(255)) ENGINE=MyISAM;
|
|
include/stop_slave.inc
|
|
[on master]
|
|
CREATE PROCEDURE db1.p1 ()
|
|
BEGIN
|
|
INSERT INTO t1 VALUES (1);
|
|
INSERT INTO t1 VALUES (2);
|
|
INSERT INTO t1 VALUES (3);
|
|
INSERT INTO t1 VALUES (4);
|
|
INSERT INTO t1 VALUES (5);
|
|
END//
|
|
CREATE PROCEDURE db1.p2 ()
|
|
BEGIN
|
|
INSERT INTO t1 VALUES (6);
|
|
INSERT INTO t1 VALUES (7);
|
|
INSERT INTO t1 VALUES (8);
|
|
INSERT INTO t1 VALUES (9);
|
|
INSERT INTO t1 VALUES (10);
|
|
INSERT INTO t2 VALUES ('executed db1.p2()');
|
|
END//
|
|
INSERT INTO db1.t2 VALUES ('before call db1.p1()');
|
|
use test;
|
|
BEGIN;
|
|
CALL db1.p1();
|
|
COMMIT;
|
|
INSERT INTO db1.t2 VALUES ('after call db1.p1()');
|
|
SELECT * FROM db1.t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
SELECT * FROM db1.t2;
|
|
s
|
|
before call db1.p1()
|
|
after call db1.p1()
|
|
[on slave]
|
|
start slave until master_log_file='master-bin.000001', master_log_pos=MASTER_POS;
|
|
#
|
|
# If we got non-zero here, then we're suffering BUG#43263
|
|
#
|
|
SELECT 0 as 'Must be 0';
|
|
Must be 0
|
|
0
|
|
SELECT * from db1.t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
SELECT * from db1.t2;
|
|
s
|
|
before call db1.p1()
|
|
[on master]
|
|
INSERT INTO db1.t2 VALUES ('before call db1.p2()');
|
|
BEGIN;
|
|
CALL db1.p2();
|
|
ROLLBACK;
|
|
INSERT INTO db1.t2 VALUES ('after call db1.p2()');
|
|
SELECT * FROM db1.t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
SELECT * FROM db1.t2;
|
|
s
|
|
before call db1.p1()
|
|
after call db1.p1()
|
|
before call db1.p2()
|
|
executed db1.p2()
|
|
after call db1.p2()
|
|
[on slave]
|
|
start slave until master_log_file='master-bin.000001', master_log_pos=MASTER_POS;
|
|
#
|
|
# If we got non-zero here, then we're suffering BUG#43263
|
|
#
|
|
SELECT 0 as 'Must be 0';
|
|
Must be 0
|
|
0
|
|
SELECT * from db1.t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
SELECT * from db1.t2;
|
|
s
|
|
before call db1.p1()
|
|
executed db1.p2()
|
|
START SLAVE;
|
|
#
|
|
# SAVEPOINT and ROLLBACK TO have the same problem in BUG#43263
|
|
# This was reported by BUG#50407
|
|
[on master]
|
|
SET SESSION AUTOCOMMIT=0
|
|
BEGIN;
|
|
INSERT INTO db1.t1 VALUES(20);
|
|
#
|
|
# Verify whether this statement is binlogged correctly
|
|
/*comment*/ SAVEPOINT has_comment;
|
|
USE db1;
|
|
INSERT INTO db1.t1 VALUES(30);
|
|
INSERT INTO db1.t2 VALUES("in savepoint has_comment");
|
|
Warnings:
|
|
Note 1592 Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. Statement is unsafe because it accesses a non-transactional table after accessing a transactional table within the same transaction.
|
|
USE db2;
|
|
SavePoint mixed_cases;
|
|
USE db1;
|
|
INSERT INTO db1.t2 VALUES("in savepoint mixed_cases");
|
|
Warnings:
|
|
Note 1592 Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. Statement is unsafe because it accesses a non-transactional table after accessing a transactional table within the same transaction.
|
|
INSERT INTO db1.t1 VALUES(40);
|
|
USE db2;
|
|
ROLLBACK TO mixed_cases;
|
|
Warnings:
|
|
Warning 1196 Some non-transactional changed tables couldn't be rolled back
|
|
ROLLBACK TO has_comment;
|
|
Warnings:
|
|
Warning 1196 Some non-transactional changed tables couldn't be rolled back
|
|
USE db1;
|
|
INSERT INTO db1.t2 VALUES("after rollback to");
|
|
Warnings:
|
|
Note 1592 Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. Statement is unsafe because it accesses a non-transactional table after accessing a transactional table within the same transaction.
|
|
INSERT INTO db1.t1 VALUES(50);
|
|
USE db2;
|
|
COMMIT;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO db1.t1 VALUES(20)
|
|
master-bin.000001 # Query # # SAVEPOINT has_comment
|
|
master-bin.000001 # Query # # use `db1`; INSERT INTO db1.t1 VALUES(30)
|
|
master-bin.000001 # Query # # use `db1`; INSERT INTO db1.t2 VALUES("in savepoint has_comment")
|
|
master-bin.000001 # Query # # SAVEPOINT mixed_cases
|
|
master-bin.000001 # Query # # use `db1`; INSERT INTO db1.t2 VALUES("in savepoint mixed_cases")
|
|
master-bin.000001 # Query # # use `db1`; INSERT INTO db1.t1 VALUES(40)
|
|
master-bin.000001 # Query # # ROLLBACK TO mixed_cases
|
|
master-bin.000001 # Query # # ROLLBACK TO has_comment
|
|
master-bin.000001 # Query # # use `db1`; INSERT INTO db1.t2 VALUES("after rollback to")
|
|
master-bin.000001 # Query # # use `db1`; INSERT INTO db1.t1 VALUES(50)
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
[on slave]
|
|
#
|
|
# Verify INSERT statements in savepoints are executed, for MyISAM table
|
|
# is not effected by ROLLBACK TO
|
|
SELECT * FROM db1.t2 WHERE s LIKE '% savepoint %';
|
|
s
|
|
in savepoint has_comment
|
|
in savepoint mixed_cases
|
|
#
|
|
# Verify INSERT statements on the Innodb table are rolled back;
|
|
SELECT * FROM db1.t1 WHERE a IN (30, 40);
|
|
a
|
|
#
|
|
# Clean up
|
|
#
|
|
DROP DATABASE db1;
|
|
DROP DATABASE db2;
|