mirror of
https://github.com/MariaDB/server.git
synced 2025-11-30 05:23:50 +03:00
2f7d91bb6c
The test innodb.innodb_wl6326 that had been disabled in 10.4 due to
MDEV-21535 is failing on 10.5 due to a different reason: the removal
of the MLOG_COMP_END_COPY_CREATED operations in MDEV-12353
commit 276f996af9 caused PAGE_LAST_INSERT
to be set to something nonzero by the function page_copy_rec_list_end().
This in turn would cause btr_page_get_split_rec_to_right() to behave
differently: we would not attempt to split the page at all, but simply
insert the new record into the new, empty, right leaf page.
Even though the change reduced the sizes of some tables, it is better
to aim for balanced trees.
page_copy_rec_list_end(), PageBulk::finishPage():
Preserve PAGE_LAST_INSERT, PAGE_N_DIRECTION, PAGE_DIRECTION.
PageBulk::finish(): Move some common code from PageBulk::finishPage().
114 lines
2.9 KiB
Plaintext
114 lines
2.9 KiB
Plaintext
--- instant_alter.result
|
|
+++ instant_alter,32k.result
|
|
@@ -2,7 +2,7 @@
|
|
# MDEV-11369: Instant ADD COLUMN for InnoDB
|
|
#
|
|
CREATE TABLE t(a INT UNIQUE)ENGINE=InnoDB ROW_FORMAT=COMPACT;
|
|
-ALTER TABLE t ADD e INT, ROW_FORMAT=COMPRESSED;
|
|
+ALTER TABLE t ADD e INT, ROW_FORMAT=DYNAMIC;
|
|
INSERT INTO t SET a=1;
|
|
SET @old_instant=
|
|
(SELECT variable_value FROM information_schema.global_status
|
|
@@ -33,17 +33,17 @@
|
|
`c` int(11) NOT NULL,
|
|
`d` int(11) NOT NULL,
|
|
UNIQUE KEY `a` (`a`)
|
|
-) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=COMPRESSED
|
|
+) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=DYNAMIC
|
|
SELECT variable_value-@old_instant instants
|
|
FROM information_schema.global_status
|
|
WHERE variable_name = 'innodb_instant_alter_column';
|
|
instants
|
|
-0
|
|
+1
|
|
SELECT variable_value-@old_instant instants
|
|
FROM information_schema.global_status
|
|
WHERE variable_name = 'innodb_instant_alter_column';
|
|
instants
|
|
-0
|
|
+1
|
|
DROP TABLE t;
|
|
connect analyze, localhost, root;
|
|
connection default;
|
|
@@ -374,7 +374,7 @@
|
|
SELECT clust_index_size FROM INFORMATION_SCHEMA.INNODB_SYS_TABLESTATS
|
|
WHERE name = 'test/big';
|
|
clust_index_size
|
|
-3
|
|
+1
|
|
connection default;
|
|
ALTER TABLE big ADD COLUMN
|
|
(d1 INT DEFAULT 0, d2 VARCHAR(20) DEFAULT 'abcde',
|
|
@@ -397,7 +397,7 @@
|
|
SELECT clust_index_size FROM INFORMATION_SCHEMA.INNODB_SYS_TABLESTATS
|
|
WHERE name = 'test/big';
|
|
clust_index_size
|
|
-7
|
|
+5
|
|
connection default;
|
|
ROLLBACK;
|
|
CHECKSUM TABLE big;
|
|
@@ -410,7 +410,7 @@
|
|
SELECT clust_index_size FROM INFORMATION_SCHEMA.INNODB_SYS_TABLESTATS
|
|
WHERE name = 'test/big';
|
|
clust_index_size
|
|
-3
|
|
+1
|
|
connection default;
|
|
InnoDB 0 transactions not purged
|
|
DROP TABLE t1,t2,t3,big;
|
|
@@ -734,7 +734,7 @@
|
|
SELECT clust_index_size FROM INFORMATION_SCHEMA.INNODB_SYS_TABLESTATS
|
|
WHERE name = 'test/big';
|
|
clust_index_size
|
|
-3
|
|
+1
|
|
connection default;
|
|
ALTER TABLE big ADD COLUMN
|
|
(d1 INT DEFAULT 0, d2 VARCHAR(20) DEFAULT 'abcde',
|
|
@@ -757,7 +757,7 @@
|
|
SELECT clust_index_size FROM INFORMATION_SCHEMA.INNODB_SYS_TABLESTATS
|
|
WHERE name = 'test/big';
|
|
clust_index_size
|
|
-7
|
|
+5
|
|
connection default;
|
|
ROLLBACK;
|
|
CHECKSUM TABLE big;
|
|
@@ -770,7 +770,7 @@
|
|
SELECT clust_index_size FROM INFORMATION_SCHEMA.INNODB_SYS_TABLESTATS
|
|
WHERE name = 'test/big';
|
|
clust_index_size
|
|
-3
|
|
+1
|
|
connection default;
|
|
InnoDB 0 transactions not purged
|
|
DROP TABLE t1,t2,t3,big;
|
|
@@ -1094,7 +1094,7 @@
|
|
SELECT clust_index_size FROM INFORMATION_SCHEMA.INNODB_SYS_TABLESTATS
|
|
WHERE name = 'test/big';
|
|
clust_index_size
|
|
-3
|
|
+1
|
|
connection default;
|
|
ALTER TABLE big ADD COLUMN
|
|
(d1 INT DEFAULT 0, d2 VARCHAR(20) DEFAULT 'abcde',
|
|
@@ -1117,7 +1117,7 @@
|
|
SELECT clust_index_size FROM INFORMATION_SCHEMA.INNODB_SYS_TABLESTATS
|
|
WHERE name = 'test/big';
|
|
clust_index_size
|
|
-7
|
|
+5
|
|
connection default;
|
|
ROLLBACK;
|
|
CHECKSUM TABLE big;
|
|
@@ -1130,7 +1130,7 @@
|
|
SELECT clust_index_size FROM INFORMATION_SCHEMA.INNODB_SYS_TABLESTATS
|
|
WHERE name = 'test/big';
|
|
clust_index_size
|
|
-3
|
|
+1
|
|
connection default;
|
|
InnoDB 0 transactions not purged
|
|
DROP TABLE t1,t2,t3,big;
|