mirror of
https://github.com/MariaDB/server.git
synced 2025-11-05 01:43:31 +03:00
Major replication test framework cleanup. This does the following:
- Ensure that all tests clean up the replication state when they
finish, by making check-testcase check the output of SHOW SLAVE STATUS.
This implies:
- Slave must not be running after test finished. This is good
because it removes the risk for sporadic errors in subsequent
tests when a test forgets to sync correctly.
- Slave SQL and IO errors must be cleared when test ends. This is
good because we will notice if a test gets an unexpected error in
the slave threads near the end.
- We no longer have to clean up before a test starts.
- Ensure that all tests that wait for an error in one of the slave
threads waits for a specific error. It is no longer possible to
source wait_for_slave_[sql|io]_to_stop.inc when there is an error
in one of the slave threads. This is good because:
- If a test expects an error but there is a bug that causes
another error to happen, or if it stops the slave thread without
an error, then we will notice.
- When developing tests, wait_for_*_to_[start|stop].inc will fail
immediately if there is an error in the relevant slave thread.
Before this patch, we had to wait for the timeout.
- Remove duplicated and repeated code for setting up unusual replication
topologies. Now, there is a single file that is capable of setting
up arbitrary topologies (include/rpl_init.inc, but
include/master-slave.inc is still available for the most common
topology). Tests can now end with include/rpl_end.inc, which will clean
up correctly no matter what topology is used. The topology can be
changed with include/rpl_change_topology.inc.
- Improved debug information when tests fail. This includes:
- debug info is printed on all servers configured by include/rpl_init.inc
- User can set $rpl_debug=1, which makes auxiliary replication files
print relevant debug info.
- Improved documentation for all auxiliary replication files. Now they
describe purpose, usage, parameters, and side effects.
- Many small code cleanups:
- Made have_innodb.inc output a sensible error message.
- Moved contents of rpl000017-slave.sh into rpl000017.test
- Added mysqltest variables that expose the current state of
disable_warnings/enable_warnings and friends.
- Too many to list here: see per-file comments for details.
71 lines
2.4 KiB
PHP
71 lines
2.4 KiB
PHP
# ==== Purpose ====
|
|
#
|
|
# Waits until the SQL thread of the current connection has got an
|
|
# error, or until a timeout is reached. Also waits until the SQL
|
|
# thread has completely stopped.
|
|
#
|
|
# ==== Usage ====
|
|
#
|
|
# --let $slave_sql_errno= NUMBER
|
|
# [--let $show_slave_sql_error= 1]
|
|
# [--let $rpl_debug= 1]
|
|
# [--let $slave_timeout= NUMBER]
|
|
# --source include/wait_for_slave_sql_error.inc
|
|
#
|
|
# Parameters:
|
|
# $slave_sql_errno
|
|
# The expected SQL error number. This is required.
|
|
# (After BUG#41956 has been fixed, this will be required to be a
|
|
# symbolic name instead of a number.)
|
|
#
|
|
# $show_slave_sql_error
|
|
# If set, will print the error to the query log.
|
|
#
|
|
# $slave_timeout
|
|
# See include/wait_for_slave_param.inc
|
|
#
|
|
# $rpl_debug
|
|
# See include/rpl_init.inc
|
|
|
|
|
|
--let $include_filename= wait_for_slave_sql_error.inc [errno=$slave_sql_errno]
|
|
--source include/begin_include_file.inc
|
|
|
|
|
|
# Note: here, we should not wait for Slave_SQL_Errno!=0.
|
|
# Slave_SQL_Errno and Slave_SQL_Running are not set atomically.
|
|
# Slave_SQL_Errno is set first, then Slave_SQL_Running. So we wait
|
|
# until Slave_SQL_Running=No to be sure that both conditions hold.
|
|
let $slave_param= Slave_SQL_Running;
|
|
let $slave_param_value= No;
|
|
source include/wait_for_slave_param.inc;
|
|
|
|
let $_wfsse_errno= query_get_value(SHOW SLAVE STATUS, Last_SQL_Errno, 1);
|
|
|
|
if (!$slave_sql_errno) {
|
|
--echo !!!ERROR IN TEST: you must set \$slave_sql_errno before you source
|
|
--echo !!!wait_for_slave_sql_error.inc. The error we got this time was '$_wfsse_errno',
|
|
--echo !!!so you probably want to add the following line to your test case:
|
|
--echo !!! --let \$slave_sql_errno= $_wfsse_errno
|
|
--die !!!ERROR IN TEST: you must set \$slave_sql_errno before sourcing wait_for_slave_sql_error.inc
|
|
}
|
|
|
|
if (`SELECT $_wfsse_errno NOT IN ($slave_sql_errno)`) {
|
|
--echo **** Slave stopped with wrong error code: $_wfsse_errno (expected $slave_sql_errno) ****
|
|
source include/show_rpl_debug_info.inc;
|
|
--echo **** Slave stopped with wrong error code: $_wfsse_errno (expected $slave_sql_errno) ****
|
|
--die Slave stopped with wrong error code
|
|
}
|
|
|
|
if ($show_slave_sql_error)
|
|
{
|
|
--let $_wait_for_slave_sql_error_old_status_items= $status_items
|
|
--let $status_items= Last_SQL_Error
|
|
--source include/show_slave_status.inc
|
|
--let $status_items= $_wait_for_slave_sql_error_old_status_items
|
|
}
|
|
|
|
|
|
--let $include_filename= wait_for_slave_sql_error.inc [errno=$slave_sql_errno]
|
|
--source include/end_include_file.inc
|