mirror of
https://github.com/MariaDB/server.git
synced 2025-11-27 05:41:41 +03:00
29e560cdf3
Problem: ======= DROP TABLE IF EXISTS was killed. The table still exists on the master but the DDL was still logged. Analysis: ========= During the execution of DROP TABLE command "ha_delete_table" call is invoked to delete the table. If the query is killed at this point, the kill command is not handled within the code. This results in two issues. 1) The table which is not dropped also gets written into the binary log. 2) The code continues further upon receiving 'KILL QUERY'. Fix: === Upon receiving the KILL command the query should stop its current execution. Tables which were successfully dropped prior to KILL command should be included in the binary log.
33 lines
1004 B
Plaintext
33 lines
1004 B
Plaintext
include/master-slave.inc
|
|
[connection master]
|
|
create table t1 (a int) engine=innodb;
|
|
create table t2 (b longblob) engine=innodb;
|
|
create table t3 (c int) engine=innodb;
|
|
insert into t2 values (repeat('b',1024*1024));
|
|
insert into t2 select * from t2;
|
|
insert into t2 select * from t2;
|
|
insert into t2 select * from t2;
|
|
insert into t2 select * from t2;
|
|
set debug_sync='rm_table_no_locks_before_delete_table SIGNAL nogo WAIT_FOR go EXECUTE 2';
|
|
drop table t1, t2, t3;
|
|
connect foo,localhost,root;
|
|
set debug_sync='now SIGNAL go';
|
|
kill query CONNECTION_ID;
|
|
connection master;
|
|
ERROR 70100: Query execution was interrupted
|
|
"Tables t2 and t3 should be listed"
|
|
SHOW TABLES;
|
|
Tables_in_test
|
|
t2
|
|
t3
|
|
include/show_binlog_events.inc
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE `t1` /* generated by server */
|
|
connection slave;
|
|
drop table t2, t3;
|
|
connection master;
|
|
set debug_sync='RESET';
|
|
drop table t2, t3;
|
|
include/rpl_end.inc
|