database/mariadb
1
0
Fork 0
mirror of https://github.com/MariaDB/server.git synced 2025-08-31 22:22:30 +03:00
Code Activity
Files
bce4c76ae0365f3f80edccc96b26f76f0090b64d
mariadb/sql
History
Ramil Kalimullin bce4c76ae0 Fix for bug#35383: binlog playback and replication breaks 
due to name_const substitution

Problem:
"In general, statements executed within a stored procedure
are written to the binary log using the same rules that
would apply were the statements to be executed in standalone
fashion. Some special care is taken when logging procedure
statements because statement execution within procedures
is not quite the same as in non-procedure context".

For example, each reference to a local variable in SP's
statements is replaced by NAME_CONST(var_name, var_value).
Queries like
"CREATE TABLE ... SELECT FUNC(local_var ..."
are logged as
"CREATE TABLE ... SELECT FUNC(NAME_CONST("local_var", var_value) ..."
that leads to differrent field names and
might result in "Incorrect column name" if var_value is long enough.

Fix: in 5.x we'll issue a warning in such a case.
In 6.0 we should get rid of NAME_CONST().

Note: this issue and change should be described in the documentation
("Binary Logging of Stored Programs").


mysql-test/r/binlog.result:
  Fix for bug#35383: binlog playback and replication breaks
  due to name_const substitution
    - test result.
mysql-test/t/binlog.test:
  Fix for bug#35383: binlog playback and replication breaks
  due to name_const substitution
    - test case.
sql/sp_head.cc:
  Fix for bug#35383: binlog playback and replication breaks 
  due to name_const substitution
    - set thd->query_name_consts if there's NAME_CONST()
  substitution(s).
sql/sql_parse.cc:
  Fix for bug#35383: binlog playback and replication breaks 
  due to name_const substitution
    - issue a warning if there's NAME_CONST() substitution and
  binary logging is on for "CREATE TABLE ... SELECT ...".
2009-03-25 20:48:10 +04:00
..
examples
Bug#39616: Missing quotes from .CSV crashes server
2008-11-18 11:31:03 +05:30
share
Bug#28323: Server crashed in xid cache operations
2008-10-21 15:45:43 -02:00
.cvsignore
…
add_errmsg
…
client_settings.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
CMakeLists.txt
Bug#40280: Message compiler(mc.exe) needed to compile MySQL on windows.
2008-10-23 15:28:53 +02:00
custom_conf.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
derror.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
des_key_file.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
discover.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
field_conv.cc
field_conv.cc:
2007-07-12 00:55:40 +05:00
field.cc
Added a missing bit from the original patch for bug #27483 which was lost when re-applying
2008-12-09 13:19:46 +03:00
field.h
Bug#38469 invalid memory read and/or crash with utf8 text field, stored procedure, uservar
2008-09-20 10:51:03 +02:00
filesort.cc
BUG#35478: sort_union() returns bad data when sort_buffer_size is hit
2008-07-15 18:13:21 +04:00
frm_crypt.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
gen_lex_hash.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
gstream.cc
Merge mysql.com:/home/hf/work/30286/my41-30286
2007-10-05 16:33:08 +05:00
gstream.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
ha_archive.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
ha_archive.h
Merge bk-internal.mysql.com:/home/bk/mysql-5.0
2007-01-22 14:04:40 +02:00
ha_berkeley.cc
fixes for warnings and compile errors for the fix of bug 26243
2008-03-29 16:12:23 +02:00
ha_berkeley.h
Fixed compiler warnings (for linux and win32 and win64)
2007-02-22 16:59:57 +02:00
ha_blackhole.cc
Bug #35178 INSERT_ID not written to binary log for inserts against BLACKHOLE backed tables
2008-03-19 18:44:50 +02:00
ha_blackhole.h
Bug#30294 blackhole engine causes 100% with 2 alter table statements running
2007-11-16 14:46:36 +04:00
ha_federated.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
ha_federated.h
Bug #32374 crash with filesort when selecting from federated table and view.
2007-11-30 17:08:00 +04:00
ha_heap.cc
type conversions fixed to get rid of warnings
2007-10-23 16:32:05 +05:00
ha_heap.h
[pb problem]: ha_heap->clone() fails on windows because of mess with
2007-07-17 19:51:50 +04:00
ha_innodb.cc
auto-merge
2009-03-19 09:44:58 -04:00
ha_innodb.h
Bug #20358: InnoDB hang on the adaptive hash index latch in btr0sea.c
2007-10-02 23:47:30 -06:00
ha_myisam.cc
Bug#33756 - query cache with concurrent_insert=0 appears broken
2008-03-13 16:39:27 +01:00
ha_myisam.h
Bug#28249 Query Cache returns wrong result with concurrent insert / certain lock
2007-07-12 13:29:51 +02:00
ha_myisammrg.cc
Merge amd64.(none):/src/mysql-5.0-bugteam
2008-03-28 16:01:05 -04:00
ha_myisammrg.h
BUG#26976 - Missing table in merge not noted in related error msg +
2007-06-06 04:42:41 +05:00
ha_ndbcluster_cond.cc
fixed warnings and compile errors from the fix for bug 26243
2008-03-29 09:52:16 +02:00
ha_ndbcluster_cond.h
Bug#34749: Server crash when using NAME_CONST() with an aggregate function
2008-02-28 14:23:22 +01:00
ha_ndbcluster.cc
fixed warnings and compile errors from the fix for bug 26243
2008-03-29 09:52:16 +02:00
ha_ndbcluster.h
ha_ndbcluster.h:
2007-11-05 20:18:22 +01:00
handler.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
handler.h
Fix for bug#40984: backport fix from 39585 into 5.0
2008-11-25 10:22:02 +04:00
hash_filo.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
hash_filo.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
hostname.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
init.cc
Bug#26294: library name conflict between MySQL 4.x, 5.0 and Qt 3.3
2008-04-03 11:32:00 -04:00
item_buff.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
item_cmpfunc.cc
Bug#37601 Cast Is Not Done On Row Comparison
2009-02-19 17:20:44 +04:00
item_cmpfunc.h
rollback of bug #40761 fix
2008-12-12 14:59:10 +04:00
item_create.cc
Fix mismerge.
2008-04-10 15:55:37 -04:00
item_create.h
Bug #27921 View ignores precision for CAST()
2007-05-10 00:17:21 +05:00
item_func.cc
auto-merge
2009-03-19 09:44:58 -04:00
item_func.h
auto merge
2009-01-16 16:48:41 +02:00
item_geofunc.cc
Merge mysql.com:/home/hf/work/31158/my41-31158
2007-11-17 16:48:57 +04:00
item_geofunc.h
Bug #31155 gis types in union'd select cause crash.
2007-10-04 12:01:28 +05:00
item_row.cc
Many files:
2006-12-23 20:17:15 +01:00
item_row.h
Merge bk-internal.mysql.com:/home/bk/mysql-5.0
2007-01-22 14:04:40 +02:00
item_strfunc.cc
auto-merge
2009-03-19 09:44:58 -04:00
item_strfunc.h
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
item_subselect.cc
Merge epotemkin@bk-internal.mysql.com:/home/bk/mysql-5.0-bugteam
2008-03-28 14:31:52 +03:00
item_subselect.h
Bug #31884: Assertion + crash in subquery in the SELECT clause.
2007-10-30 14:27:21 +02:00
item_sum.cc
Bug #43354: Use key hint can crash server in explain extended query
2009-03-11 14:10:44 +02:00
item_sum.h
backported the fix for bug #34773 to 5.0
2008-12-09 20:35:02 +02:00
item_timefunc.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
item_timefunc.h
Bug#42525: TIMEDIFF function
2009-02-06 18:25:08 +01:00
item_uniq.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
item_uniq.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
item.cc
auto-merge
2009-03-19 09:58:56 -04:00
item.h
Bug#37601 Cast Is Not Done On Row Comparison
2009-02-19 17:20:44 +04:00
key.cc
Fixed bug #32556: assert in "using index for group-by" :
2007-11-21 22:56:42 +04:00
lex_symbol.h
Fix -ansi -pedantic warning (can't cast a pointer to function
2007-03-08 12:04:45 +03:00
lex.h
Fix -ansi -pedantic warning (can't cast a pointer to function
2007-03-08 12:04:45 +03:00
lock.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
log_event.cc
auto-merge
2009-03-19 09:44:58 -04:00
log_event.h
BUG#37051 Replication rules not evaluated correctly
2009-03-05 18:10:44 +08:00
log.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
Makefile.am
Bug#40280: Message compiler(mc.exe) needed to compile MySQL on windows.
2008-10-23 15:28:53 +02:00
matherr.c
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
message.h
Bug#40280: Message compiler(mc.exe) needed to compile MySQL on windows.
2008-10-23 15:28:53 +02:00
message.mc
Bug#40280: Message compiler(mc.exe) needed to compile MySQL on windows.
2008-10-23 15:28:53 +02:00
message.rc
Bug#40280: Message compiler(mc.exe) needed to compile MySQL on windows.
2008-10-23 15:28:53 +02:00
mf_iocache.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
MSG00001.bin
Bug#40280: Message compiler(mc.exe) needed to compile MySQL on windows.
2008-10-23 15:28:53 +02:00
my_decimal.cc
Bug#37553: MySql Error Compare TimeDiff & Time
2008-11-26 09:28:17 +01:00
my_decimal.h
Bug#36023: Incorrect handling of zero length caused an assertion to fail.
2008-04-25 00:39:37 +04:00
my_lock.c
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
mysql_priv.h
Bug#36326: nested transaction and select
2009-01-13 20:07:06 -02:00
mysqld_suffix.h
Many files:
2006-12-23 20:17:15 +01:00
mysqld.cc
auto-merge
2009-03-19 09:44:58 -04:00
net_serv.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
nt_servc.cc
Bug #20430 mysqld.exe windows service stuck in "SERVICE_STOP_PENDING"
2008-11-14 02:01:41 +01:00
nt_servc.h
Bug #20430 mysqld.exe windows service stuck in "SERVICE_STOP_PENDING"
2008-11-14 02:01:41 +01:00
opt_range.cc
auto-merge
2009-03-19 09:44:58 -04:00
opt_range.h
BUG#36639: subselect.test crashes on 64 bit pentium4 when compiled for valgrind, commit into 5.0
2008-08-25 21:02:54 +04:00
opt_sum.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
parse_file.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
parse_file.h
Bug #40021: Renaming view fails, archived .frm for view is
2008-11-14 21:25:57 +04:00
password.c
Merge bk-internal.mysql.com:/home/bk/mysql-5.0
2007-01-22 14:04:40 +02:00
procedure.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
procedure.h
Bug #26461: Intrinsic data type bool (1 byte) redefined to BOOL (4 bytes)
2008-03-21 17:23:17 +02:00
protocol.cc
auto-merge
2009-03-19 09:44:58 -04:00
protocol.h
Backport of TIME->MYSQL_TIME / Y2K fixset
2007-05-16 10:44:59 +02:00
records.cc
BUG#35478: sort_union() returns bad data when sort_buffer_size is hit
2008-07-15 18:13:21 +04:00
repl_failsafe.cc
Make gcov happy.
2008-03-18 16:38:12 +04:00
repl_failsafe.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
set_var.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
set_var.h
Bug #37339: SHOW VARIABLES not working properly with multi-byte datadir
2008-11-28 16:25:16 +02:00
slave.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
slave.h
BUG#13861 - START SLAVE UNTIL may stop 1 evnt too late if
2008-02-22 19:07:07 +04:00
sp_cache.cc
Many files:
2006-12-23 20:17:15 +01:00
sp_cache.h
Many files:
2006-12-23 20:17:15 +01:00
sp_head.cc
Fix for bug#35383: binlog playback and replication breaks
2009-03-25 20:48:10 +04:00
sp_head.h
Bug#26030 (Parsing fails for stored routine w/multi-statement execution
2008-07-07 10:00:08 -06:00
sp_pcontext.cc
Bug#26503 (Illegal SQL exception handler code causes the server to crash)
2007-03-14 12:02:32 -06:00
sp_pcontext.h
Bug#26503 (Illegal SQL exception handler code causes the server to crash)
2007-03-14 12:02:32 -06:00
sp_rcontext.cc
Bug#33618 (Crash in sp_rcontext)
2008-01-23 13:26:41 -07:00
sp_rcontext.h
Bug#33618 (Crash in sp_rcontext)
2008-01-23 13:26:41 -07:00
sp.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sp.h
Many files:
2006-12-23 20:17:15 +01:00
spatial.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
spatial.h
Bug #24563: MBROverlaps does not seem to function propertly.
2007-03-23 16:28:07 -06:00
sql_acl.cc
auto-merge
2009-03-19 09:44:58 -04:00
sql_acl.h
Bug #26461: Intrinsic data type bool (1 byte) redefined to BOOL (4 bytes)
2008-03-21 17:23:17 +02:00
sql_analyse.cc
fixed warnings from the fix of 26243
2008-03-29 17:50:46 +02:00
sql_analyse.h
Bug #26461: Intrinsic data type bool (1 byte) redefined to BOOL (4 bytes)
2008-03-21 17:23:17 +02:00
sql_array.h
Fix for bug #31207: Test "join_nested" shows different strategy on IA64
2007-10-17 20:08:58 +04:00
sql_base.cc
auto-merge
2009-03-19 09:44:58 -04:00
sql_bitmap.h
Many files:
2006-12-23 20:17:15 +01:00
sql_cache.cc
auto-merge
2009-03-19 09:44:58 -04:00
sql_cache.h
Bug#30087 Set query_cache_size, if the value is too small, get a unclear warning
2008-07-16 16:29:22 -06:00
sql_class.cc
Fix for bug#35383: binlog playback and replication breaks
2009-03-25 20:48:10 +04:00
sql_class.h
Fix for bug#35383: binlog playback and replication breaks
2009-03-25 20:48:10 +04:00
sql_client.cc
Bug#26664 test suite times out on OS X 64bit
2007-05-24 11:21:27 +02:00
sql_crypt.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_crypt.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_cursor.cc
Bug#37956 memory leak and / or crash with geometry and prepared statements!
2008-12-10 18:13:11 +04:00
sql_cursor.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_db.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_delete.cc
BUG#35478: sort_union() returns bad data when sort_buffer_size is hit
2008-07-15 18:13:21 +04:00
sql_derived.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_do.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_error.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_error.h
BUG#26976 - Missing table in merge not noted in related error msg +
2007-06-06 04:42:41 +05:00
sql_handler.cc
auto-merge
2009-03-19 09:44:58 -04:00
sql_help.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_insert.cc
Merge
2009-03-24 15:29:04 +08:00
sql_lex.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_lex.h
Bug #38691: segfault/abort in ``UPDATE ...JOIN'' while
2008-10-08 02:34:00 +05:00
sql_list.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_list.h
Bug#38296 (low memory crash with many conditions in a query)
2008-08-11 10:10:00 -06:00
sql_load.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_locale.cc
Bug#37575 UCASE fails on monthname
2008-12-23 18:08:04 +04:00
sql_manager.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_manager.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_map.cc
type conversions fixed to avoid warnings on Windows
2007-10-23 14:27:11 +05:00
sql_map.h
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_olap.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_parse.cc
Fix for bug#35383: binlog playback and replication breaks
2009-03-25 20:48:10 +04:00
sql_prepare.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_rename.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_repl.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_repl.h
BUG#31024: STOP SLAVE does not stop attempted connect()s
2008-03-11 14:42:54 +01:00
sql_select.cc
auto-merge
2009-03-19 09:44:58 -04:00
sql_select.h
Bug #42037: Queries containing a subquery with DISTINCT and
2009-02-05 13:30:39 +04:00
sql_show.cc
auto-merge
2009-03-19 09:44:58 -04:00
sql_sort.h
Fixed bug #25798.
2007-07-01 15:33:28 -07:00
sql_state.c
Many files:
2006-12-23 20:17:15 +01:00
sql_string.cc
auto-merge
2009-03-19 09:44:58 -04:00
sql_string.h
Bug#38296 (low memory crash with many conditions in a query)
2008-08-11 10:10:00 -06:00
sql_table.cc
auto-merge
2009-03-19 09:44:58 -04:00
sql_test.cc
my_strtoll10-x86.s:
2006-12-31 01:02:27 +01:00
sql_trigger.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_trigger.h
A fix and a test case for Bug#26141 mixing table types in trigger
2007-07-12 22:26:41 +04:00
sql_udf.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_udf.h
Remove typedef st_table_list TABLE_LIST and always use name 'TABLE_LIST'.
2007-07-06 16:18:49 +04:00
sql_union.cc
Bug#38499: flush tables and multitable table update with
2008-10-09 20:24:31 +05:00
sql_update.cc
BUG#37051 Replication rules not evaluated correctly
2009-03-05 18:10:44 +08:00
sql_view.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
sql_view.h
Bug#32890 Crash after repeated create and drop of tables and views
2008-02-21 14:58:29 -03:00
sql_yacc.yy
Bug #33813: Schema names are case-sensitive in DROP FUNCTION
2009-02-12 16:36:43 +02:00
stacktrace.c
Bug#35987 - post-review fix
2008-09-16 13:16:41 +02:00
stacktrace.h
Bug#31745 - crash handler does not work on Windows
2008-02-19 12:37:39 +01:00
strfunc.cc
Fixed compiler warnings.
2007-03-22 20:32:07 +02:00
structs.h
Bug#41131 "Questions" fails to increment - ignores statements instead stored procs(5.0 ver)
2008-12-29 16:06:53 +04:00
table.cc
auto-merge
2009-03-19 09:44:58 -04:00
table.h
Bug #40021: Renaming view fails, archived .frm for view is
2008-11-14 21:25:57 +04:00
thr_malloc.cc
Bug#38296 (low memory crash with many conditions in a query)
2008-08-11 10:10:00 -06:00
time.cc
Bug #29536: timestamp inconsistent in replication around 1970
2007-08-06 04:57:28 -07:00
tzfile.h
Many files:
2006-12-23 20:17:15 +01:00
tztime.cc
Bug #42502 huge memory leak possible with timezone
2009-03-19 11:27:45 +01:00
tztime.h
Bug #39920: MySQL cannot deal with Leap Second expression in string literal.
2008-12-01 16:18:35 +02:00
udf_example.c
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
udf_example.def
Bug #29804 UDF parameters don't contain correct string length
2007-10-17 17:54:11 -04:00
uniques.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
unireg.cc
Bug#29125 Windows Server X64: so many compiler warnings
2009-02-10 17:47:54 -05:00
unireg.h
Bug#37428 Potential security issue with UDFs - linux shellcode execution.
2008-08-25 17:11:59 +05:00
watchdog_mysqld
…