Vlad Lesin b54e7b0cea
MDEV-31185 rw_trx_hash_t::find() unpins pins too early ...
rw_trx_hash_t::find() acquires element->mutex, then unpins pins, used for
lf_hash element search. After that the "element" can be deallocated and
reused by some other thread.
If we take a look rw_trx_hash_t::insert()->lf_hash_insert()->lf_alloc_new()
calls, we will not find any element->mutex acquisition, as it was not
initialized yet before it's allocation. rw_trx_hash_t::insert() can reuse
the chunk, unpinned in rw_trx_hash_t::find().
The scenario is the following:
1. Thread 1 have just executed lf_hash_search() in
rw_trx_hash_t::find(), but have not acquired element->mutex yet.
2. Thread 2 have removed the element from hash table with
rw_trx_hash_t::erase() call.
3. Thread 1 acquired element->mutex and unpinned pin 2 pin with
lf_hash_search_unpin(pins) call.
4. Some thread purged memory of the element.
5. Thread 3 reused the memory for the element, filled element->id,
element->trx.
6. Thread 1 crashes with failed "DBUG_ASSERT(trx_id == trx->id)"
assertion.
Note that trx_t objects are also reused, see the code around trx_pools
for details.
The fix is to invoke "lf_hash_search_unpin(pins);" after element->trx is
stored in local variable in rw_trx_hash_t::find().
Reviewed by: Nikita Malyavin, Marko Mäkelä.
2023-05-19 15:50:20 +03:00
2022-01-29 15:41:05 +01:00
2019-02-05 01:34:17 +01:00
2020-05-05 20:33:10 +03:00
2018-05-07 14:58:11 +05:30
2018-05-07 14:58:11 +05:30
2020-05-04 09:35:38 +05:30
2021-11-12 17:46:35 +05:30
2022-10-05 20:37:54 +03:00
2018-10-11 15:10:13 +03:00
2023-03-22 11:55:57 +11:00
2018-05-16 15:03:09 +05:30
2018-10-25 13:04:41 +03:00
2019-01-08 20:41:39 +05:30
2018-05-16 15:03:09 +05:30
2019-04-05 11:41:03 +03:00
2019-07-10 12:43:51 +05:30
2021-02-16 12:07:48 +02:00
2021-01-19 16:18:37 +05:30
2022-09-23 17:37:52 +03:00
2022-10-05 15:18:58 +03:00
2018-06-25 14:52:38 +05:30
2021-11-12 17:46:35 +05:30
2018-07-02 12:45:02 +05:30
2018-11-07 20:21:12 +02:00
2018-05-07 15:39:29 +03:00
2018-05-07 12:05:20 +03:00
2021-09-11 11:14:18 +03:00
2022-04-21 15:23:21 +03:00
2021-11-12 17:46:35 +05:30
2018-03-29 22:02:05 +03:00
2019-04-03 18:36:33 +02:00
2018-06-25 14:52:38 +05:30
2018-06-25 14:52:38 +05:30
2022-10-22 14:22:20 +04:00
2021-07-23 16:33:14 +03:00
2021-02-23 09:25:57 +01:00
2020-05-15 15:10:58 +03:00
2019-08-12 18:50:54 +03:00
2022-09-23 17:37:52 +03:00
2022-10-05 20:37:54 +03:00
2022-02-11 12:26:27 +03:00
2022-09-23 17:37:52 +03:00
2020-01-15 18:06:24 +01:00
2020-03-19 13:01:20 +02:00
2020-03-19 13:01:20 +02:00
2022-07-04 08:04:44 +03:00
2021-09-10 19:15:41 +03:00
2019-05-29 08:14:49 +03:00
2020-03-30 14:50:23 +03:00
2022-11-29 11:06:29 +02:00
2019-07-22 14:55:46 +03:00
2022-12-20 11:31:49 +03:00
2018-12-21 12:12:57 +02:00
2021-11-12 17:46:35 +05:30
2022-11-09 21:00:24 +03:00
2023-04-19 17:11:14 +05:30
2021-10-26 22:50:58 +06:00
2021-10-20 22:16:23 +03:00
2018-05-02 15:44:52 +03:00
2019-05-06 11:32:17 +00:00
2019-05-29 22:17:00 +03:00
2019-04-07 10:57:38 +03:00
2018-03-13 08:15:06 +02:00
2020-05-09 20:36:58 +02:00
2022-08-30 12:02:56 +03:00
2022-07-27 11:02:57 +02:00
2020-09-03 15:53:38 +03:00
2019-02-19 18:50:19 +02:00
2023-02-16 16:04:46 +05:30
2022-04-27 13:38:08 +03:00
2019-11-06 13:44:56 +02:00
2022-10-05 20:30:57 +03:00
2021-08-17 16:09:55 +03:00
2021-07-27 20:30:33 +03:00
2021-08-18 16:47:03 +03:00
2023-04-03 14:36:11 +02:00
2019-10-28 08:17:56 +01:00
2022-12-15 11:14:23 +02:00
2019-01-23 12:39:03 +01:00
2023-03-29 16:49:10 +03:00
2021-04-07 16:42:09 +05:30
2020-03-19 07:48:17 +02:00
2020-03-19 13:01:20 +02:00
2020-03-19 07:48:17 +02:00
2020-03-20 22:06:55 +02:00
2022-01-19 11:10:45 +11:00
2022-01-19 11:10:45 +11:00
2022-10-05 20:37:54 +03:00
2018-05-19 15:38:34 +02:00
2020-01-15 18:06:24 +01:00
2020-08-21 14:48:53 +03:00
2019-08-23 08:06:17 +03:00
2019-08-21 15:23:45 +03:00
2020-01-15 18:06:24 +01:00
2018-05-17 09:37:01 +03:00
2020-01-17 14:27:28 +02:00
2020-01-24 14:16:20 +01:00
2019-04-02 11:03:28 +03:00
2019-09-01 19:17:35 +03:00
2020-01-15 18:06:24 +01:00
2022-11-22 14:03:23 +04:00
2023-04-04 12:30:50 +04:00
2018-10-18 11:27:19 +03:00
2020-03-17 16:28:16 +02:00
2021-09-29 12:13:11 +03:00
2018-06-06 11:25:33 +03:00
2020-07-30 09:24:36 +03:00
2022-02-25 10:43:38 +02:00
2022-01-14 15:53:29 +02:00
2019-11-20 19:48:03 +07:00
2019-11-20 19:48:03 +07:00
2020-12-19 11:44:42 +01:00
2019-08-19 11:54:26 +03:00
2018-04-12 12:41:19 +03:00
2018-06-18 14:26:37 +05:30
2020-10-01 16:10:14 +10:00
2019-04-25 16:05:20 +03:00
2019-10-24 21:20:53 +03:00
2020-12-11 17:33:44 +03:00
2022-08-28 21:35:21 +03:00
2023-03-29 16:49:10 +03:00
2020-01-17 14:27:28 +02:00
2020-01-17 14:27:28 +02:00
2020-01-20 08:41:52 +02:00
2022-02-17 10:53:58 +02:00
2019-11-20 19:48:03 +07:00
2019-07-05 17:02:21 +03:00
2019-11-20 19:48:03 +07:00
2022-10-10 09:12:55 +03:00
2019-01-03 13:09:41 +01:00
2019-10-30 16:47:43 +01:00
2019-05-29 08:28:15 +03:00
2023-03-22 11:55:57 +11:00
2021-08-23 09:13:55 +03:00
2021-07-02 11:48:51 +03:00
2022-04-27 08:08:06 +03:00
2022-04-27 08:08:06 +03:00
2020-02-07 16:01:31 +05:30
2019-09-26 13:03:40 +03:00
2023-03-22 11:55:57 +11:00
2020-08-21 19:18:34 +03:00
2019-02-05 01:34:17 +01:00
2019-02-05 01:34:17 +01:00
2019-09-01 19:17:35 +03:00
2022-10-05 15:18:58 +03:00
2021-11-12 17:46:35 +05:30
2022-09-07 08:08:59 +03:00
2019-05-19 20:55:37 +02:00
2018-04-26 20:56:14 +03:00
2018-09-14 08:47:22 +02:00
2022-12-15 11:14:23 +02:00
2019-12-02 14:35:10 +02:00
2018-02-06 14:50:50 +01:00
2018-05-17 08:42:53 +03:00
2018-09-17 14:37:39 +03:00
2018-06-14 14:23:01 +03:00
2021-07-27 10:47:17 +03:00
2018-09-17 14:37:39 +03:00
2018-09-17 14:37:39 +03:00
2018-06-14 14:23:01 +03:00
2019-02-19 17:41:13 +02:00
2019-05-29 11:32:46 +03:00
2019-05-29 11:32:46 +03:00
2019-08-29 08:23:19 +03:00
2020-01-15 18:06:24 +01:00
2019-02-19 16:12:00 +02:00
2022-10-05 20:37:54 +03:00
2022-10-05 20:37:54 +03:00
2019-09-01 19:17:35 +03:00
2022-09-14 13:37:14 +05:30
2022-11-15 12:16:40 +05:30
2022-10-05 20:37:54 +03:00
2019-05-04 17:04:55 +02:00
2021-01-05 19:19:27 +10:00
2019-09-10 16:14:50 +03:00
2019-07-22 17:33:08 +03:00
2022-12-13 11:37:33 +02:00
2023-03-22 11:55:57 +11:00
2023-04-03 14:36:11 +02:00
2022-01-21 14:43:59 +02:00
2022-01-21 14:43:59 +02:00
2021-03-08 09:39:54 +02:00
2022-12-20 11:31:49 +03:00
2022-09-13 16:36:38 +03:00
2022-07-04 08:04:44 +03:00
2023-03-14 13:34:23 +05:30
2021-03-12 16:56:47 +05:30
2022-03-01 13:01:48 +05:30
2019-02-13 17:39:05 +02:00
2020-07-20 14:15:56 +03:00
2022-06-30 17:30:13 +05:30
2020-10-26 17:39:52 +03:00
2020-05-26 20:27:13 +05:30
2018-12-13 22:23:49 +02:00
2020-10-29 13:38:38 +02:00
2018-10-19 18:57:23 +03:00
2022-06-27 16:00:34 +03:00
2021-04-28 03:56:24 +05:30
2019-03-20 19:18:21 +01:00
2019-01-09 19:50:48 +02:00
2019-05-29 22:17:00 +03:00
2019-05-29 08:14:49 +03:00
2020-06-05 18:05:22 +03:00
2022-09-08 13:36:30 +03:00
2018-05-29 08:54:33 +03:00
2019-09-01 19:17:35 +03:00
2022-09-23 13:40:42 +03:00
2022-10-05 20:37:54 +03:00
2019-04-01 19:47:24 +03:00
2022-09-23 13:40:42 +03:00
2022-10-05 20:37:54 +03:00
2019-05-29 08:28:15 +03:00
2022-10-05 20:37:54 +03:00
2019-07-05 17:02:21 +03:00
2021-10-11 12:26:43 +03:00
2021-10-11 12:26:43 +03:00
2018-04-08 21:32:02 +00:00
2019-05-29 08:28:15 +03:00
2022-10-05 20:30:57 +03:00
2022-12-20 11:31:49 +03:00
2021-04-24 09:26:49 +03:00
2020-07-31 11:54:35 +03:00
2022-01-26 12:42:17 +02:00
2019-08-14 10:32:52 +03:00
2022-03-03 11:51:25 +02:00
2018-03-13 15:25:38 +05:30
2022-10-05 09:30:33 +03:00
2023-03-22 11:55:57 +11:00
2019-06-24 17:07:20 +03:00
2022-10-05 20:37:54 +03:00
2022-10-05 20:37:54 +03:00
2023-03-22 11:55:57 +11:00
2018-09-07 22:10:03 +03:00
2018-06-13 08:33:25 +03:00
2022-01-19 11:10:45 +11:00
2023-04-03 14:36:11 +02:00
2022-08-22 12:33:46 +03:00
2020-09-21 12:29:00 +03:00
2022-04-20 19:55:17 +05:30
2022-01-21 14:43:59 +02:00
2022-01-21 14:43:59 +02:00
2023-04-06 16:17:50 +04:00
2019-10-30 23:14:44 +01:00
2022-06-17 08:40:51 +03:00
2018-05-11 18:35:03 +03:00
2019-07-16 18:39:21 +03:00
2018-08-14 12:18:38 +03:00
2019-05-29 08:28:15 +03:00
2019-02-19 18:50:19 +02:00
2019-02-19 18:50:19 +02:00
2022-10-05 20:30:57 +03:00
2018-03-29 13:59:44 +03:00
2018-03-29 13:59:44 +03:00
2019-09-09 13:06:33 +03:00
2023-03-22 11:55:57 +11:00
2018-05-17 09:37:01 +03:00
2018-09-10 14:59:58 +03:00
2021-03-02 15:23:56 +02:00
2019-06-27 15:39:04 +03:00
2020-09-22 11:13:51 +03:00
2019-08-14 11:58:22 +03:00
2019-09-06 11:53:10 +02:00
2023-05-19 15:50:20 +03:00
2019-11-20 19:48:03 +07:00
2019-02-19 18:50:19 +02:00
2019-08-16 09:56:43 +03:00
2019-08-16 10:51:20 +03:00
2022-10-05 20:37:54 +03:00
2021-10-19 08:46:16 +03:00
2022-08-01 15:15:06 +03:00
2020-10-06 22:35:43 +03:00
2018-02-07 10:39:12 +02:00
2019-04-26 15:31:31 +03:00
2020-05-15 22:54:05 +03:00
2022-10-05 15:18:58 +03:00
b54e7b0cea