unknown ad104d5bfd
Bug#28318 CREATE FUNCTION (UDF) requires a schema ...
Bug#29816 Syntactically wrong query fails with misleading error message
The core problem is that an SQL-invoked function name can be a <schema
qualified routine name> that contains no <schema name>, but the mysql
parser insists that all stored procedures (function, procedures and
triggers) must have a <schema name>, which is not true for functions.
This problem is especially visible when trying to create a function
or when a query contains a syntax error after a function call (in the
same query), both will fail with a "No database selected" message if
the session is not attached to a particular schema, but the first
one should succeed and the second fail with a "syntax error" message.
Part of the fix is to revamp the sp name handling so that a schema
name may be omitted for functions -- this means that the internal
function name representation may not have a dot, which represents
that the function doesn't have a schema name. The other part is
to place schema checks after the type (function, trigger or procedure)
of the routine is known.
mysql-test/r/sp-error.result:
Add test case result for Bug#29816
mysql-test/r/udf.result:
Add test case result for Bug#28318
mysql-test/t/sp-error.test:
Add test case for Bug#29816
mysql-test/t/udf.test:
Add test case for Bug#28318
sql/sp.cc:
Copy the (last) nul byte of the stored routine key and move name parsing
code to the sp_name class constructor.
sql/sp_head.cc:
Revamp routine name parsing for when no schema is specified and
omit dot from the qualified name if the routine is not associated
with a scheme name.
sql/sp_head.h:
Name parsing got bigger, uninline by moving to a single unit -- the sp_head.cc
file.
sql/sql_yacc.yy:
Only copy the schema name if one is actually set and check for schema
name presence only where it's necessary.
2007-10-09 20:46:33 -03:00
2007-01-19 23:15:59 +03:00
2007-07-27 14:30:25 +05:00
2007-06-24 19:44:54 +05:00
2007-06-27 13:19:34 +05:00
2007-08-29 12:44:43 +02:00
2007-05-17 19:38:34 +03:00
2007-07-30 21:05:56 +05:00
2007-06-25 22:44:22 -07:00
2007-06-19 09:56:19 +02:00
2007-06-07 20:25:22 +02:00
2007-07-09 08:11:38 +02:00
2007-06-07 19:21:01 +02:00
2007-08-07 11:40:03 +02:00
2007-07-20 00:06:35 +04:00
2007-07-19 13:51:31 +05:00
2007-04-09 17:53:10 +05:00
2007-08-29 14:50:32 -06:00
2007-07-13 13:56:22 +03:00
2007-07-26 03:33:43 +05:00
2007-06-15 11:19:35 +05:00
2007-08-07 05:35:20 -04:00
2007-07-04 14:21:29 +05:00
2007-07-09 01:23:33 +04:00
2007-06-07 19:18:01 +02:00
2007-07-04 16:17:40 +05:00
2007-07-04 12:04:57 +05:00
2007-06-07 17:55:55 +05:00
2007-06-07 17:55:55 +05:00
2007-08-07 19:25:45 +05:00
2007-06-28 13:34:44 +05:00
2007-02-19 13:57:06 +03:00
2007-06-22 17:28:26 +05:00
2007-06-07 19:18:01 +02:00
2007-08-03 15:30:31 +05:00
2007-08-03 15:30:31 +05:00
2007-05-16 10:44:59 +02:00
2007-02-12 15:41:36 +04:00
2007-03-20 17:53:55 +04:00
2007-02-23 18:49:41 +02:00
2007-02-26 11:49:24 +01:00
2007-05-31 10:20:58 +02:00
2007-04-10 16:55:48 +03:00
2007-06-14 23:23:30 +02:00
2007-06-07 00:59:08 -07:00
2007-06-07 00:59:08 -07:00
2007-06-18 16:35:01 +03:00
2007-03-08 00:27:42 +03:00
2007-07-23 23:35:43 -07:00
2007-06-28 16:03:01 -07:00
2007-06-28 16:03:01 -07:00
2007-08-08 11:34:35 +04:00
2007-04-04 15:40:40 +02:00
2007-02-06 14:19:07 +01:00
2007-03-23 12:35:30 +01:00
2007-06-14 23:23:30 +02:00
2007-07-06 11:35:10 -07:00
2007-07-06 11:35:10 -07:00
2007-04-02 17:26:39 +05:00
2007-04-18 12:39:04 +05:00
2007-05-30 00:33:12 +04:00
2007-03-05 10:03:42 +01:00
2007-03-05 10:03:42 +01:00
2007-07-19 20:21:23 +04:00
2007-05-16 12:22:20 +03:00
2007-02-12 13:59:29 -07:00
2007-06-09 17:13:33 +05:00
2007-04-28 20:01:01 +04:00
2007-03-01 19:20:47 -07:00
2007-05-16 10:44:59 +02:00
2007-06-17 11:35:14 -07:00
2007-08-03 18:59:16 +02:00
2007-07-09 17:41:24 +03:00
2007-07-05 18:24:48 +03:00
2007-06-08 14:42:08 +05:00
2007-02-26 11:49:24 +01:00
2007-06-01 13:39:54 +02:00
2007-06-15 11:15:22 -06:00
2007-07-31 11:03:31 +05:00
2007-06-23 23:33:55 -07:00
2007-08-27 10:37:12 -03:00
2007-07-21 12:34:18 -07:00
2007-03-28 12:11:44 +02:00
2007-05-31 14:54:44 +04:00
2007-03-20 19:36:11 +01:00
2007-02-23 20:24:32 +03:00
2007-07-14 22:02:10 +04:00
2007-08-29 11:53:15 +02:00
2007-03-23 19:24:03 +01:00
2007-08-20 11:23:08 +05:00
2007-03-20 17:53:55 +04:00
2007-02-19 10:08:27 +01:00
2007-08-16 14:13:07 +02:00
2007-07-30 17:14:34 +04:00
2007-08-27 10:13:54 -03:00
2007-02-15 15:39:03 +01:00
2007-02-19 13:57:06 +03:00
2007-07-18 16:22:05 +04:00
2007-06-07 19:18:01 +02:00
2007-07-31 11:03:31 +05:00
2007-06-12 01:41:23 +04:00
2007-05-16 09:51:05 +04:00
2007-07-11 18:45:35 -07:00
2007-05-26 10:33:01 -07:00
2007-06-15 11:15:22 -06:00
2007-05-31 20:04:54 +02:00
2007-05-22 15:58:30 +03:00
2007-02-07 14:22:19 -08:00
2007-02-24 13:12:20 +03:00
2007-06-21 21:39:52 -04:00
2007-05-18 12:08:07 +05:00
2007-08-28 16:44:31 +02:00
2007-02-26 11:49:24 +01:00
2007-02-24 13:12:20 +03:00
2007-06-11 23:06:20 +04:00
2007-06-11 23:06:20 +04:00
2007-06-11 23:06:20 +04:00
2007-04-30 23:16:46 +02:00
2007-04-30 23:16:46 +02:00
2007-04-30 23:16:46 +02:00
2007-06-06 04:42:41 +05:00
2007-06-20 14:21:48 +05:00
2007-07-30 18:27:36 +03:00
2007-06-01 11:14:04 +03:00
2007-08-29 14:44:23 +02:00
2007-05-19 18:15:08 +02:00
2007-09-04 14:38:26 -06:00
2007-08-07 11:40:03 +02:00
2007-06-07 19:18:01 +02:00
2007-02-22 15:28:42 +03:00
2007-06-07 19:18:01 +02:00
2007-08-01 15:27:03 +05:00
2007-07-21 04:50:11 +05:00
2007-08-13 15:46:11 +02:00
2007-04-05 09:12:30 +02:00
2007-06-14 18:40:32 +02:00
2007-05-28 13:23:11 +02:00
2007-03-21 09:13:05 +01:00
2007-06-15 11:15:22 -06:00
2007-05-09 14:14:27 +02:00
2007-02-21 13:02:57 +02:00
2007-02-26 11:49:24 +01:00
2007-02-06 23:06:58 +01:00
2007-03-08 15:37:53 +07:00
2007-06-17 22:04:01 +02:00
2007-04-16 14:07:31 +02:00
2007-04-04 12:50:39 +02:00
2007-01-18 13:26:48 -07:00
2007-04-29 18:32:59 -07:00
2007-04-11 23:42:53 +02:00
2007-06-01 17:49:01 +04:00
2007-05-17 14:17:50 -06:00
2007-02-26 11:49:24 +01:00
2007-08-28 11:16:03 -06:00
2007-06-22 11:55:48 +02:00
2007-08-29 12:47:00 +02:00
2007-08-21 13:43:09 +02:00
2007-08-21 17:47:06 +02:00
2007-03-31 00:48:31 +04:00
2007-06-01 17:49:01 +04:00
2007-06-07 19:18:01 +02:00
2007-06-07 19:18:01 +02:00
2007-06-20 12:46:56 +03:00
2007-04-12 14:00:45 +02:00
2007-03-20 11:15:15 +01:00
2007-06-21 16:55:52 +02:00
2007-03-29 14:16:28 +02:00
2007-07-26 16:59:21 +03:00
2007-02-08 15:53:14 +01:00
2007-02-08 15:53:14 +01:00
2007-02-08 15:53:14 +01:00
2007-03-01 11:52:25 +04:00
2007-06-01 18:04:25 +04:00
2007-06-15 16:09:28 +05:00
2007-07-09 13:18:27 -06:00
2007-03-05 10:03:42 +01:00
2007-06-01 13:39:54 +02:00
2007-08-03 14:14:33 +03:00
2007-02-26 15:25:43 +04:00
2007-07-05 13:09:56 +05:00
2007-07-27 18:42:25 +05:00
2007-06-22 09:28:38 +05:00
2007-08-28 11:34:43 +02:00
2007-02-27 14:54:33 +01:00
2007-08-06 04:57:28 -07:00
2007-05-24 15:35:43 +05:00
2007-05-31 17:30:56 +05:00
2007-08-15 10:24:18 -07:00
2007-08-01 11:41:13 +05:00
2007-08-02 18:23:23 +05:00
2007-03-16 12:15:51 +04:00
2007-06-07 19:18:01 +02:00
2007-06-14 23:23:30 +02:00
2007-06-07 22:23:47 +02:00
2007-08-07 11:40:03 +02:00
2007-06-22 11:55:48 +02:00
2007-10-09 20:46:33 -03:00
2007-07-27 16:56:29 +02:00
2007-03-23 14:12:11 +03:00
2007-02-19 13:57:06 +03:00
2007-05-16 14:25:38 +02:00
2007-09-04 14:38:26 -06:00
2007-07-17 14:43:56 -04:00
2007-03-05 10:03:42 +01:00
2007-03-05 10:03:42 +01:00
2007-07-12 22:06:33 -04:00
2007-03-05 10:03:42 +01:00
2007-06-26 20:33:53 -04:00
2007-06-02 00:57:25 +02:00
2007-06-02 00:57:25 +02:00
2007-06-06 18:55:21 +05:00
2007-06-29 10:39:17 +03:00
2007-07-13 16:32:29 +03:00
2007-04-04 15:40:40 +02:00
2007-04-04 15:40:40 +02:00
2007-03-22 10:56:47 +01:00
2007-02-26 09:24:03 +01:00
2007-07-12 22:26:41 +04:00
2007-07-18 14:42:06 +04:00
2007-04-17 12:32:01 +02:00
2007-08-06 01:01:22 -07:00
2007-02-14 14:44:34 +01:00
2007-05-16 10:44:59 +02:00
2007-06-06 00:25:06 +04:00
2007-06-13 09:32:36 -07:00
2007-07-22 18:26:16 -07:00
2007-05-28 12:44:59 +04:00
2007-07-07 15:45:28 -07:00
2007-04-02 15:01:19 +05:00
2007-07-15 21:51:36 +04:00
2007-02-23 18:05:32 +01:00
2007-03-29 09:08:30 +05:00
2007-10-09 20:46:33 -03:00
2007-03-21 21:54:38 +03:00
2007-04-23 18:22:33 +04:00
2007-06-07 19:18:01 +02:00
2007-06-03 14:46:09 +04:00
2007-04-12 18:03:26 -04:00
2007-04-09 17:58:56 +05:00
2007-03-23 17:56:58 +02:00
2007-07-28 16:02:29 +04:00
2007-02-24 13:12:20 +03:00
2007-03-23 22:16:32 +02:00
2007-06-27 14:04:29 +02:00
2007-07-02 14:22:03 -04:00
2007-04-23 17:15:51 +03:00
2007-02-26 11:49:24 +01:00
ad104d5bfd