mirror of
https://github.com/MariaDB/server.git
synced 2025-11-09 11:41:36 +03:00
e572c745dc
ha_innobase::referenced_by_foreign_key(): Protect the check with dict_sys.freeze(), to prevent races with TRUNCATE TABLE. The test innodb.instant_alter_crash has been adjusted for this additional locking. dict_table_is_referenced_by_foreign_key(): Removed (merged to the only caller). create_table_info_t::create_table(): Ignore missing indexes for FOREIGN KEY constraints if foreign_key_checks=0. create_table_info_t::create_table_update_dict(): Rewritten as a static function. Do not return any error. ha_innobase::create(): When trx!=nullptr and we are operating on a persistent table, do not rollback, commit, or release the data dictionary latch. ha_innobase::truncate(): Protect the entire critical section with an exclusive dict_sys.latch, so that ha_innobase::referenced_by_foreign_key() on referenced tables will return a consistent result. In case of a failure, invoke dict_load_foreigns() to restore also any FOREIGN KEY constraints. ha_innobase::free_foreign_key_create_info(): Define inline. lock_release(): Disregard innodb_evict_tables_on_commit_debug=ON when dict_sys.locked() holds. It would hold when fts_load_stopword() is invoked by create_table_info_t::create_table_update_dict(). dict_sys_t::locked(): Return whether the current thread is holding the exclusive dict_sys.latch. dict_sys_t::frozen_not_locked(): Return whether any thread is holding a shared dict_sys.latch. In the test main.mysql_upgrade, the InnoDB persistent statistics will no longer be recalculated in ha_innobase::open() as part of CHECK TABLE ... FOR UPGRADE. They were deleted earlier in the test. Tested by: Matthias Leich
113 lines
2.9 KiB
Plaintext
113 lines
2.9 KiB
Plaintext
--source include/have_innodb.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
CREATE TABLE parent (a INT PRIMARY KEY) ENGINE=InnoDB;
|
|
INSERT INTO parent SET a=1;
|
|
|
|
CREATE TABLE child (a INT PRIMARY KEY, FOREIGN KEY (a) REFERENCES parent(a)
|
|
ON UPDATE CASCADE)
|
|
ENGINE=InnoDB;
|
|
INSERT INTO child SET a=1;
|
|
|
|
--error ER_TRUNCATE_ILLEGAL_FK
|
|
TRUNCATE TABLE parent;
|
|
TRUNCATE TABLE child;
|
|
|
|
INSERT INTO child SET a=1;
|
|
UPDATE parent SET a=2;
|
|
SELECT * FROM child;
|
|
|
|
connect (dml,localhost,root);
|
|
SET DEBUG_SYNC='foreign_constraint_update_cascade SIGNAL fk WAIT_FOR go';
|
|
send UPDATE parent SET a=3;
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC='now WAIT_FOR fk';
|
|
SET lock_wait_timeout=1;
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
TRUNCATE TABLE child;
|
|
SET DEBUG_SYNC='now SIGNAL go';
|
|
|
|
connection dml;
|
|
reap;
|
|
SELECT * FROM child;
|
|
SET DEBUG_SYNC='foreign_constraint_check_for_update SIGNAL fk WAIT_FOR go';
|
|
send DELETE FROM parent;
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC='now WAIT_FOR fk';
|
|
SET lock_wait_timeout=1;
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
TRUNCATE TABLE child;
|
|
SET DEBUG_SYNC='now SIGNAL go';
|
|
|
|
connection dml;
|
|
--error ER_ROW_IS_REFERENCED_2
|
|
reap;
|
|
SELECT * FROM child;
|
|
INSERT INTO parent SET a=5;
|
|
SET DEBUG_SYNC='foreign_constraint_check_for_ins SIGNAL fk WAIT_FOR go';
|
|
send INSERT INTO child SET a=5;
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC='now WAIT_FOR fk';
|
|
SET foreign_key_checks=0, innodb_lock_wait_timeout=0;
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
TRUNCATE TABLE parent;
|
|
SET DEBUG_SYNC='now SIGNAL go';
|
|
|
|
connection dml;
|
|
reap;
|
|
SELECT * FROM parent;
|
|
SELECT * FROM child;
|
|
disconnect dml;
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC = RESET;
|
|
|
|
DROP TABLE child, parent;
|
|
|
|
--echo #
|
|
--echo # MDEV-24532 Table corruption ER_NO_SUCH_TABLE_IN_ENGINE or
|
|
--echo # ER_CRASHED_ON_USAGE after ALTER on table with foreign key
|
|
--echo #
|
|
|
|
CREATE TABLE t1 (a INT, b INT, PRIMARY KEY (a)) ENGINE=InnoDB;
|
|
ALTER TABLE t1 ADD FOREIGN KEY (b) REFERENCES t1 (a) ON UPDATE CASCADE;
|
|
LOCK TABLE t1 WRITE;
|
|
TRUNCATE TABLE t1;
|
|
ALTER TABLE t1 ADD c INT;
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1;
|
|
|
|
--echo #
|
|
--echo # MDEV-26052 Assertion prebuilt->trx_id < table->def_trx_id failed
|
|
--echo #
|
|
|
|
call mtr.add_suppression("InnoDB: In ALTER TABLE `test`\\.`t1` has or is");
|
|
|
|
CREATE TABLE t1 (pk INT, a INT, PRIMARY KEY (pk), KEY (a)) ENGINE=InnoDB;
|
|
SET FOREIGN_KEY_CHECKS=0;
|
|
ALTER TABLE t1 ADD FOREIGN KEY (a) REFERENCES t1 (a), ALGORITHM=COPY;
|
|
INSERT INTO t1 VALUES (1,1);
|
|
LOCK TABLES t1 WRITE;
|
|
SET FOREIGN_KEY_CHECKS=1;
|
|
--error ER_CANNOT_ADD_FOREIGN
|
|
TRUNCATE t1;
|
|
# Whether TRUNCATE succeeds or fails, it will reload FOREIGN KEY constraints.
|
|
# As a result, ha_innobase::referenced_by_foreign_key() will retun TRUE
|
|
# (for the self-referential key), and the statement will fail.
|
|
--error ER_TABLE_NOT_LOCKED
|
|
INSERT INTO t1 VALUES (2,2);
|
|
SELECT * FROM t1;
|
|
UNLOCK TABLES;
|
|
--error ER_NO_REFERENCED_ROW_2
|
|
INSERT INTO t1 VALUES (2,2);
|
|
SET FOREIGN_KEY_CHECKS=0;
|
|
INSERT INTO t1 VALUES (2,2);
|
|
SELECT * FROM t1;
|
|
DROP TABLE t1;
|
|
|
|
--echo # End of 10.6 tests
|