mirror of
https://github.com/MariaDB/server.git
synced 2025-11-02 02:53:04 +03:00
order with Galera and encrypt-tmp-files=1 Problem:- If trans_cache (IO_CACHE) uses encrypted tmp file then on next DML server will crash. Case:- Lets take a case , we have a table t1 , We try to do 2 inserts in t1 1. A really long insert so that trans_cache has to use temp_file 2. Just a small insert Analysis:- Actually server crashes from inside of galera library. /lib64/libc.so.6(abort+0x175)[0x7fb5ba779dc5] /usr/lib64/galera/libgalera_smm.so(_ZN6galera3FSMINS_9TrxHandle5State... mysys/stacktrace.c:247(my_print_stacktrace)[0x7fb5a714940e] sql/signal_handler.cc:160(handle_fatal_signal)[0x7fb5a715c1bd] sql/wsrep_hton.cc:257(wsrep_rollback)[0x7fb5bcce923a] sql/wsrep_hton.cc:268(wsrep_rollback)[0x7fb5bcce9368] sql/handler.cc:1658(ha_rollback_trans(THD*, bool))[0x7fb5bcd4f41a] sql/handler.cc:1483(ha_commit_trans(THD*, bool))[0x7fb5bcd4f804] but actual issue is not in galera but in mariadb, because for 2nd insert we should never call rollback. We are calling rollback because log_and_order fails it fails because write_cache fails , It fails because after reinit_io_cache(trans_cache) , my_b_bytes_in_cache says 0 so we look into tmp_file for data , which is obviously wrong since temp was used for previous insert and it no longer exist. wsrep_write_cache_inc() reads the IO_CACHE in a loop, filling it with my_b_fill() until it returns "0 bytes read". Later MYSQL_BIN_LOG::write_cache() does the same. wsrep_write_cache_inc() assumes that reading a zero bytes past EOF leaves the old data in the cache Solution:- There is two issue in my_b_encr_read 1st we should never equal read_end to info->buffer. I mean this does not make sense read_end should always point to end of buffer. 2nd For most of the case(apart from async IO_CACHE) info->pos_in_file should be equal to info->buffer position wrt to temp file , since in this case we are not changing info->buffer it should remain unchanged.
279 lines
7.2 KiB
C++
279 lines
7.2 KiB
C++
/* Copyright (C) 2015 MariaDB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */
|
|
|
|
#include <my_sys.h>
|
|
#include <my_crypt.h>
|
|
#include <tap.h>
|
|
|
|
/*** tweaks and stubs for encryption code to compile ***************/
|
|
#define KEY_SIZE (128/8)
|
|
|
|
my_bool encrypt_tmp_files;
|
|
int init_io_cache_encryption();
|
|
|
|
uint encryption_key_get_latest_version_func(uint)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
uint encryption_key_id_exists_func(uint)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
uint encryption_key_version_exists_func(uint, uint)
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
uint encryption_key_get_func(uint, uint, uchar* key, uint* size)
|
|
{
|
|
if (*size < KEY_SIZE)
|
|
{
|
|
*size= KEY_SIZE;
|
|
return ENCRYPTION_KEY_BUFFER_TOO_SMALL;
|
|
}
|
|
memset(key, KEY_SIZE, *size= KEY_SIZE);
|
|
return 0;
|
|
}
|
|
|
|
#ifdef HAVE_EncryptAes128Gcm
|
|
enum my_aes_mode aes_mode= MY_AES_GCM;
|
|
#else
|
|
enum my_aes_mode aes_mode= MY_AES_CBC;
|
|
#endif
|
|
|
|
int encryption_ctx_init_func(void *ctx, const unsigned char* key, unsigned int klen,
|
|
const unsigned char* iv, unsigned int ivlen,
|
|
int flags, unsigned int key_id,
|
|
unsigned int key_version)
|
|
{
|
|
return my_aes_crypt_init(ctx, aes_mode, flags, key, klen, iv, ivlen);
|
|
}
|
|
|
|
uint encryption_encrypted_length_func(unsigned int slen, unsigned int key_id, unsigned int key_version)
|
|
{
|
|
return my_aes_get_size(aes_mode, slen);
|
|
}
|
|
|
|
struct encryption_service_st encryption_handler=
|
|
{
|
|
encryption_key_get_latest_version_func,
|
|
encryption_key_get_func,
|
|
(uint (*)(unsigned int, unsigned int))my_aes_ctx_size,
|
|
encryption_ctx_init_func,
|
|
my_aes_crypt_update,
|
|
my_aes_crypt_finish,
|
|
encryption_encrypted_length_func
|
|
};
|
|
|
|
void sql_print_information(const char *format, ...)
|
|
{
|
|
}
|
|
|
|
void sql_print_error(const char *format, ...)
|
|
{
|
|
}
|
|
|
|
/*** end of encryption tweaks and stubs ****************************/
|
|
|
|
IO_CACHE info;
|
|
#define CACHE_SIZE 16384
|
|
|
|
#define INFO_TAIL ", pos_in_file = %llu, pos_in_mem = %lu", \
|
|
info.pos_in_file, (*info.current_pos - info.request_pos)
|
|
|
|
#define FILL 0x5A
|
|
|
|
int data_bad(const uchar *buf, size_t len)
|
|
{
|
|
const uchar *end= buf + len;
|
|
while (buf < end)
|
|
if (*buf++ != FILL)
|
|
return 1;
|
|
return 0;
|
|
}
|
|
|
|
void temp_io_cache()
|
|
{
|
|
int res;
|
|
uchar buf[CACHE_SIZE + 200];
|
|
memset(buf, FILL, sizeof(buf));
|
|
|
|
diag("temp io_cache with%s encryption", encrypt_tmp_files?"":"out");
|
|
|
|
init_io_cache_encryption();
|
|
|
|
res= open_cached_file(&info, 0, 0, CACHE_SIZE, 0);
|
|
ok(res == 0, "open_cached_file" INFO_TAIL);
|
|
|
|
res= my_b_write(&info, buf, 100);
|
|
ok(res == 0 && info.pos_in_file == 0, "small write" INFO_TAIL );
|
|
|
|
res= my_b_write(&info, buf, sizeof(buf));
|
|
ok(res == 0 && info.pos_in_file == CACHE_SIZE, "large write" INFO_TAIL);
|
|
|
|
res= reinit_io_cache(&info, WRITE_CACHE, 250, 0, 0);
|
|
ok(res == 0, "reinit with rewind" INFO_TAIL);
|
|
|
|
res= my_b_write(&info, buf, sizeof(buf));
|
|
ok(res == 0, "large write" INFO_TAIL);
|
|
|
|
res= my_b_flush_io_cache(&info, 1);
|
|
ok(res == 0, "flush" INFO_TAIL);
|
|
|
|
res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
|
|
ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
|
|
|
|
res= my_pread(info.file, buf, 50, 50, MYF(MY_NABP));
|
|
ok(res == 0 && data_bad(buf, 50) == encrypt_tmp_files,
|
|
"file must be %sreadable", encrypt_tmp_files ?"un":"");
|
|
|
|
res= my_b_read(&info, buf, 50) || data_bad(buf, 50);
|
|
ok(res == 0 && info.pos_in_file == 0, "small read" INFO_TAIL);
|
|
|
|
res= my_b_read(&info, buf, sizeof(buf)) || data_bad(buf, sizeof(buf));
|
|
ok(res == 0 && info.pos_in_file == CACHE_SIZE, "large read" INFO_TAIL);
|
|
|
|
close_cached_file(&info);
|
|
}
|
|
|
|
void mdev9044()
|
|
{
|
|
int res;
|
|
uchar buf[CACHE_SIZE + 200];
|
|
|
|
diag("MDEV-9044 Binlog corruption in Galera");
|
|
|
|
res= open_cached_file(&info, 0, 0, CACHE_SIZE, 0);
|
|
ok(res == 0, "open_cached_file" INFO_TAIL);
|
|
|
|
res= my_b_write(&info, USTRING_WITH_LEN("first write\0"));
|
|
ok(res == 0, "first write" INFO_TAIL);
|
|
|
|
res= my_b_flush_io_cache(&info, 1);
|
|
ok(res == 0, "flush" INFO_TAIL);
|
|
|
|
res= reinit_io_cache(&info, WRITE_CACHE, 0, 0, 0);
|
|
ok(res == 0, "reinit WRITE_CACHE" INFO_TAIL);
|
|
|
|
res= my_b_write(&info, USTRING_WITH_LEN("second write\0"));
|
|
ok(res == 0, "second write" INFO_TAIL );
|
|
|
|
res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
|
|
ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
|
|
|
|
res= my_b_fill(&info);
|
|
ok(res == 0, "fill" INFO_TAIL);
|
|
|
|
res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
|
|
ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
|
|
|
|
res= my_b_read(&info, buf, sizeof(buf));
|
|
ok(res == 1 && strcmp((char*)buf, "second write") == 0, "read '%s'", buf);
|
|
|
|
close_cached_file(&info);
|
|
}
|
|
|
|
/* 2 Reads (with my_b_fill) in cache makes second read to fail */
|
|
void mdev10259()
|
|
{
|
|
int res;
|
|
uchar buf[200];
|
|
memset(buf, FILL, sizeof(buf));
|
|
|
|
diag("MDEV-10259- mysqld crash with certain statement length and order with"
|
|
" Galera and encrypt-tmp-files=1");
|
|
|
|
init_io_cache_encryption();
|
|
|
|
res= open_cached_file(&info, 0, 0, CACHE_SIZE, 0);
|
|
ok(res == 0, "open_cached_file" INFO_TAIL);
|
|
|
|
res= my_b_write(&info, buf, sizeof(buf));
|
|
ok(res == 0 && info.pos_in_file == 0, "200 write" INFO_TAIL);
|
|
|
|
res= my_b_flush_io_cache(&info, 1);
|
|
ok(res == 0, "flush" INFO_TAIL);
|
|
|
|
ulong saved_pos= my_b_tell(&info);
|
|
res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
|
|
ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
|
|
|
|
res= my_b_fill(&info);
|
|
ok(res == 200, "fill" INFO_TAIL);
|
|
|
|
res= my_b_fill(&info);
|
|
ok(res == 0, "fill" INFO_TAIL);
|
|
|
|
res= my_b_fill(&info);
|
|
ok(res == 0, "fill" INFO_TAIL);
|
|
|
|
res= reinit_io_cache(&info, WRITE_CACHE, saved_pos, 0, 0);
|
|
ok(res == 0, "reinit WRITE_CACHE" INFO_TAIL);
|
|
|
|
res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
|
|
ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
|
|
|
|
ok(200 == my_b_bytes_in_cache(&info),"my_b_bytes_in_cache == 200");
|
|
|
|
res= my_b_fill(&info);
|
|
ok(res == 0, "fill" INFO_TAIL);
|
|
|
|
res= my_b_fill(&info);
|
|
ok(res == 0, "fill" INFO_TAIL);
|
|
|
|
res= my_b_fill(&info);
|
|
ok(res == 0, "fill" INFO_TAIL);
|
|
|
|
res= reinit_io_cache(&info, WRITE_CACHE, saved_pos, 0, 0);
|
|
ok(res == 0, "reinit WRITE_CACHE" INFO_TAIL);
|
|
|
|
res= reinit_io_cache(&info, READ_CACHE, 0, 0, 0);
|
|
ok(res == 0, "reinit READ_CACHE" INFO_TAIL);
|
|
|
|
ok(200 == my_b_bytes_in_cache(&info),"my_b_bytes_in_cache == 200");
|
|
|
|
res= my_b_read(&info, buf, sizeof(buf)) || data_bad(buf, sizeof(buf));
|
|
ok(res == 0 && info.pos_in_file == 0, "large read" INFO_TAIL);
|
|
|
|
close_cached_file(&info);
|
|
|
|
}
|
|
|
|
int main(int argc __attribute__((unused)),char *argv[])
|
|
{
|
|
MY_INIT(argv[0]);
|
|
plan(46);
|
|
|
|
/* temp files with and without encryption */
|
|
encrypt_tmp_files= 1;
|
|
temp_io_cache();
|
|
|
|
encrypt_tmp_files= 0;
|
|
temp_io_cache();
|
|
|
|
/* regression tests */
|
|
mdev9044();
|
|
|
|
encrypt_tmp_files= 1;
|
|
mdev10259();
|
|
encrypt_tmp_files= 0;
|
|
|
|
my_end(0);
|
|
return exit_status();
|
|
}
|
|
|