mirror of
				https://github.com/MariaDB/server.git
				synced 2025-10-31 15:50:51 +03:00 
			
		
		
		
	 a43c4b0265
			
		
	
	a43c4b0265
	
	
	
		
			
			auto_increment breaks binlog": if slave's table had a higher auto_increment counter than master's (even though all rows of the two tables were identical), then in some cases, REPLACE and INSERT ON DUPLICATE KEY UPDATE failed to replicate statement-based (it inserted different values on slave from on master). write_record() contained a "thd->next_insert_id=0" to force an adjustment of thd->next_insert_id after the update or replacement. But it is this assigment introduced indeterminism of the statement on the slave, thus the bug. For ON DUPLICATE, we replace that assignment by a call to handler::adjust_next_insert_id_after_explicit_value() which is deterministic (does not depend on slave table's autoinc counter). For REPLACE, this assignment can simply be removed (as REPLACE can't insert a number larger than thd->next_insert_id). We also move a too early restore_auto_increment() down to when we really know that we can restore the value.
		
			
				
	
	
		
			200 lines
		
	
	
		
			3.8 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			200 lines
		
	
	
		
			3.8 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
| stop slave;
 | |
| drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
 | |
| reset master;
 | |
| reset slave;
 | |
| drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
 | |
| start slave;
 | |
| create table t1(a int auto_increment, key(a));
 | |
| create table t2(b int auto_increment, c int, key(b));
 | |
| insert into t1 values (1),(2),(3);
 | |
| insert into t1 values (null);
 | |
| insert into t2 values (null,last_insert_id());
 | |
| select * from t1;
 | |
| a
 | |
| 1
 | |
| 2
 | |
| 3
 | |
| 4
 | |
| select * from t2;
 | |
| b	c
 | |
| 1	4
 | |
| drop table t1;
 | |
| drop table t2;
 | |
| create table t1(a int auto_increment, key(a)) engine=innodb;
 | |
| create table t2(b int auto_increment, c int, key(b), foreign key(b) references t1(a)) engine=innodb;
 | |
| SET FOREIGN_KEY_CHECKS=0;
 | |
| insert into t1 values (10);
 | |
| insert into t1 values (null),(null),(null);
 | |
| insert into t2 values (5,0);
 | |
| insert into t2 values (null,last_insert_id());
 | |
| SET FOREIGN_KEY_CHECKS=1;
 | |
| select * from t1;
 | |
| a
 | |
| 10
 | |
| 11
 | |
| 12
 | |
| 13
 | |
| select * from t2;
 | |
| b	c
 | |
| 5	0
 | |
| 6	11
 | |
| drop table t2;
 | |
| drop table t1;
 | |
| create table t1(a int auto_increment, key(a));
 | |
| create table t2(b int auto_increment, c int, key(b));
 | |
| insert into t1 values (10);
 | |
| insert into t1 values (null),(null),(null);
 | |
| insert into t2 values (5,0);
 | |
| insert into t2 (c) select * from t1;
 | |
| select * from t2;
 | |
| b	c
 | |
| 5	0
 | |
| 6	10
 | |
| 7	11
 | |
| 8	12
 | |
| 9	13
 | |
| select * from t1;
 | |
| a
 | |
| 10
 | |
| 11
 | |
| 12
 | |
| 13
 | |
| select * from t2;
 | |
| b	c
 | |
| 5	0
 | |
| 6	10
 | |
| 7	11
 | |
| 8	12
 | |
| 9	13
 | |
| drop table t1;
 | |
| drop table t2;
 | |
| SET TIMESTAMP=1000000000;
 | |
| CREATE TABLE t1 ( a INT UNIQUE );
 | |
| SET FOREIGN_KEY_CHECKS=0;
 | |
| INSERT INTO t1 VALUES (1),(1);
 | |
| ERROR 23000: Duplicate entry '1' for key 1
 | |
| drop table t1;
 | |
| drop function if exists bug15728;
 | |
| drop function if exists bug15728_insert;
 | |
| drop table if exists t1, t2;
 | |
| create table t1 (
 | |
| id int not null auto_increment,
 | |
| last_id int,
 | |
| primary key (id)
 | |
| );
 | |
| create function bug15728() returns int(11)
 | |
| return last_insert_id();
 | |
| insert into t1 (last_id) values (0);
 | |
| insert into t1 (last_id) values (last_insert_id());
 | |
| insert into t1 (last_id) values (bug15728());
 | |
| create table t2 (
 | |
| id int not null auto_increment,
 | |
| last_id int,
 | |
| primary key (id)
 | |
| );
 | |
| create function bug15728_insert() returns int(11) modifies sql data
 | |
| begin
 | |
| insert into t2 (last_id) values (bug15728());
 | |
| return bug15728();
 | |
| end|
 | |
| create trigger t1_bi before insert on t1 for each row
 | |
| begin
 | |
| declare res int;
 | |
| select bug15728_insert() into res;
 | |
| set NEW.last_id = res;
 | |
| end|
 | |
| insert into t1 (last_id) values (0);
 | |
| drop trigger t1_bi;
 | |
| select last_insert_id();
 | |
| last_insert_id()
 | |
| 4
 | |
| select bug15728_insert();
 | |
| bug15728_insert()
 | |
| 2
 | |
| select last_insert_id();
 | |
| last_insert_id()
 | |
| 4
 | |
| insert into t1 (last_id) values (bug15728());
 | |
| select last_insert_id();
 | |
| last_insert_id()
 | |
| 5
 | |
| select * from t1;
 | |
| id	last_id
 | |
| 1	0
 | |
| 2	1
 | |
| 3	2
 | |
| 4	1
 | |
| 5	4
 | |
| select * from t2;
 | |
| id	last_id
 | |
| 1	3
 | |
| 2	4
 | |
| drop function bug15728;
 | |
| drop function bug15728_insert;
 | |
| drop table t1, t2;
 | |
| create table t1 (n int primary key auto_increment not null,
 | |
| b int, unique(b));
 | |
| set sql_log_bin=0;
 | |
| insert into t1 values(null,100);
 | |
| replace into t1 values(null,50),(null,100),(null,150);
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 2	50
 | |
| 3	100
 | |
| 4	150
 | |
| truncate table t1;
 | |
| set sql_log_bin=1;
 | |
| insert into t1 values(null,100);
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 1	100
 | |
| insert into t1 values(null,200),(null,300);
 | |
| delete from t1 where b <> 100;
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 1	100
 | |
| replace into t1 values(null,100),(null,350);
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 2	100
 | |
| 3	350
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 2	100
 | |
| 3	350
 | |
| insert into t1 values (NULL,400),(3,500),(NULL,600) on duplicate key UPDATE n=1000;
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 2	100
 | |
| 4	400
 | |
| 1000	350
 | |
| 1001	600
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 2	100
 | |
| 4	400
 | |
| 1000	350
 | |
| 1001	600
 | |
| drop table t1;
 | |
| create table t1 (n int primary key auto_increment not null,
 | |
| b int, unique(b));
 | |
| insert into t1 values(null,100);
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 1	100
 | |
| insert into t1 values(null,200),(null,300);
 | |
| delete from t1 where b <> 100;
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 1	100
 | |
| insert into t1 values(null,100),(null,350) on duplicate key update n=2;
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 2	100
 | |
| 3	350
 | |
| select * from t1 order by n;
 | |
| n	b
 | |
| 2	100
 | |
| 3	350
 | |
| drop table t1;
 |