mirror of
https://github.com/MariaDB/server.git
synced 2025-11-28 17:36:30 +03:00
4b80c11f52
- InnoDB DDL results in `Duplicate entry' if concurrent DML throws duplicate key error. The following scenario explains the problem connection con1: ALTER TABLE t1 FORCE; connection con2: INSERT INTO t1(pk, uk) VALUES (2, 2), (3, 2); In connection con2, InnoDB throws the 'DUPLICATE KEY' error because of unique index. Alter operation will throw the error when applying the concurrent DML log. - Inserting the duplicate key for unique index logs the insert operation for online ALTER TABLE. When insertion fails, transaction does rollback and it leads to logging of delete operation for online ALTER TABLE. While applying the insert log entries, alter operation encounters 'DUPLICATE KEY' error. - To avoid the above fake duplicate scenario, InnoDB should not write any log for online ALTER TABLE before DML transaction commit. - User thread which does DML can apply the online log if InnoDB ran out of online log and index is marked as completed. Set online log error if apply phase encountered any error. It can also clear all other indexes log, marks the newly added indexes as corrupted. - Removed the old online code which was a part of DML operations commit_inplace_alter_table() : Does apply the online log for the last batch of secondary index log and does frees the log for the completed index. trx_t::apply_online_log: Set to true while writing the undo log if the modified table has active DDL trx_t::apply_log(): Apply the DML changes to online DDL tables dict_table_t::is_active_ddl(): Returns true if the table has an active DDL dict_index_t::online_log_make_dummy(): Assign dummy value for clustered index online log to indicate the secondary indexes are being rebuild. dict_index_t::online_log_is_dummy(): Check whether the online log has dummy value ha_innobase_inplace_ctx::log_failure(): Handle the apply log failure for online DDL transaction row_log_mark_other_online_index_abort(): Clear out all other online index log after encountering the error during row_log_apply() row_log_get_error(): Get the error happened during row_log_apply() row_log_online_op(): Does apply the online log if index is completed and ran out of memory. Returns false if apply log fails UndorecApplier: Introduced a class to maintain the undo log record, latched undo buffer page, parse the undo log record, maintain the undo record type, info bits and update vector UndorecApplier::get_old_rec(): Get the correct version of the clustered index record that was modified by the current undo log record UndorecApplier::clear_undo_rec(): Clear the undo log related information after applying the undo log record UndorecApplier::log_update(): Handle the update, delete undo log and apply it on online indexes UndorecApplier::log_insert(): Handle the insert undo log and apply it on online indexes UndorecApplier::is_same(): Check whether the given roll pointer is generated by the current undo log record information trx_t::rollback_low(): Set apply_online_log for the transaction after partially rollbacked transaction has any active DDL prepare_inplace_alter_table_dict(): After allocating the online log, InnoDB does create fulltext common tables. Fulltext index doesn't allow the index to be online. So removed the dead code of online log removal Thanks to Marko Mäkelä for providing the initial prototype and Matthias Leich for testing the issue patiently.
77 lines
2.7 KiB
Plaintext
77 lines
2.7 KiB
Plaintext
CREATE TABLE articles (
|
|
id INT UNSIGNED AUTO_INCREMENT NOT NULL PRIMARY KEY,
|
|
title VARCHAR(200),
|
|
body TEXT,
|
|
FULLTEXT (title,body)
|
|
) ENGINE=InnoDB;
|
|
SET @saved_debug_dbug = @@SESSION.debug_dbug;
|
|
SET SESSION debug_dbug="+d,ib_dict_create_index_tree_fail";
|
|
CREATE FULLTEXT INDEX idx ON articles(body);
|
|
ERROR HY000: Out of memory.
|
|
SET SESSION debug_dbug=@saved_debug_dbug;
|
|
ALTER TABLE articles STATS_PERSISTENT=DEFAULT;
|
|
DROP TABLE articles;
|
|
CREATE TABLE t (a INT, b TEXT) engine=innodb;
|
|
SET debug_dbug='+d,alter_table_rollback_new_index';
|
|
ALTER TABLE t ADD FULLTEXT INDEX (b(64));
|
|
ERROR HY000: Unknown error
|
|
SET SESSION debug_dbug=@saved_debug_dbug;
|
|
DROP TABLE t;
|
|
CREATE TABLE t1 (pk INT, a VARCHAR(8), PRIMARY KEY(pk),
|
|
FULLTEXT KEY(a)) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (b INT, FOREIGN KEY(b) REFERENCES t1(pk)) ENGINE=InnoDB;
|
|
DROP TABLE/*foo*/ t1;
|
|
ERROR 23000: Cannot delete or update a parent row: a foreign key constraint fails
|
|
SET DEBUG_DBUG="+d,fts_instrument_sync";
|
|
INSERT INTO t1 VALUES(1, "mariadb");
|
|
ALTER TABLE t1 FORCE;
|
|
DROP TABLE t2, t1;
|
|
SET SESSION debug_dbug=@saved_debug_dbug;
|
|
#
|
|
# MDEV-25200 Index count mismatch due to aborted FULLTEXT INDEX
|
|
#
|
|
CREATE TABLE t1(a INT, b TEXT, c TEXT, FULLTEXT INDEX(b)) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES(1, "test", "test_1");
|
|
connect con1,localhost,root,,test;
|
|
SET DEBUG_DBUG="+d,innodb_OOM_inplace_alter";
|
|
SET DEBUG_SYNC='innodb_commit_inplace_alter_table_enter SIGNAL s2 WAIT_FOR g2';
|
|
ALTER TABLE t1 ADD FULLTEXT(c);
|
|
connection default;
|
|
SET DEBUG_SYNC='now WAIT_FOR s2';
|
|
START TRANSACTION;
|
|
SELECT * FROM t1;
|
|
a b c
|
|
1 test test_1
|
|
SET DEBUG_SYNC='now SIGNAL g2';
|
|
connection con1;
|
|
ERROR HY000: Out of memory.
|
|
disconnect con1;
|
|
connection default;
|
|
SET DEBUG_SYNC=RESET;
|
|
ALTER TABLE t1 ADD bl INT AS (LENGTH(b)) VIRTUAL;
|
|
CHECK TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
DROP TABLE t1;
|
|
#
|
|
# MDEV-25663 Double free of transaction during TRUNCATE
|
|
#
|
|
call mtr.add_suppression("InnoDB: \\(Too many concurrent transactions\\)");
|
|
call mtr.add_suppression("InnoDB: Cannot save table statistics for table `test`\\.`t1`: Too many concurrent transactions");
|
|
CREATE TABLE t1 (b CHAR(12), FULLTEXT KEY(b)) engine=InnoDB;
|
|
SET debug_dbug='+d,ib_create_table_fail_too_many_trx';
|
|
TRUNCATE t1;
|
|
ERROR HY000: Got error -1 "Internal error < 0 (Not system error)" from storage engine InnoDB
|
|
SET debug_dbug=@saved_debug_dbug;
|
|
DROP TABLE t1;
|
|
# End of 10.3 tests
|
|
CREATE TABLE t1(f1 INT NOT NULL, f2 CHAR(100))ENGINE=InnoDB;
|
|
SET DEBUG_DBUG="+d,stats_lock_fail";
|
|
ALTER TABLE t1 ADD FULLTEXT(f2);
|
|
ERROR HY000: Got error 15 "Block device required" from storage engine InnoDB
|
|
SET DEBUG_DBUG="-d,stats_lock_fail";
|
|
ALTER TABLE t1 DISCARD TABLESPACE;
|
|
ALTER TABLE t1 ADD FULLTEXT(f2);
|
|
ERROR HY000: Tablespace has been discarded for table `t1`
|
|
DROP TABLE t1;
|