mirror of
https://github.com/MariaDB/server.git
synced 2025-12-24 11:21:21 +03:00
corruption on ADD PARTITION and LOCK TABLE
Bug#53770: Server crash at handler.cc:2076 on
LOAD DATA after timed out COALESCE PARTITION
5.5 fix for:
Bug#51042: REORGANIZE PARTITION can leave table in an
inconsistent state in case of crash
Needs to be back-ported to 5.1
5.5 fix for:
Bug#50418: DROP PARTITION does not interact with
transactions
Main problem was non-persistent operations done
before meta-data lock was taken (53770+53676).
And 53676 needed to keep the table/partitions opened and locked
while copying the data to the new partitions.
Also added thorough tests to spot some additional bugs
in the ddl_log code, which could result in bad state
between the .frm and partitions.
Collapsed patch, includes all fixes required from the reviewers.
208 lines
5.9 KiB
Plaintext
208 lines
5.9 KiB
Plaintext
################################################################################
|
|
# t/partition_special_innodb.test #
|
|
# #
|
|
# Purpose: #
|
|
# different Tests #
|
|
# InnoDB branch #
|
|
# #
|
|
#------------------------------------------------------------------------------#
|
|
# Original Author: HH #
|
|
# Original Date: 2006-08-01 #
|
|
# Change Author: MattiasJ #
|
|
# Change Date: 2008-08-20 #
|
|
# Change: added test for bug#34604 #
|
|
################################################################################
|
|
|
|
#
|
|
# NOTE: PLEASE DO NOT ADD NOT INNODB SPECIFIC TESTCASES HERE !
|
|
# TESTCASES WHICH MUST BE APPLIED TO ALL STORAGE ENGINES MUST BE ADDED IN
|
|
# THE SOURCED FILES ONLY.
|
|
#
|
|
# Please read the README at the end of inc/partition.pre before changing
|
|
# any of the variables.
|
|
#
|
|
|
|
#------------------------------------------------------------------------------#
|
|
# General not engine specific settings and requirements
|
|
|
|
##### Options, for debugging support #####
|
|
let $debug= 0;
|
|
|
|
# The server must support partitioning.
|
|
--source include/have_partition.inc
|
|
|
|
#------------------------------------------------------------------------------#
|
|
# Engine specific settings and requirements
|
|
|
|
##### Storage engine to be tested
|
|
--source include/have_innodb.inc
|
|
let $engine= 'InnoDB';
|
|
|
|
#------------------------------------------------------------------------------#
|
|
# Execute the tests to be applied to all storage engines
|
|
--source suite/parts/inc/partition_key_4col.inc
|
|
--source suite/parts/inc/partition_key_8col.inc
|
|
--source suite/parts/inc/partition_key_16col.inc
|
|
--source suite/parts/inc/partition_key_32col.inc
|
|
|
|
#------------------------------------------------------------------------------#
|
|
# Execute storage engine specific tests
|
|
|
|
--echo # Bug#34604 - Assertion 'inited==RND' failed in handler::ha_rnd_end
|
|
|
|
CREATE TABLE t1 (
|
|
a INT AUTO_INCREMENT,
|
|
b VARCHAR(255),
|
|
PRIMARY KEY (a))
|
|
ENGINE = InnoDB
|
|
PARTITION BY HASH (a)
|
|
PARTITIONS 2;
|
|
|
|
connect (con1,127.0.0.1,root,,test,$MASTER_MYPORT,);
|
|
connect (con2,127.0.0.1,root,,test,$MASTER_MYPORT,);
|
|
|
|
--connection con1
|
|
SET autocommit=OFF;
|
|
START TRANSACTION;
|
|
INSERT INTO t1 VALUES (NULL, 'first row t2');
|
|
|
|
--connection con2
|
|
SET autocommit=OFF;
|
|
SET SESSION lock_wait_timeout= 1;
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
ALTER TABLE t1 AUTO_INCREMENT = 10;
|
|
|
|
--disconnect con2
|
|
--disconnect con1
|
|
--connection default
|
|
DROP TABLE t1;
|
|
|
|
--echo #
|
|
--echo # Bug#53676: Unexpected errors and possible table corruption on
|
|
--echo # ADD PARTITION and LOCK TABLE
|
|
--connect (con1,localhost,root,,)
|
|
CREATE TABLE t1 ( i INT NOT NULL AUTO_INCREMENT PRIMARY KEY, f INT )
|
|
ENGINE = InnoDB PARTITION BY HASH(i) PARTITIONS 2;
|
|
|
|
--connect (con2,localhost,root,,)
|
|
SET lock_wait_timeout = 2;
|
|
|
|
--connection con1
|
|
--echo #Connection 1 locks the table
|
|
LOCK TABLE t1 READ;
|
|
|
|
--connection con2
|
|
--echo # Connection 2 tries to add partitions:
|
|
--echo # First attempt: lock wait timeout (as expected)
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
ALTER TABLE t1 ADD PARTITION PARTITIONS 2;
|
|
--echo # Second attempt: says that partition already exists
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
ALTER TABLE t1 ADD PARTITION PARTITIONS 2;
|
|
|
|
--connection con1
|
|
--echo # Connection 1 unlocks the table and locks it again:
|
|
UNLOCK TABLES;
|
|
--real_sleep 1
|
|
LOCK TABLE t1 READ;
|
|
|
|
--connection con2
|
|
--echo # Connection 2 tries again to add partitions:
|
|
--echo # Third attempt: says that the table does not exist
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
ALTER TABLE t1 ADD PARTITION PARTITIONS 2;
|
|
--echo # Check table returns the same
|
|
CHECK TABLE t1;
|
|
|
|
--connection con1
|
|
UNLOCK TABLES;
|
|
|
|
--connection con2
|
|
DROP TABLE t1;
|
|
|
|
# End of Test1
|
|
|
|
# Test2
|
|
|
|
--connection con1
|
|
|
|
CREATE TABLE t2 ( i INT NOT NULL AUTO_INCREMENT PRIMARY KEY, f INT )
|
|
ENGINE = InnoDB PARTITION BY HASH(i) PARTITIONS 2;
|
|
|
|
--connection con2
|
|
SET lock_wait_timeout = 2;
|
|
|
|
--connection con1
|
|
LOCK TABLE t2 READ;
|
|
|
|
--connection con2
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
ALTER TABLE t2 ADD PARTITION PARTITIONS 2;
|
|
send ALTER TABLE t2 ADD PARTITION PARTITIONS 2;
|
|
|
|
--connection con1
|
|
UNLOCK TABLES;
|
|
|
|
--connection con2
|
|
--reap
|
|
|
|
--connect (con3,localhost,root,,)
|
|
CHECK TABLE t2;
|
|
SELECT * FROM t2;
|
|
DROP TABLE t2;
|
|
|
|
# End of Test2
|
|
# Test #3
|
|
|
|
--connection con1
|
|
|
|
CREATE TABLE t3 ( i INT NOT NULL AUTO_INCREMENT PRIMARY KEY, f INT )
|
|
ENGINE = InnoDB PARTITION BY HASH(i) PARTITIONS 2;
|
|
|
|
--connection con2
|
|
SET lock_wait_timeout = 2;
|
|
|
|
--connection con1
|
|
--echo # Connection 1 locks the table
|
|
LOCK TABLE t3 READ;
|
|
|
|
--connection con2
|
|
--echo # Connection 2 tries to add partitions (timeout):
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
ALTER TABLE t3 ADD PARTITION PARTITIONS 2;
|
|
|
|
--connection con3
|
|
SET lock_wait_timeout = 2;
|
|
--echo # Connection 3 tries to add partitions (partition already exists):
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
ALTER TABLE t3 ADD PARTITION PARTITIONS 2;
|
|
|
|
--connect (con4,localhost,root,,)
|
|
--echo # Connection 4 tries to rename the table:
|
|
send RENAME TABLE t3 TO t4;
|
|
|
|
--connection con1
|
|
--real_sleep 1
|
|
--echo # Connection 1 unlocks the table:
|
|
UNLOCK TABLES;
|
|
|
|
--connection con4
|
|
--echo # Connection 4 gets error on rename:
|
|
--reap
|
|
|
|
--connect (con5,localhost,root,,)
|
|
--echo # SHOW TABLES returns the table (not renamed):
|
|
SHOW TABLES;
|
|
--echo # Connection 5 attempts to read from the table (table does not exist):
|
|
--error ER_NO_SUCH_TABLE
|
|
SELECT * FROM t3;
|
|
DROP TABLE t4;
|
|
|
|
--disconnect con5
|
|
--disconnect con4
|
|
--disconnect con3
|
|
--disconnect con2
|
|
--disconnect con1
|
|
--connection default
|
|
# End of Test #3
|