Alexander Barkov 7f98714247
Bug#54916 GROUP_CONCAT + IFNULL truncates output ...
Problem: a few functions did not calculate their max_length correctly.
This is an after-fix for WL#2649 Number-to-string conversions".
Fix: changing the buggy functions to calculate max_length
using fix_char_length() introduced in WL#2649,
instead of setting max_length directly
mysql-test/include/ctype_numconv.inc
Adding new tests
mysql-test/r/ctype_binary.result
Adding new tests
mysql-test/r/ctype_cp1251.result
Adding new tests
mysql-test/r/ctype_latin1.result
Adding new tests
mysql-test/r/ctype_ucs.result
Adding new tests
mysql-test/r/ctype_utf8.result
Adding new tests
mysql-test/t/ctype_utf8.test
Including ctype_numconv
sql/item.h
- Introducing new method fix_char_length_ulonglong(),
for the cases when length is potentially greater
than UINT_MAX32. This method removes a few
instances of duplicate code, e.g. in item_strfunc.cc.
- Setting collation in Item_copy properly. This change
fixes wrong metadata on client side in some cases, when
"binary" instead of the real character set was reported.
sql/item_cmpfunc.cc
- Using fix_char_length() and max_char_length() methods,
instead of direct access to max_length, to calculate
item length properly.
- Moving count_only_length() in COALESCE after
agg_arg_charsets_for_string_result(). The old
order was incorrect and led to wrong length
calucation in case of multi-byte character sets.
sql/item_func.cc
Fixing that count_only_length() didn't work
properly for multi-byte character sets.
Using fix_char_length() and max_char_length()
instead of direct access to max_length.
sql/item_strfunc.cc
- Using fix_char_length(), fix_char_length_ulonglong(),
max_char_length() instead of direct access to max_length.
- Removing wierd condition: "if (collation.collation->mbmaxlen > 0)",
which is never FALSE.
2010-08-19 15:55:35 +04:00
2009-11-10 18:43:43 -02:00
2009-08-25 15:56:50 +02:00
2010-05-24 21:54:08 +08:00
2010-07-26 13:22:38 +04:00
2010-07-12 10:38:38 -03:00
2010-06-14 11:23:49 +02:00
2010-06-14 11:23:49 +02:00
2010-07-26 12:54:20 -03:00
2010-08-18 17:35:41 +08:00
2010-02-25 23:13:11 +04:00
2010-06-14 11:23:49 +02:00
2010-06-14 11:23:49 +02:00
2010-06-17 22:51:35 +02:00
2010-06-17 22:51:35 +02:00
2010-05-28 00:07:40 +04:00
2010-07-08 18:20:08 -03:00
2010-02-03 19:21:17 +03:00
2010-04-22 15:52:00 +02:00
2010-04-22 15:52:00 +02:00
2009-09-18 16:01:18 +03:00
2010-06-17 22:51:35 +02:00
2010-02-17 10:18:17 +01:00
2009-11-30 10:54:26 +05:30
2010-03-03 22:22:02 +03:00
2010-08-19 15:55:35 +04:00
2009-12-22 19:23:13 +03:00
2009-12-22 10:35:56 +01:00
2010-02-20 13:07:32 +03:00
2010-02-20 13:07:32 +03:00
2010-02-20 13:07:32 +03:00
2010-02-20 13:07:32 +03:00
2010-04-28 14:47:49 +02:00
2010-06-08 19:47:10 +02:00
2010-01-22 19:00:19 -07:00
2010-03-03 22:22:02 +03:00
2010-04-13 11:38:28 +02:00
2010-06-20 22:43:34 +02:00
2010-04-28 14:47:49 +02:00
2010-05-24 21:54:08 +08:00
2010-08-18 17:35:41 +08:00
2010-08-06 13:37:05 +02:00
2010-01-14 15:17:57 +04:00
2010-02-11 08:17:25 +04:00
2009-11-06 11:49:27 +01:00
2010-05-26 22:34:25 +08:00
2010-02-11 08:17:25 +04:00
2009-10-15 17:23:43 +05:00
2010-02-15 09:57:24 +04:00
2010-01-14 15:17:57 +04:00
2010-01-14 15:17:57 +04:00
2009-09-07 13:42:54 +08:00
2010-01-14 15:17:57 +04:00
2010-02-17 10:18:17 +01:00
2010-02-11 08:17:25 +04:00
2010-03-24 18:03:44 +03:00
2010-02-24 13:15:34 +04:00
2010-02-15 09:57:24 +04:00
2010-02-17 10:18:17 +01:00
2010-04-11 11:17:42 +04:00
2010-02-15 09:57:24 +04:00
2010-06-17 22:51:35 +02:00
2010-08-19 15:55:35 +04:00
2010-03-04 08:34:44 +01:00
2010-06-17 22:51:35 +02:00
2010-03-04 08:34:44 +01:00
2010-03-04 08:34:44 +01:00
2010-03-04 08:34:44 +01:00
2010-06-17 22:51:35 +02:00
2010-06-02 16:23:50 +04:00
2010-08-19 10:00:43 +04:00
2010-08-19 10:00:43 +04:00
2010-02-24 13:15:34 +04:00
2010-06-02 16:23:50 +04:00
2010-02-24 13:15:34 +04:00
2010-08-18 16:08:59 +04:00
2009-12-22 10:35:56 +01:00
2009-12-22 10:35:56 +01:00
2009-12-22 10:35:56 +01:00
2010-02-01 14:43:06 +03:00
2010-02-02 02:22:16 +03:00
2010-05-24 00:41:18 +04:00
2009-11-04 12:28:20 +00:00
2009-11-10 16:48:46 -02:00
2009-11-13 10:56:38 -02:00
2010-08-13 14:07:27 +04:00
2009-09-06 00:42:17 +04:00
2009-12-08 10:53:40 +03:00
2009-10-09 18:52:49 +04:00
2010-06-07 17:27:40 +02:00
2010-08-17 14:54:29 +03:00
2010-06-29 10:28:17 +02:00
2010-05-27 20:01:43 +04:00
2009-12-22 10:35:56 +01:00
2009-12-22 10:35:56 +01:00
2009-08-27 15:17:09 +02:00
2010-05-19 11:18:59 +02:00
2010-06-02 14:01:26 +04:00
2010-05-26 22:34:25 +08:00
2009-12-09 18:56:34 +03:00
2009-10-20 11:00:07 -07:00
2009-11-30 18:55:03 +03:00
2010-03-10 17:35:25 +03:00
2010-01-25 04:55:31 -07:00
2009-12-22 17:52:15 +02:00
2009-11-09 12:32:48 +01:00
2010-04-02 19:17:43 +04:00
2010-07-12 10:38:38 -03:00
2010-04-03 00:30:22 +04:00
2010-04-13 19:04:45 +04:00
2010-07-07 10:38:11 +04:00
2010-04-13 19:04:45 +04:00
2010-04-03 21:35:51 +04:00
2010-08-02 16:36:41 +04:00
2010-06-22 22:53:08 +04:00
2010-06-08 10:47:23 +04:00
2010-06-20 02:02:58 +04:00
2010-03-18 13:38:29 +03:00
2010-04-07 13:59:02 +04:00
2010-04-02 19:17:43 +04:00
2010-03-18 13:38:29 +03:00
2010-02-17 10:18:17 +01:00
2010-03-25 15:49:01 +04:00
2010-02-11 18:32:53 +01:00
2009-10-29 22:06:10 -07:00
2009-10-20 11:47:57 +05:30
2009-10-19 14:58:13 +02:00
2009-10-27 12:09:19 +04:00
2010-05-09 02:03:35 +04:00
2010-07-30 16:56:57 +03:00
2010-06-11 10:15:55 +02:00
2010-06-09 14:45:04 +04:00
2010-07-09 14:39:47 +04:00
2010-07-29 01:02:43 +04:00
2010-06-17 22:51:35 +02:00
2010-02-26 10:58:33 +01:00
2009-10-07 19:37:36 +04:00
2009-12-22 10:35:56 +01:00
2009-10-23 15:22:21 +04:00
2010-01-15 15:42:15 +04:00
2010-01-15 15:42:15 +04:00
2009-10-05 16:22:48 +02:00
2010-07-15 18:46:41 +03:00
2010-03-03 22:22:02 +03:00
2010-06-30 16:25:13 +01:00
2009-12-08 14:27:33 +01:00
2010-06-26 22:23:28 +02:00
2010-06-25 09:07:18 +02:00
2009-12-03 23:08:27 +03:00
2009-09-04 15:20:58 +02:00
2010-08-09 14:11:29 +02:00
2009-11-23 17:38:42 +01:00
2010-01-29 11:48:11 +01:00
2009-11-23 17:38:42 +01:00
2010-01-29 11:48:11 +01:00
2009-10-19 15:14:43 +02:00
2010-06-01 11:54:06 +04:00
2010-04-27 00:46:52 +04:00
2009-12-22 10:35:56 +01:00
2009-11-30 19:09:42 +03:00
2010-07-14 15:05:20 +03:00
2010-05-05 14:34:20 +04:00
2009-11-06 12:52:45 +03:00
2009-08-28 18:49:16 -03:00
2009-08-28 18:49:16 -03:00
2010-02-26 13:40:25 +01:00
2010-06-20 22:43:34 +02:00
2010-05-30 13:27:44 +04:00
2010-05-28 02:41:03 -05:00
2010-02-01 14:43:06 +03:00
2009-10-12 15:35:30 +02:00
2009-10-12 15:35:30 +02:00
2010-05-24 00:41:18 +04:00
2010-02-26 09:22:48 -03:00
2009-08-27 15:17:09 +02:00
2009-11-24 12:08:04 +01:00
2009-10-27 14:09:36 +04:00
2009-09-09 14:38:50 +05:00
2009-09-09 14:38:50 +05:00
2009-09-09 14:38:50 +05:00
2010-06-28 11:23:50 +02:00
2009-08-28 16:13:27 +02:00
2010-06-25 15:59:44 +03:00
2010-06-17 22:51:35 +02:00
2010-07-02 11:26:27 +02:00
2010-07-02 19:21:07 +04:00
2010-07-02 20:07:57 +04:00
2009-12-08 16:57:25 +03:00
2009-12-08 16:57:25 +03:00
2010-06-29 18:01:33 +04:00
2010-08-18 17:35:41 +08:00
2010-03-20 23:23:42 +03:00
2010-03-03 22:22:02 +03:00
2010-03-03 22:22:02 +03:00
2010-03-03 22:22:02 +03:00
2010-05-26 22:34:25 +08:00
2009-11-25 16:25:01 +04:00
2009-09-17 16:33:23 +05:00
2010-04-20 10:51:50 +02:00
2009-11-26 13:47:55 +01:00
2010-07-30 09:43:42 -03:00
2010-07-03 20:17:03 -03:00
2009-12-22 10:35:56 +01:00
2010-08-11 19:56:56 +02:00
2010-08-11 19:56:56 +02:00
2009-12-24 10:56:13 +03:00
2009-10-21 17:59:47 +05:00
2010-07-16 21:25:00 +03:00
2009-09-07 13:42:54 +08:00
2010-08-03 18:36:09 +08:00
2009-10-21 17:59:47 +05:00
2010-01-11 18:47:27 -07:00
2010-01-11 18:47:27 -07:00
2010-06-17 22:51:35 +02:00
2010-05-24 00:41:18 +04:00
2010-06-03 11:27:27 +02:00
2010-06-03 11:27:27 +02:00
2009-08-07 22:04:53 +02:00
2010-08-04 10:52:45 +02:00
2009-11-10 17:36:38 -02:00
2010-02-07 00:12:04 +00:00
2009-12-05 02:02:48 +03:00
2010-08-16 14:53:30 +02:00
2009-11-03 17:54:41 +04:00
2009-11-06 09:44:01 +03:00
2010-04-13 19:04:45 +04:00
2010-01-06 11:54:45 +01:00
2010-01-06 11:54:45 +01:00
2010-01-06 11:54:45 +01:00
2010-01-06 11:54:45 +01:00
2010-05-31 16:52:19 +04:00
2010-03-03 22:22:02 +03:00
2010-05-07 00:41:37 +04:00
2009-10-19 14:58:13 +02:00
2010-06-09 10:46:24 +02:00
2010-05-14 22:11:25 +04:00
2010-06-09 10:46:24 +02:00
2009-08-11 14:18:26 +02:00
2010-03-30 22:52:45 +02:00
2009-12-13 23:29:50 +03:00
2009-10-29 18:04:23 +01:00
2010-04-21 15:32:27 -07:00
2009-09-04 15:20:58 +02:00
2009-10-28 01:11:17 +01:00
2010-07-01 15:53:46 +02:00
2009-08-12 12:03:05 +02:00
2010-06-07 12:47:04 +04:00
2010-04-12 17:26:20 +03:00
2010-06-17 22:51:35 +02:00
2010-06-08 19:47:10 +02:00
2009-07-14 21:31:19 +02:00
2010-08-13 09:50:25 +02:00
2009-12-22 10:35:56 +01:00
2009-10-21 20:04:34 +02:00
2009-09-15 17:07:52 +02:00
2009-07-27 16:50:43 +05:30
2009-10-08 15:36:43 +02:00
2009-10-09 16:12:01 +02:00
2010-03-20 23:23:42 +03:00
2010-08-11 17:55:07 +02:00
2009-07-27 16:50:43 +05:30
2009-12-10 14:41:41 +01:00
2010-08-16 14:53:30 +02:00
2009-11-02 14:49:26 +01:00
2010-05-28 09:47:58 +04:00
2010-02-24 00:22:19 -07:00
2009-10-08 10:39:15 +02:00
2010-03-09 09:16:17 -03:00
2010-03-14 08:16:59 -03:00
2009-11-02 21:05:42 +01:00
2009-12-22 10:35:56 +01:00
2009-11-04 12:28:20 +00:00
2010-06-17 22:51:35 +02:00
2010-06-09 16:07:34 +04:00
2009-12-29 15:19:05 +03:00
2010-02-06 13:28:06 +03:00
2009-11-10 20:45:15 +02:00
2010-02-17 10:18:17 +01:00
2010-04-30 00:33:06 +04:00
2009-12-03 23:08:27 +03:00
2010-04-30 16:12:41 +04:00
2009-10-29 12:19:36 +01:00
2009-10-29 12:19:36 +01:00
2009-11-20 22:51:12 +03:00
2010-03-24 17:37:41 +01:00
2010-02-26 10:58:33 +01:00
2010-08-11 14:13:59 +02:00
2010-03-10 10:36:40 -03:00
2010-05-28 09:25:11 +04:00
2010-05-21 22:47:32 +04:00
2010-02-03 08:32:38 +03:00
2010-04-16 16:42:34 +05:00
2010-07-16 21:25:00 +03:00
2010-07-02 11:54:14 +02:00
2009-12-22 10:35:56 +01:00
2010-07-15 10:47:50 -03:00
2009-11-10 17:36:38 -02:00
2010-02-17 10:18:17 +01:00
2010-07-27 18:32:42 +04:00
2010-02-05 17:31:34 +01:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2010-07-30 19:28:36 +04:00
2010-06-23 00:32:29 +04:00
2010-04-03 21:35:51 +04:00
2010-02-24 16:52:27 +03:00
2010-06-07 11:06:55 +04:00
2010-07-04 20:35:05 +01:00
2010-05-07 20:28:59 +04:00
2010-02-13 08:35:14 -02:00
2010-07-30 19:28:36 +04:00
2010-03-03 10:24:53 +01:00
2010-07-30 19:28:36 +04:00
2010-04-19 15:35:13 +02:00
2009-10-29 10:51:04 -06:00
2009-11-27 18:10:28 +02:00
2009-12-16 21:02:21 +03:00
2009-10-09 15:34:07 +02:00
2010-07-30 19:28:36 +04:00
2009-10-09 16:52:02 +02:00
2010-07-28 12:59:19 -03:00
2010-04-13 19:04:45 +04:00
2010-04-13 19:04:45 +04:00
2010-04-13 19:04:45 +04:00
2010-04-13 19:04:45 +04:00
2010-04-13 19:04:45 +04:00
2009-08-27 15:17:09 +02:00
2009-12-03 23:08:27 +03:00
2010-06-17 22:51:35 +02:00
2010-03-18 13:38:29 +03:00
2010-01-04 10:39:42 +01:00
2010-08-05 15:34:19 +03:00
2010-06-25 16:32:47 +03:00
2010-04-01 18:49:02 +04:00
2009-11-04 12:28:20 +00:00
2009-11-04 12:28:20 +00:00
2009-11-04 12:28:20 +00:00
2010-06-23 13:34:40 +02:00
2009-11-30 18:55:03 +03:00
2010-08-18 17:35:41 +08:00
2010-06-11 17:32:12 +04:00
2010-05-25 17:01:38 -03:00
2010-02-16 13:13:49 +04:00
2009-12-02 18:50:14 +03:00
2010-03-20 23:23:42 +03:00
2010-05-05 13:28:37 +04:00
2010-05-28 17:30:39 +02:00
2009-12-22 19:23:13 +03:00
2010-03-18 13:38:29 +03:00
2010-05-31 13:38:10 +04:00
2010-03-09 15:54:12 +01:00
2009-10-09 15:34:07 +02:00
2010-03-22 12:33:25 +04:00
2010-03-24 18:03:44 +03:00
2010-02-17 10:18:17 +01:00
2010-08-18 17:35:41 +08:00
2010-07-19 11:03:52 +02:00
2010-05-21 22:47:32 +04:00
2009-12-22 10:35:56 +01:00
2010-05-05 15:00:59 +04:00
2010-02-23 16:26:45 +03:00
2010-05-24 00:41:18 +04:00
2010-07-27 14:25:53 +04:00
2010-03-09 07:36:26 -03:00
2010-02-24 16:52:27 +03:00
2010-06-06 13:19:29 +02:00
2009-11-13 10:17:53 +00:00
2010-07-03 20:17:03 -03:00
2010-03-24 18:03:44 +03:00
7f98714247