mirror of
				https://github.com/MariaDB/server.git
				synced 2025-10-31 15:50:51 +03:00 
			
		
		
		
	breaks SBR This pre-requisite patch refactors the code for dropping tables, used by DROP TABLE and DROP DATABASE. The patch moves the code for acquiring metadata locks out of mysql_rm_table_part2() and makes it the responsibility of the caller. This in preparation of changing the DROP DATABASE implementation to acquire all metadata locks before any changes are made. mysql_rm_table_part2() is renamed mysql_rm_table_no_locks() to reflect the change.
		
			
				
	
	
		
			66 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			66 lines
		
	
	
		
			2.5 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
| DROP TABLE IF EXISTS t1, t2;
 | |
| SET DEBUG_SYNC= 'RESET';
 | |
| #
 | |
| # Bug#42438: Crash ha_partition::change_table_ptr
 | |
| # Test when remove partitioning is done while drop table is waiting
 | |
| # for the table.
 | |
| # After MDL was introduced, there is no longer any race, so test is done
 | |
| # by adding a small sleep to verify that the delete waits.
 | |
| # Con 1
 | |
| SET DEBUG_SYNC= 'RESET';
 | |
| CREATE TABLE t1
 | |
| (a INTEGER,
 | |
| b INTEGER NOT NULL,
 | |
| KEY (b))
 | |
| ENGINE = MYISAM
 | |
| /*!50100  PARTITION BY RANGE (a)
 | |
| (PARTITION p0 VALUES LESS THAN (2),
 | |
| PARTITION p1 VALUES LESS THAN (20),
 | |
| PARTITION p2 VALUES LESS THAN (100),
 | |
| PARTITION p3 VALUES LESS THAN MAXVALUE ) */;
 | |
| SET SESSION debug= "+d,sleep_before_create_table_no_lock";
 | |
| SET DEBUG_SYNC= 'alter_table_before_create_table_no_lock SIGNAL removing_partitioning WAIT_FOR waiting_for_alter';
 | |
| SET DEBUG_SYNC= 'alter_table_before_main_binlog SIGNAL partitioning_removed';
 | |
| ALTER TABLE t1 REMOVE PARTITIONING;
 | |
| # Con default
 | |
| SET DEBUG_SYNC= 'now WAIT_FOR removing_partitioning';
 | |
| SET DEBUG_SYNC= 'mdl_acquire_lock_wait SIGNAL waiting_for_alter';
 | |
| SET DEBUG_SYNC= 'rm_table_no_locks_before_delete_table WAIT_FOR partitioning_removed';
 | |
| DROP TABLE IF EXISTS t1;
 | |
| # Con 1
 | |
| SET SESSION debug= "-d,sleep_before_create_table_no_lock";
 | |
| SET DEBUG_SYNC= 'RESET';
 | |
| SET DEBUG_SYNC= 'RESET';
 | |
| #
 | |
| # Bug#42438: Crash ha_partition::change_table_ptr
 | |
| # Test when remove partitioning is failing due to drop table is already
 | |
| # in progress.
 | |
| # After MDL was introduced, there is no longer any race, so test is done
 | |
| # by adding a small sleep to verify that the alter waits.
 | |
| CREATE TABLE t2
 | |
| (a INTEGER,
 | |
| b INTEGER NOT NULL,
 | |
| KEY (b))
 | |
| ENGINE = MYISAM
 | |
| /*!50100  PARTITION BY RANGE (a)
 | |
| (PARTITION p0 VALUES LESS THAN (2),
 | |
| PARTITION p1 VALUES LESS THAN (20),
 | |
| PARTITION p2 VALUES LESS THAN (100),
 | |
| PARTITION p3 VALUES LESS THAN MAXVALUE ) */;
 | |
| SET DEBUG_SYNC= 'alter_table_before_open_tables SIGNAL removing_partitions WAIT_FOR waiting_for_alter';
 | |
| SET DEBUG_SYNC= 'alter_table_before_rename_result_table WAIT_FOR delete_done';
 | |
| ALTER TABLE t2 REMOVE PARTITIONING;
 | |
| # Con default
 | |
| SET SESSION debug= "+d,sleep_before_no_locks_delete_table";
 | |
| SET DEBUG_SYNC= 'now WAIT_FOR removing_partitions';
 | |
| SET DEBUG_SYNC= 'rm_table_no_locks_before_delete_table SIGNAL waiting_for_alter';
 | |
| SET DEBUG_SYNC= 'rm_table_no_locks_before_binlog SIGNAL delete_done';
 | |
| DROP TABLE IF EXISTS t2;
 | |
| SET SESSION debug= "-d,sleep_before_no_locks_delete_table";
 | |
| # Con 1
 | |
| ERROR 42S02: Table 'test.t2' doesn't exist
 | |
| SET DEBUG_SYNC= 'RESET';
 | |
| # Con default
 | |
| SET DEBUG_SYNC= 'RESET';
 | |
| End of 5.1 tests
 |