mirror of
https://github.com/MariaDB/server.git
synced 2025-08-27 13:04:36 +03:00
33e5e125f5
Conflicts: - mysql-test/r/mysqld--help-win.result - sql/sys_vars.cc Original revsion (in next-mr-bugfixing): ------------------------------------------------------------ revno: 2971 [merge] revision-id: alfranio.correia@sun.com-20100121210527-rbuheu5rnsmcakh1 committer: Alfranio Correia <alfranio.correia@sun.com> branch nick: mysql-next-mr-bugfixing timestamp: Thu 2010-01-21 21:05:27 +0000 message: BUG#46364 MyISAM transbuffer problems (NTM problem) It is well-known that due to concurrency issues, a slave can become inconsistent when a transaction contains updates to both transaction and non-transactional tables. In a nutshell, the current code-base tries to preserve causality among the statements by writing non-transactional statements to the txn-cache which is flushed upon commit. However, modifications done to non-transactional tables on behalf of a transaction become immediately visible to other connections but may not immediately get into the binary log and therefore consistency may be broken. In general, it is impossible to automatically detect causality/dependency among statements by just analyzing the statements sent to the server. This happen because dependency may be hidden in the application code and it is necessary to know a priori all the statements processed in the context of a transaction such as in a procedure. Moreover, even for the few cases that we could automatically address in the server, the computation effort required could make the approach infeasible. So, in this patch we introduce the option - "--binlog-direct-non-transactional-updates" that can be used to bypass the current behavior in order to write directly to binary log statements that change non-transactional tables. Besides, it is used to enable the WL#2687 which is disabled by default. ------------------------------------------------------------ revno: 2970.1.1 revision-id: alfranio.correia@sun.com-20100121131034-183r4qdyld7an5a0 parent: alik@sun.com-20100121083914-r9rz2myto3tkdya0 committer: Alfranio Correia <alfranio.correia@sun.com> branch nick: mysql-next-mr-bugfixing timestamp: Thu 2010-01-21 13:10:34 +0000 message: BUG#46364 MyISAM transbuffer problems (NTM problem) It is well-known that due to concurrency issues, a slave can become inconsistent when a transaction contains updates to both transaction and non-transactional tables. In a nutshell, the current code-base tries to preserve causality among the statements by writing non-transactional statements to the txn-cache which is flushed upon commit. However, modifications done to non-transactional tables on behalf of a transaction become immediately visible to other connections but may not immediately get into the binary log and therefore consistency may be broken. In general, it is impossible to automatically detect causality/dependency among statements by just analyzing the statements sent to the server. This happen because dependency may be hidden in the application code and it is necessary to know a priori all the statements processed in the context of a transaction such as in a procedure. Moreover, even for the few cases that we could automatically address in the server, the computation effort required could make the approach infeasible. So, in this patch we introduce the option - "--binlog-direct-non-transactional-updates" that can be used to bypass the current behavior in order to write directly to binary log statements that change non-transactional tables. Besides, it is used to enable the WL#2687 which is disabled by default.
115 lines
2.4 KiB
Plaintext
115 lines
2.4 KiB
Plaintext
stop slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
reset master;
|
|
reset slave;
|
|
drop table if exists t1,t2,t3,t4,t5,t6,t7,t8,t9;
|
|
start slave;
|
|
call mtr.add_suppression("Unsafe statement binlogged in statement format since BINLOG_FORMAT = STATEMENT");
|
|
call mtr.add_suppression("Unsafe statement binlogged in statement format since BINLOG_FORMAT = STATEMENT");
|
|
SET @@session.binlog_direct_non_transactional_updates= FALSE;
|
|
DROP DATABASE IF EXISTS db1;
|
|
CREATE DATABASE db1;
|
|
use db1;
|
|
CREATE TABLE db1.t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE db1.t2 (s CHAR(255)) ENGINE=MyISAM;
|
|
include/stop_slave.inc
|
|
[on master]
|
|
CREATE PROCEDURE db1.p1 ()
|
|
BEGIN
|
|
INSERT INTO t1 VALUES (1);
|
|
INSERT INTO t1 VALUES (2);
|
|
INSERT INTO t1 VALUES (3);
|
|
INSERT INTO t1 VALUES (4);
|
|
INSERT INTO t1 VALUES (5);
|
|
END//
|
|
CREATE PROCEDURE db1.p2 ()
|
|
BEGIN
|
|
INSERT INTO t1 VALUES (6);
|
|
INSERT INTO t1 VALUES (7);
|
|
INSERT INTO t1 VALUES (8);
|
|
INSERT INTO t1 VALUES (9);
|
|
INSERT INTO t1 VALUES (10);
|
|
INSERT INTO t2 VALUES ('executed db1.p2()');
|
|
END//
|
|
INSERT INTO db1.t2 VALUES ('before call db1.p1()');
|
|
use test;
|
|
BEGIN;
|
|
CALL db1.p1();
|
|
COMMIT;
|
|
INSERT INTO db1.t2 VALUES ('after call db1.p1()');
|
|
SELECT * FROM db1.t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
SELECT * FROM db1.t2;
|
|
s
|
|
before call db1.p1()
|
|
after call db1.p1()
|
|
[on slave]
|
|
start slave until master_log_file='master-bin.000001', master_log_pos=MASTER_POS;
|
|
#
|
|
# If we got non-zero here, then we're suffering BUG#43263
|
|
#
|
|
SELECT 0 as 'Must be 0';
|
|
Must be 0
|
|
0
|
|
SELECT * from db1.t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
SELECT * from db1.t2;
|
|
s
|
|
before call db1.p1()
|
|
[on master]
|
|
INSERT INTO db1.t2 VALUES ('before call db1.p2()');
|
|
BEGIN;
|
|
CALL db1.p2();
|
|
Warnings:
|
|
Note 1592 Unsafe statement binlogged in statement format since BINLOG_FORMAT = STATEMENT. Reason for unsafeness: Non-transactional reads or writes are unsafe if they occur after transactional reads or writes inside a transaction.
|
|
ROLLBACK;
|
|
INSERT INTO db1.t2 VALUES ('after call db1.p2()');
|
|
SELECT * FROM db1.t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
SELECT * FROM db1.t2;
|
|
s
|
|
before call db1.p1()
|
|
after call db1.p1()
|
|
before call db1.p2()
|
|
executed db1.p2()
|
|
after call db1.p2()
|
|
[on slave]
|
|
start slave until master_log_file='master-bin.000001', master_log_pos=MASTER_POS;
|
|
#
|
|
# If we got non-zero here, then we're suffering BUG#43263
|
|
#
|
|
SELECT 0 as 'Must be 0';
|
|
Must be 0
|
|
0
|
|
SELECT * from db1.t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
4
|
|
5
|
|
SELECT * from db1.t2;
|
|
s
|
|
before call db1.p1()
|
|
executed db1.p2()
|
|
#
|
|
# Clean up
|
|
#
|
|
DROP DATABASE db1;
|
|
DROP DATABASE db1;
|