mirror of
https://github.com/MariaDB/server.git
synced 2025-12-01 17:39:21 +03:00
ea37b14409
This is joint work with Thirunarayanan Balathandayuthapani.
The MDL interface between InnoDB and the rest of the server
(in storage/innobase/dict/dict0dict.cc and in include/)
is my work, while most everything else is Thiru's.
The collection of InnoDB persistent statistics and the
defragmentation were not refactored to use MDL. They will
keep relying on lower-level interlocking with
fil_check_pending_operations().
The purge of transaction history and the background operations on
fulltext indexes will use MDL. We will revert
commit 2c4844c9e7
(MDEV-17813) because thanks to MDL, purge cannot conflict
with DDL operations anymore. For a similar reason, we will remove
the MDEV-16222 test case from gcol.innodb_virtual_debug_purge.
Purge is essentially replacing all use of the global dict_sys.latch
with MDL. Purge will skip the undo log records for tables whose names
start with #sql-ib or #sql2. Theoretically, such tables might
be renamed back to visible table names if TRUNCATE fails to
create a new table, or the final rename in ALTER TABLE...ALGORITHM=COPY
fails. In that case, purge could permanently leave some garbage
in the table. Such garbage will be tolerated; the table would not
be considered corrupted.
To avoid repeated MDL releases and acquisitions,
trx_purge_attach_undo_recs() will sort undo log records by table_id,
and purge_node_t will keep the MDL and table handle open for multiple
successive undo log records.
get_purge_table(): A new accessor, used during the purge of
history for indexed virtual columns. This interface should ideally
not exist at all.
thd_mdl_context(): Accessor of THD::mdl_context.
Wrapped in a new thd_mdl_service.
dict_get_db_name_len(): Define inline.
dict_acquire_mdl_shared(): Acquire explicit shared MDL on a table name
if needed.
dict_table_open_on_id(): Return MDL_ticket, if requested.
dict_table_close(): Release MDL ticket, if requested.
dict_fts_index_syncing(), dict_index_t::index_fts_syncing: Remove.
row_drop_table_for_mysql() no longer needs to check these, because
MDL guarantees that a fulltext index sync will not be in progress
while MDL_EXCLUSIVE is protecting a DDL operation.
dict_table_t::parse_name(): Parse the table name for acquiring MDL.
purge_node_t::undo_recs: Change the type to std::list<trx_purge_rec_t*>
(different container, and storing also roll_ptr).
purge_node_t: Add mdl_ticket, last_table_id, purge_thd, mdl_hold_recs
for acquiring MDL and for keeping the table open across multiple
undo log records.
purge_vcol_info_t, row_purge_store_vsec_cur(), row_purge_restore_vsec_cur():
Remove. We will acquire the MDL earlier.
purge_sys_t::heap: Added, for reading undo log records.
fts_sync_during_ddl(): Invoked during ALGORITHM=INPLACE operations
to ensure that fts_sync_table() will not conflict with MDL_EXCLUSIVE.
Uses fts_t::sync_message for bookkeeping.
209 lines
6.7 KiB
Plaintext
209 lines
6.7 KiB
Plaintext
set default_storage_engine=innodb;
|
|
set @old_dbug=@@global.debug_dbug;
|
|
SET @saved_frequency = @@GLOBAL.innodb_purge_rseg_truncate_frequency;
|
|
SET GLOBAL innodb_purge_rseg_truncate_frequency = 1;
|
|
CREATE TABLE `t` (
|
|
`a` BLOB,
|
|
`b` BLOB,
|
|
`c` BLOB GENERATED ALWAYS AS (CONCAT(a,b)) VIRTUAL,
|
|
`h` VARCHAR(10) DEFAULT NULL,
|
|
`i` int
|
|
) ENGINE=InnoDB;
|
|
INSERT INTO t VALUES (REPEAT('g', 16000), REPEAT('x', 16000), DEFAULT, "kk", 1);
|
|
INSERT INTO t VALUES (REPEAT('a', 16000), REPEAT('b', 16000), DEFAULT, "mm", 2);
|
|
CREATE INDEX idx ON t(c(100));
|
|
SET global debug_dbug="+d,ib_purge_virtual_index_callback";
|
|
UPDATE t SET a = REPEAT('m', 16000) WHERE a like "aaa%";
|
|
InnoDB 0 transactions not purged
|
|
SET global debug_dbug=@old_dbug;
|
|
DROP TABLE t;
|
|
CREATE TABLE t (
|
|
a TINYBLOB,
|
|
b TINYBLOB,
|
|
c TINYBLOB GENERATED ALWAYS AS (CONCAT(a,b)) VIRTUAL,
|
|
h VARCHAR(10) DEFAULT NULL,
|
|
i INT
|
|
) ROW_FORMAT=COMPACT ENGINE=InnoDB;
|
|
INSERT INTO t VALUES (REPEAT('g', 100), REPEAT('x', 100), DEFAULT, "kk", 1);
|
|
INSERT INTO t VALUES (REPEAT('a', 100), REPEAT('b', 100), DEFAULT, "mm", 2);
|
|
CREATE INDEX idx ON t(c(100));
|
|
SET global debug_dbug="+d,ib_purge_virtual_index_callback";
|
|
UPDATE t SET a = REPEAT('m', 100) WHERE a like "aaa%";
|
|
InnoDB 0 transactions not purged
|
|
SET global debug_dbug=@old_dbug;
|
|
DROP TABLE t;
|
|
CREATE TABLE t1 (
|
|
id INT NOT NULL,
|
|
store_id INT NOT NULL,
|
|
x INT GENERATED ALWAYS AS (id + store_id)
|
|
)
|
|
PARTITION BY RANGE (store_id) (
|
|
PARTITION p0 VALUES LESS THAN (6),
|
|
PARTITION p1 VALUES LESS THAN (11),
|
|
PARTITION p2 VALUES LESS THAN (16),
|
|
PARTITION p3 VALUES LESS THAN (21)
|
|
);
|
|
insert into t1 values(1, 2, default);
|
|
insert into t1 values(3, 4, default);
|
|
insert into t1 values(3, 12, default);
|
|
insert into t1 values(4, 18, default);
|
|
CREATE INDEX idx ON t1(x);
|
|
SET global debug_dbug="+d,ib_purge_virtual_index_callback";
|
|
UPDATE t1 SET id = 10 WHERE id = 1;
|
|
InnoDB 0 transactions not purged
|
|
SET global debug_dbug=@old_dbug;
|
|
DROP TABLE t1;
|
|
connect con1,localhost,root,,;
|
|
connection default;
|
|
CREATE TABLE t1 (a INT, b INT);
|
|
INSERT INTO t1(a, b) VALUES (1, 1), (2, 2), (3, 3);
|
|
connection con1;
|
|
# disable purge
|
|
CREATE TABLE t0 (a INT) ENGINE=InnoDB;
|
|
BEGIN;
|
|
SELECT * FROM t0;
|
|
a
|
|
connection default;
|
|
DELETE FROM t1 WHERE a = 1;
|
|
UPDATE t1 SET a = 4, b = 4 WHERE a = 3;
|
|
INSERT INTO t1(a, b) VALUES (5, 5);
|
|
SET DEBUG_SYNC= 'inplace_after_index_build SIGNAL uncommitted WAIT_FOR purged';
|
|
ALTER TABLE t1 ADD COLUMN c INT GENERATED ALWAYS AS(a+b), ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=NONE;
|
|
ERROR 0A000: LOCK=NONE is not supported. Reason: INPLACE ADD or DROP of virtual columns cannot be combined with other ALTER TABLE actions. Try LOCK=SHARED
|
|
ALTER TABLE t1 ADD COLUMN c INT GENERATED ALWAYS AS(a+b), ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=SHARED;
|
|
connection con1;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR uncommitted';
|
|
# enable purge
|
|
COMMIT;
|
|
# wait for purge to process the deleted records.
|
|
InnoDB 0 transactions not purged
|
|
SET DEBUG_SYNC= 'now SIGNAL purged';
|
|
connection default;
|
|
/* connection default */ ALTER TABLE t1 ADD COLUMN c INT GENERATED ALWAYS AS(a+b), ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=SHARED;
|
|
SHOW CREATE TABLE t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL,
|
|
`b` int(11) DEFAULT NULL,
|
|
`c` int(11) GENERATED ALWAYS AS (`a` + `b`) VIRTUAL,
|
|
KEY `idx` (`c`)
|
|
) ENGINE=InnoDB DEFAULT CHARSET=latin1
|
|
SELECT * FROM t1;
|
|
a b c
|
|
2 2 4
|
|
4 4 8
|
|
5 5 10
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (a INT, b INT, c INT GENERATED ALWAYS AS(a+b));
|
|
INSERT INTO t1(a, b) VALUES (1, 1), (2, 2), (3, 3), (4, 4);
|
|
connection con1;
|
|
# disable purge
|
|
BEGIN;
|
|
SELECT * FROM t0;
|
|
a
|
|
connection default;
|
|
DELETE FROM t1 WHERE a = 1;
|
|
UPDATE t1 SET a = 2, b = 2 WHERE a = 5;
|
|
INSERT INTO t1(a, b) VALUES (6, 6);
|
|
SET DEBUG_SYNC= 'inplace_after_index_build SIGNAL uncommitted WAIT_FOR purged';
|
|
ALTER TABLE t1 ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=NONE;
|
|
connection con1;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR uncommitted';
|
|
DELETE FROM t1 WHERE a = 3;
|
|
UPDATE t1 SET a = 7, b = 7 WHERE a = 4;
|
|
INSERT INTO t1(a, b) VALUES (8, 8);
|
|
# enable purge
|
|
COMMIT;
|
|
# wait for purge to process the deleted/updated records.
|
|
InnoDB 2 transactions not purged
|
|
SET DEBUG_SYNC= 'now SIGNAL purged';
|
|
disconnect con1;
|
|
connection default;
|
|
/* connection default */ ALTER TABLE t1 ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=NONE;
|
|
SHOW CREATE TABLE t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) DEFAULT NULL,
|
|
`b` int(11) DEFAULT NULL,
|
|
`c` int(11) GENERATED ALWAYS AS (`a` + `b`) VIRTUAL,
|
|
KEY `idx` (`c`)
|
|
) ENGINE=InnoDB DEFAULT CHARSET=latin1
|
|
SELECT * FROM t1;
|
|
a b c
|
|
2 2 4
|
|
7 7 14
|
|
6 6 12
|
|
8 8 16
|
|
DROP TABLE t0, t1;
|
|
create table t (a blob, b blob, c blob as (concat(a,b)), h varchar(10), index (c(100)));
|
|
insert t(a,b,h) values (repeat('g', 16000), repeat('x', 16000), "kk");
|
|
insert t(a,b,h) values (repeat('a', 16000), repeat('b', 16000), "mm");
|
|
set global debug_dbug="+d,ib_purge_virtual_index_callback";
|
|
connect prevent_purge, localhost, root;
|
|
start transaction with consistent snapshot;
|
|
connection default;
|
|
update t set a = repeat('m', 16000) where a like "aaa%";
|
|
connect lock_table, localhost, root;
|
|
lock table t write;
|
|
connection prevent_purge;
|
|
commit;
|
|
connection default;
|
|
InnoDB 0 transactions not purged
|
|
disconnect lock_table;
|
|
start transaction with consistent snapshot;
|
|
commit;
|
|
InnoDB 0 transactions not purged
|
|
set global debug_dbug=@old_dbug;
|
|
drop table t;
|
|
#
|
|
# MDEV-15165 InnoDB purge for index on virtual column
|
|
# is trying to access an incomplete record
|
|
#
|
|
CREATE TABLE t1(
|
|
u INT PRIMARY KEY, b BLOB, ug INT GENERATED ALWAYS AS (u) VIRTUAL,
|
|
INDEX bug(b(100),ug)
|
|
) ENGINE=InnoDB;
|
|
INSERT INTO t1 (u,b) VALUES(1,REPEAT('a',16384));
|
|
connection prevent_purge;
|
|
start transaction with consistent snapshot;
|
|
connection default;
|
|
DELETE FROM t1;
|
|
SET DEBUG_SYNC='blob_write_middle SIGNAL halfway WAIT_FOR purged';
|
|
INSERT INTO t1 (u,b) VALUES(1,REPEAT('a',16384));
|
|
connection prevent_purge;
|
|
SET DEBUG_SYNC='now WAIT_FOR halfway';
|
|
COMMIT;
|
|
InnoDB 0 transactions not purged
|
|
SET DEBUG_SYNC='now SIGNAL purged';
|
|
connection default;
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (y YEAR, vy YEAR AS (y) VIRTUAL UNIQUE, pk INT PRIMARY KEY)
|
|
ENGINE=InnoDB;
|
|
INSERT INTO t1 (pk,y) VALUES (1,2022);
|
|
CREATE TABLE t2(f1 INT NOT NULL, PRIMARY KEY(f1))ENGINE=InnoDB;
|
|
SET GLOBAL debug_dbug = '+d,ib_purge_virtual_index_callback';
|
|
BEGIN;
|
|
INSERT INTO t2(f1) VALUES(1);
|
|
connection prevent_purge;
|
|
SET DEBUG_SYNC=RESET;
|
|
start transaction with consistent snapshot;
|
|
connection default;
|
|
COMMIT;
|
|
connect truncate,localhost,root,,;
|
|
REPLACE INTO t1(pk, y) SELECT pk,y FROM t1;
|
|
TRUNCATE TABLE t1;
|
|
connection prevent_purge;
|
|
COMMIT;
|
|
SET DEBUG_SYNC='now SIGNAL purge_start';
|
|
disconnect prevent_purge;
|
|
connection default;
|
|
SET DEBUG_SYNC='now WAIT_FOR purge_start';
|
|
InnoDB 0 transactions not purged
|
|
SET GLOBAL debug_dbug=@old_dbug;
|
|
connection truncate;
|
|
disconnect truncate;
|
|
connection default;
|
|
DROP TABLE t1, t2;
|
|
set debug_sync=reset;
|
|
SET GLOBAL innodb_purge_rseg_truncate_frequency = @saved_frequency;
|