mirror of
https://github.com/MariaDB/server.git
synced 2025-12-13 20:03:16 +03:00
9ba731c299
transaction BUG#52616 Temp table prevents switch binlog format from STATEMENT to ROW Before the WL#2687 and BUG#46364, every non-transactional change that happened after a transactional change was written to trx-cache and flushed upon committing the transaction. WL#2687 and BUG#46364 changed this behavior and non-transactional changes are now written to the binary log upon committing the statement. A binary log event is identified as transactional or non-transactional through a flag in the Log_event which is set taking into account the underlie storage engine on what it is stems from. In the current bug, this flag was not being set properly when the DROP TEMPORARY TABLE was executed. However, while fixing this bug we figured out that changes to temporary tables should be always written to the trx-cache if there is an on-going transaction. Otherwise, binlog events in the reversed order would be produced. Regarding concurrency, keeping changes to temporary tables in the trx-cache is also safe as temporary tables are only visible to the owner connection. In this patch, we classify the following statements as unsafe: 1 - INSERT INTO t_myisam SELECT * FROM t_myisam_temp 2 - INSERT INTO t_myisam_temp SELECT * FROM t_myisam 3 - CREATE TEMPORARY TABLE t_myisam_temp SELECT * FROM t_myisam On the other hand, the following statements are classified as safe: 1 - INSERT INTO t_innodb SELECT * FROM t_myisam_temp 2 - INSERT INTO t_myisam_temp SELECT * FROM t_innodb The patch also guarantees that transactions that have a DROP TEMPORARY are always written to the binary log regardless of the mode and the outcome: commit or rollback. In particular, the DROP TEMPORARY is extended with the IF EXISTS clause when the current statement logging format is set to row. Finally, the patch allows to switch from STATEMENT to MIXED/ROW when there are temporary tables but the contrary is not possible.
62 lines
2.6 KiB
Plaintext
62 lines
2.6 KiB
Plaintext
CREATE TABLE t1 (i int unique) ENGINE=innodb;
|
|
reset master;
|
|
begin;
|
|
insert into t1 values (1),(2);
|
|
*** the following UPDATE query wont generate any updates for the binlog ***
|
|
update t1 set i = 3 where i < 3;
|
|
ERROR 23000: Duplicate entry '3' for key 'i'
|
|
commit;
|
|
*** Results of the test: the binlog must have only Write_rows events not any Update_rows ***
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Table_map # # table_id: # (test.t1)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
delete from t1;
|
|
reset master;
|
|
begin;
|
|
insert into t1 values (1),(2);
|
|
*** the following UPDATE query wont generate any updates for the binlog ***
|
|
insert into t1 values (3),(4),(1),(2);
|
|
ERROR 23000: Duplicate entry '1' for key 'i'
|
|
commit;
|
|
*** Results of the test: the binlog must have only one Write_rows event not two ***
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Table_map # # table_id: # (test.t1)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
drop table t1;
|
|
RESET MASTER;
|
|
CREATE TABLE t1 ( c1 int , primary key (c1)) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (1), (2), (3);
|
|
CREATE TEMPORARY TABLE IF NOT EXISTS t2 LIKE t1;
|
|
TRUNCATE TABLE t2;
|
|
DROP TABLE t1;
|
|
###############################################
|
|
### assertion: No event for 'TRUNCATE TABLE t2'
|
|
###############################################
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; CREATE TABLE t1 ( c1 int , primary key (c1)) ENGINE=InnoDB
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Table_map # # table_id: # (test.t1)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
master-bin.000001 # Query # # use `test`; DROP TABLE t1
|
|
###############################################
|
|
RESET MASTER;
|
|
CREATE TEMPORARY TABLE t1 (c1 int) Engine=InnoDB;
|
|
INSERT INTO t1 VALUES (1), (2), (3);
|
|
TRUNCATE t1;
|
|
DROP TEMPORARY TABLE t1;
|
|
###############################################
|
|
### assertion: No event for 'TRUNCATE TABLE t1'
|
|
###############################################
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; DROP TEMPORARY TABLE IF EXISTS `t1` /* generated by server */
|
|
###############################################
|