mirror of
https://github.com/MariaDB/server.git
synced 2025-07-30 16:24:05 +03:00
69a4d6ae61
Previously, the behavior was to error out on the first invalid option encountered. With this change, a best effort approach is made so that all invalid options processed will be printed before exiting. There is a caveat. The options are processed many times at varying stages of server startup because the server is not aware of all valid options immediately (e.g. plugins have to be loaded first before the server knows what are the available plugin options). So, there are some options that the server can determine are invalid "early" on, and there are some options that the server cannot determine are invalid until "later" on. For example, the server can determine an option such as `--a` is an ambiguous option very early on but an option such as `--this-does-not-match-any-option` cannot be labelled as invalid until the server is aware of all available options. Thus, it is possible that the server will still fail before printing out all "invalid" options. You can see this by passing `--a --obvious-invalid-option`. Test cases were added to `mysqld_option_err.test` to validate that multiple invalid options will be displayed in the error message. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services.
74 lines
3.6 KiB
Plaintext
74 lines
3.6 KiB
Plaintext
#
|
|
# Test error checks on mysqld command line option parsing.
|
|
#
|
|
# Call mysqld with different invalid options, and check that it fails in each case.
|
|
#
|
|
# This means that a test failure results in mysqld starting up, which is only
|
|
# caught when the test case times out. This is not ideal, but I did not find an
|
|
# easy way to have the server shut down after a successful startup.
|
|
#
|
|
|
|
--source include/not_embedded.inc
|
|
|
|
# mysqld refuses to run as root normally.
|
|
-- source include/not_as_root.inc
|
|
|
|
# We have not run (and do not need) bootstrap of the server. We just
|
|
# give it a dummy data directory (for log files etc).
|
|
|
|
mkdir $MYSQLTEST_VARDIR/tmp/mysqld_option_err;
|
|
|
|
|
|
--echo Test that unknown option is not silently ignored.
|
|
--error 2
|
|
--exec $MYSQLD_BOOTSTRAP_CMD --skip-networking --datadir=$MYSQLTEST_VARDIR/tmp/mysqld_option_err --skip-grant-tables --nonexistentoption >$MYSQLTEST_VARDIR/tmp/mysqld_option_err/mysqltest.log 2>&1
|
|
|
|
|
|
--echo Test bad binlog format.
|
|
--error 1
|
|
--exec $MYSQLD_BOOTSTRAP_CMD --skip-networking --datadir=$MYSQLTEST_VARDIR/tmp/mysqld_option_err --skip-grant-tables --log-bin --binlog-format=badformat >>$MYSQLTEST_VARDIR/tmp/mysqld_option_err/mysqltest.log 2>&1
|
|
|
|
|
|
--echo Test bad default storage engine.
|
|
--error 1
|
|
--exec $MYSQLD_BOOTSTRAP_CMD --skip-networking --datadir=$MYSQLTEST_VARDIR/tmp/mysqld_option_err --skip-grant-tables --default-storage-engine=nonexistentengine >>$MYSQLTEST_VARDIR/tmp/mysqld_option_err/mysqltest.log 2>&1
|
|
|
|
|
|
--echo Test non-numeric value passed to number option.
|
|
--error 1
|
|
--exec $MYSQLD_BOOTSTRAP_CMD --skip-networking --datadir=$MYSQLTEST_VARDIR/tmp/mysqld_option_err --skip-grant-tables --min-examined-row-limit=notanumber >>$MYSQLTEST_VARDIR/tmp/mysqld_option_err/mysqltest.log 2>&1
|
|
|
|
|
|
# Test for MBug#423035: error in parsing enum value for plugin
|
|
# variable in mysqld command-line option.
|
|
# See also Bug#32034.
|
|
--echo Test that bad value for plugin enum option is rejected correctly.
|
|
--error 7
|
|
--exec $MYSQLD_BOOTSTRAP_CMD --skip-networking --datadir=$MYSQLTEST_VARDIR/tmp/mysqld_option_err --skip-grant-tables --plugin-dir=$MYSQLTEST_VARDIR/plugins --plugin-load=example=ha_example.so --plugin-example-enum-var=noexist >>$MYSQLTEST_VARDIR/tmp/mysqld_option_err/mysqltest.log 2>&1
|
|
|
|
--echo Test to see if multiple unknown options will be displayed in the error output
|
|
# Remove the noise to make the test robust
|
|
--replace_regex /^((?!nonexistent).)*$// /.*unknown/unknown/
|
|
--error 7
|
|
--exec $MYSQLD_BOOTSTRAP_CMD --skip-networking --datadir=$MYSQLTEST_VARDIR/tmp/mysqld_option_err --skip-grant-tables --nonexistentoption --alsononexistent --nonexistentvariable=1 2>&1
|
|
|
|
--echo Test to see if multiple ambiguous options and invalid arguments will be displayed in the error output
|
|
# Remove the noise to make the test robust
|
|
--replace_regex /^((?!('sql_mode'|'--character'|'--bootstrap')).)*$// /.*Error while setting value/Error while setting value/ /.*ambiguous option/ambiguous option/ /.*option '--bootstrap'/option '--bootstrap'/
|
|
--error 1
|
|
--exec $MYSQLD_BOOTSTRAP_CMD --skip-networking --datadir=$MYSQLTEST_VARDIR/tmp/mysqld_option_err --skip-grant-tables --getopt-prefix-matching --sql-mode=invalid_value --character --bootstrap=partstoob 2>&1
|
|
|
|
#
|
|
# Test that an wrong option with --help --verbose gives an error
|
|
#
|
|
|
|
--echo Test that --help --verbose works
|
|
--exec $MYSQLD_BOOTSTRAP_CMD --help --verbose >>$MYSQLTEST_VARDIR/tmp/mysqld_option_err/mysqltest.log 2>&1
|
|
--echo Test that --not-known-option --help --verbose gives error
|
|
--error 2
|
|
--exec $MYSQLD_BOOTSTRAP_CMD --not-known-option --help --verbose >>$MYSQLTEST_VARDIR/tmp/mysqld_option_err/mysqltest.log 2>&1
|
|
|
|
rmdir $MYSQLTEST_VARDIR/tmp/mysqld_option_err;
|
|
|
|
--echo Done.
|