mirror of
https://github.com/MariaDB/server.git
synced 2025-11-27 05:41:41 +03:00
afbac0070f
causing wrong error message in Falcon
An error message about a duplicate key could show a wrong key
value when not all columns of the key were used to select the
rows for update.
Some storage engines return a record with only the selected
columns filled.
This is fixed by re-reading the record with a read_set which
includes all columns of the duplicate key after a duplicate key
error happens and before the error message is printed.
mysql-test/r/ndb_update.result:
Bug#28158 - table->read_set is set incorrectly,
causing wrong error message in Falcon
Added test result.
mysql-test/t/ndb_update.test:
Bug#28158 - table->read_set is set incorrectly,
causing wrong error message in Falcon
Added test from falcon_bug_28158.
sql/sql_update.cc:
Bug#28158 - table->read_set is set incorrectly,
causing wrong error message in Falcon
Added a function for re-reading a record with a read_set
that contains all fields used by a duplicate key.
Called the function before every call to handler::print_error(),
which could print a duplicate key value.
90 lines
2.0 KiB
Plaintext
90 lines
2.0 KiB
Plaintext
-- source include/have_ndb.inc
|
|
-- source include/not_embedded.inc
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
DROP TABLE IF EXISTS t2;
|
|
DROP TABLE IF EXISTS t3;
|
|
--enable_warnings
|
|
|
|
#
|
|
# Basic test of UPDATE in NDB
|
|
#
|
|
|
|
#
|
|
# Create a normal table with primary key
|
|
#
|
|
CREATE TABLE t1 (
|
|
pk1 INT NOT NULL PRIMARY KEY,
|
|
b INT NOT NULL,
|
|
c INT NOT NULL UNIQUE
|
|
) ENGINE=ndbcluster;
|
|
|
|
INSERT INTO t1 VALUES (0, 1, 0),(1,2,1),(2,3,2);
|
|
UPDATE t1 set b = c;
|
|
select * from t1 order by pk1;
|
|
UPDATE t1 set pk1 = 4 where pk1 = 1;
|
|
select * from t1 order by pk1;
|
|
--error ER_DUP_ENTRY
|
|
UPDATE t1 set pk1 = 4 where pk1 = 2;
|
|
UPDATE IGNORE t1 set pk1 = 4 where pk1 = 2;
|
|
select * from t1 order by pk1;
|
|
--error ER_DUP_ENTRY
|
|
UPDATE t1 set pk1 = 1, c = 2 where pk1 = 4;
|
|
UPDATE IGNORE t1 set pk1 = 1, c = 2 where pk1 = 4;
|
|
select * from t1 order by pk1;
|
|
UPDATE t1 set pk1 = pk1 + 10;
|
|
select * from t1 order by pk1;
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
--enable_warnings
|
|
|
|
# End of 4.1 tests
|
|
|
|
#
|
|
# Bug#28158: table->read_set is set incorrectly,
|
|
# causing wrong error message in Falcon
|
|
#
|
|
CREATE TABLE t1 (a int, b int, KEY (a, b)) ENGINE=ndbcluster;
|
|
CREATE TABLE t2 (a int, b int, UNIQUE KEY (a, b)) ENGINE=ndbcluster;
|
|
CREATE TABLE t3 (a int, b int, PRIMARY KEY (a, b)) ENGINE=ndbcluster;
|
|
#
|
|
INSERT INTO t1 VALUES (1, 2);
|
|
INSERT INTO t1 VALUES (2, 2);
|
|
#
|
|
INSERT INTO t2 VALUES (1, 2);
|
|
INSERT INTO t2 VALUES (2, 2);
|
|
#
|
|
INSERT INTO t3 VALUES (1, 2);
|
|
INSERT INTO t3 VALUES (2, 2);
|
|
#
|
|
UPDATE t1 SET a = 1;
|
|
UPDATE t1 SET a = 1 ORDER BY a;
|
|
#
|
|
--error ER_DUP_ENTRY
|
|
UPDATE t2 SET a = 1;
|
|
--error ER_DUP_ENTRY
|
|
UPDATE t2 SET a = 1 ORDER BY a;
|
|
#
|
|
--error ER_DUP_ENTRY
|
|
UPDATE t3 SET a = 1;
|
|
--error ER_DUP_ENTRY
|
|
UPDATE t3 SET a = 1 ORDER BY a;
|
|
#
|
|
SELECT count(*) FROM t1;
|
|
SELECT count(*) FROM t2;
|
|
SELECT count(*) FROM t3;
|
|
SELECT * FROM t1 ORDER by a;
|
|
SELECT * FROM t2 ORDER by a;
|
|
SELECT * FROM t3 ORDER by a;
|
|
#
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
DROP TABLE IF EXISTS t2;
|
|
DROP TABLE IF EXISTS t3;
|
|
--enable_warnings
|
|
|
|
--echo End of 5.1 tests
|
|
|