mirror of
https://github.com/MariaDB/server.git
synced 2025-11-30 05:23:50 +03:00
6ba5f81c7d
So we are having a race condition of three of threads, resulting in a deadlock backoff in purge, which is unexpected. More precisely, the following happens: T1: NOCOPY ALTER TABLE begins, and eventually it holds MDL_SHARED_NO_WRITE lock; T2: FLUSH TABLES begins. it sets share->tdc->flushed = true T3: purge on a record with virtual column begins. it is going to open a table. MDL_SHARED_READ lock is acquired therefore. Since share->tdc->flushed is set, it waits for a TDC purge end. T1: is going to elevate MDL LOCK to exclusive and therefore has to set other waiters to back off. T3: receives VICTIM status, reports a DEADLOCK, sets OT_BACKOFF_AND_RETRY to Open_table_context::m_action My fix is to allow opening table in purge while flushing. It is already done the same way in other maintainance facilities like REPAIR TABLE. Another way would be making an actual backoff, but Open_table_context does not allow to distinguish it from other failure types, which still seem to be unexpected. Making this would require hacking into Open_table_context interface for no benefit, in comparison to passing MYSQL_OPEN_IGNORE_FLUSH during table open.
308 lines
10 KiB
Plaintext
308 lines
10 KiB
Plaintext
set default_storage_engine=innodb;
|
||
set @old_dbug=@@global.debug_dbug;
|
||
SET @saved_frequency = @@GLOBAL.innodb_purge_rseg_truncate_frequency;
|
||
SET GLOBAL innodb_purge_rseg_truncate_frequency = 1;
|
||
CREATE TABLE `t` (
|
||
`a` BLOB,
|
||
`b` BLOB,
|
||
`c` BLOB GENERATED ALWAYS AS (CONCAT(a,b)) VIRTUAL,
|
||
`h` VARCHAR(10) DEFAULT NULL,
|
||
`i` int
|
||
) ENGINE=InnoDB;
|
||
INSERT INTO t VALUES (REPEAT('g', 16000), REPEAT('x', 16000), DEFAULT, "kk", 1);
|
||
INSERT INTO t VALUES (REPEAT('a', 16000), REPEAT('b', 16000), DEFAULT, "mm", 2);
|
||
CREATE INDEX idx ON t(c(100));
|
||
SET global debug_dbug="d,ib_purge_virtual_index_callback";
|
||
UPDATE t SET a = REPEAT('m', 16000) WHERE a like "aaa%";
|
||
InnoDB 0 transactions not purged
|
||
SET global debug_dbug=@old_dbug;
|
||
DROP TABLE t;
|
||
CREATE TABLE t (
|
||
a TINYBLOB,
|
||
b TINYBLOB,
|
||
c TINYBLOB GENERATED ALWAYS AS (CONCAT(a,b)) VIRTUAL,
|
||
h VARCHAR(10) DEFAULT NULL,
|
||
i INT
|
||
) ROW_FORMAT=COMPACT ENGINE=InnoDB;
|
||
INSERT INTO t VALUES (REPEAT('g', 100), REPEAT('x', 100), DEFAULT, "kk", 1);
|
||
INSERT INTO t VALUES (REPEAT('a', 100), REPEAT('b', 100), DEFAULT, "mm", 2);
|
||
CREATE INDEX idx ON t(c(100));
|
||
SET global debug_dbug="d,ib_purge_virtual_index_callback";
|
||
UPDATE t SET a = REPEAT('m', 100) WHERE a like "aaa%";
|
||
InnoDB 0 transactions not purged
|
||
SET global debug_dbug=@old_dbug;
|
||
DROP TABLE t;
|
||
CREATE TABLE t1 (
|
||
id INT NOT NULL,
|
||
store_id INT NOT NULL,
|
||
x INT GENERATED ALWAYS AS (id + store_id)
|
||
)
|
||
PARTITION BY RANGE (store_id) (
|
||
PARTITION p0 VALUES LESS THAN (6),
|
||
PARTITION p1 VALUES LESS THAN (11),
|
||
PARTITION p2 VALUES LESS THAN (16),
|
||
PARTITION p3 VALUES LESS THAN (21)
|
||
);
|
||
insert into t1 values(1, 2, default);
|
||
insert into t1 values(3, 4, default);
|
||
insert into t1 values(3, 12, default);
|
||
insert into t1 values(4, 18, default);
|
||
CREATE INDEX idx ON t1(x);
|
||
SET global debug_dbug="d,ib_purge_virtual_index_callback";
|
||
UPDATE t1 SET id = 10 WHERE id = 1;
|
||
InnoDB 0 transactions not purged
|
||
SET global debug_dbug=@old_dbug;
|
||
DROP TABLE t1;
|
||
connect con1,localhost,root,,;
|
||
connection default;
|
||
CREATE TABLE t1 (a INT, b INT);
|
||
INSERT INTO t1(a, b) VALUES (1, 1), (2, 2), (3, 3);
|
||
connection con1;
|
||
# disable purge
|
||
CREATE TABLE t0 (a INT) ENGINE=InnoDB;
|
||
BEGIN;
|
||
SELECT * FROM t0;
|
||
a
|
||
connection default;
|
||
DELETE FROM t1 WHERE a = 1;
|
||
UPDATE t1 SET a = 4, b = 4 WHERE a = 3;
|
||
INSERT INTO t1(a, b) VALUES (5, 5);
|
||
SET DEBUG_SYNC= 'inplace_after_index_build SIGNAL uncommitted WAIT_FOR purged';
|
||
ALTER TABLE t1 ADD COLUMN c INT GENERATED ALWAYS AS(a+b), ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=NONE;
|
||
ERROR 0A000: LOCK=NONE is not supported. Reason: INPLACE ADD or DROP of virtual columns cannot be combined with other ALTER TABLE actions. Try LOCK=SHARED
|
||
ALTER TABLE t1 ADD COLUMN c INT GENERATED ALWAYS AS(a+b), ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=SHARED;
|
||
connection con1;
|
||
SET DEBUG_SYNC= 'now WAIT_FOR uncommitted';
|
||
# enable purge
|
||
COMMIT;
|
||
# wait for purge to process the deleted records.
|
||
InnoDB 0 transactions not purged
|
||
SET DEBUG_SYNC= 'now SIGNAL purged';
|
||
connection default;
|
||
/* connection default */ ALTER TABLE t1 ADD COLUMN c INT GENERATED ALWAYS AS(a+b), ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=SHARED;
|
||
SHOW CREATE TABLE t1;
|
||
Table Create Table
|
||
t1 CREATE TABLE `t1` (
|
||
`a` int(11) DEFAULT NULL,
|
||
`b` int(11) DEFAULT NULL,
|
||
`c` int(11) GENERATED ALWAYS AS (`a` + `b`) VIRTUAL,
|
||
KEY `idx` (`c`)
|
||
) ENGINE=InnoDB DEFAULT CHARSET=latin1
|
||
SELECT * FROM t1;
|
||
a b c
|
||
2 2 4
|
||
4 4 8
|
||
5 5 10
|
||
DROP TABLE t1;
|
||
CREATE TABLE t1 (a INT, b INT, c INT GENERATED ALWAYS AS(a+b));
|
||
INSERT INTO t1(a, b) VALUES (1, 1), (2, 2), (3, 3), (4, 4);
|
||
connection con1;
|
||
# disable purge
|
||
BEGIN;
|
||
SELECT * FROM t0;
|
||
a
|
||
connection default;
|
||
DELETE FROM t1 WHERE a = 1;
|
||
UPDATE t1 SET a = 2, b = 2 WHERE a = 5;
|
||
INSERT INTO t1(a, b) VALUES (6, 6);
|
||
SET DEBUG_SYNC= 'inplace_after_index_build SIGNAL uncommitted WAIT_FOR purged';
|
||
ALTER TABLE t1 ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=NONE;
|
||
connection con1;
|
||
SET DEBUG_SYNC= 'now WAIT_FOR uncommitted';
|
||
DELETE FROM t1 WHERE a = 3;
|
||
UPDATE t1 SET a = 7, b = 7 WHERE a = 4;
|
||
INSERT INTO t1(a, b) VALUES (8, 8);
|
||
# enable purge
|
||
COMMIT;
|
||
# wait for purge to process the deleted/updated records.
|
||
InnoDB 1 transactions not purged
|
||
SET DEBUG_SYNC= 'now SIGNAL purged';
|
||
disconnect con1;
|
||
connection default;
|
||
/* connection default */ ALTER TABLE t1 ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=NONE;
|
||
SHOW CREATE TABLE t1;
|
||
Table Create Table
|
||
t1 CREATE TABLE `t1` (
|
||
`a` int(11) DEFAULT NULL,
|
||
`b` int(11) DEFAULT NULL,
|
||
`c` int(11) GENERATED ALWAYS AS (`a` + `b`) VIRTUAL,
|
||
KEY `idx` (`c`)
|
||
) ENGINE=InnoDB DEFAULT CHARSET=latin1
|
||
SELECT * FROM t1;
|
||
a b c
|
||
2 2 4
|
||
7 7 14
|
||
6 6 12
|
||
8 8 16
|
||
DROP TABLE t0, t1;
|
||
create table t (a blob, b blob, c blob as (concat(a,b)), h varchar(10), index (c(100)));
|
||
insert t(a,b,h) values (repeat('g', 16000), repeat('x', 16000), "kk");
|
||
insert t(a,b,h) values (repeat('a', 16000), repeat('b', 16000), "mm");
|
||
set global debug_dbug="d,ib_purge_virtual_index_callback";
|
||
connect prevent_purge, localhost, root;
|
||
start transaction with consistent snapshot;
|
||
connection default;
|
||
update t set a = repeat('m', 16000) where a like "aaa%";
|
||
connect lock_table, localhost, root;
|
||
lock table t write;
|
||
connection prevent_purge;
|
||
commit;
|
||
connection default;
|
||
InnoDB 0 transactions not purged
|
||
disconnect lock_table;
|
||
start transaction with consistent snapshot;
|
||
commit;
|
||
InnoDB 0 transactions not purged
|
||
set global debug_dbug=@old_dbug;
|
||
drop table t;
|
||
#
|
||
# MDEV-15165 InnoDB purge for index on virtual column
|
||
# is trying to access an incomplete record
|
||
#
|
||
CREATE TABLE t1(
|
||
u INT PRIMARY KEY, b BLOB, ug INT GENERATED ALWAYS AS (u) VIRTUAL,
|
||
INDEX bug(b(100),ug)
|
||
) ENGINE=InnoDB;
|
||
INSERT INTO t1 (u,b) VALUES(1,REPEAT('a',16384));
|
||
connection prevent_purge;
|
||
start transaction with consistent snapshot;
|
||
connection default;
|
||
DELETE FROM t1;
|
||
SET DEBUG_SYNC='blob_write_middle SIGNAL halfway WAIT_FOR purged';
|
||
INSERT INTO t1 (u,b) VALUES(1,REPEAT('a',16384));
|
||
connection prevent_purge;
|
||
SET DEBUG_SYNC='now WAIT_FOR halfway';
|
||
COMMIT;
|
||
InnoDB 0 transactions not purged
|
||
SET DEBUG_SYNC='now SIGNAL purged';
|
||
connection default;
|
||
DROP TABLE t1;
|
||
CREATE TABLE t1 (y YEAR, vy YEAR AS (y) VIRTUAL UNIQUE, pk INT PRIMARY KEY)
|
||
ENGINE=InnoDB;
|
||
INSERT INTO t1 (pk,y) VALUES (1,2022);
|
||
CREATE TABLE t2(f1 INT NOT NULL, PRIMARY KEY(f1))ENGINE=InnoDB;
|
||
SET GLOBAL debug_dbug = 'd,ib_purge_virtual_index_callback';
|
||
BEGIN;
|
||
INSERT INTO t2(f1) VALUES(1);
|
||
connection prevent_purge;
|
||
SET DEBUG_SYNC=RESET;
|
||
start transaction with consistent snapshot;
|
||
connection default;
|
||
COMMIT;
|
||
connect truncate,localhost,root,,;
|
||
REPLACE INTO t1(pk, y) SELECT pk,y FROM t1;
|
||
TRUNCATE TABLE t1;
|
||
connection prevent_purge;
|
||
COMMIT;
|
||
SET DEBUG_SYNC='now SIGNAL purge_start';
|
||
disconnect prevent_purge;
|
||
connection default;
|
||
SET DEBUG_SYNC='now WAIT_FOR purge_start';
|
||
InnoDB 0 transactions not purged
|
||
SET GLOBAL debug_dbug=@old_dbug;
|
||
connection truncate;
|
||
disconnect truncate;
|
||
connection default;
|
||
DROP TABLE t1, t2;
|
||
#
|
||
# MDEV-16222 Assertion `0' failed in row_purge_remove_sec_if_poss_leaf
|
||
# on table with virtual columns and indexes
|
||
#
|
||
SET @saved_dbug= @@GLOBAL.debug_dbug;
|
||
set global debug_dbug= "d,ib_purge_virtual_mdev_16222_1,ib_purge_virtual_mdev_16222_2";
|
||
create table t1 (
|
||
pk serial, vb tinyblob as (b) virtual, b tinyblob,
|
||
primary key(pk), index (vb(64)))
|
||
engine innodb;
|
||
insert ignore into t1 (b) values ('foo');
|
||
select * into outfile 'load.data' from t1;
|
||
load data infile 'load.data' replace into table t1;
|
||
set debug_sync= "now WAIT_FOR latch_released TIMEOUT 1";
|
||
set global debug_dbug= @saved_dbug;
|
||
drop table t1;
|
||
set debug_sync= "now SIGNAL drop_started WAIT_FOR got_no_such_table TIMEOUT 1";
|
||
create table t1 (
|
||
pk serial, vb tinyblob as (b) virtual, b tinyblob,
|
||
primary key(pk), index (vb(64)))
|
||
engine innodb;
|
||
insert ignore into t1 (b) values ('foo');
|
||
select * into outfile 'load.data' from t1;
|
||
load data infile 'load.data' replace into table t1;
|
||
set debug_sync= "now WAIT_FOR got_no_such_table TIMEOUT 1";
|
||
set global debug_dbug= @saved_dbug;
|
||
drop table t1;
|
||
set debug_sync=reset;
|
||
#
|
||
# MDEV-18546 ASAN heap-use-after-free
|
||
# in innobase_get_computed_value / row_purge
|
||
#
|
||
CREATE TABLE t1 (
|
||
pk INT AUTO_INCREMENT,
|
||
b BIT(15),
|
||
v BIT(15) AS (b) VIRTUAL,
|
||
PRIMARY KEY(pk),
|
||
UNIQUE(v)
|
||
) ENGINE=InnoDB;
|
||
INSERT IGNORE INTO t1 (b) VALUES
|
||
(NULL),(b'011'),(b'000110100'),
|
||
(b'01101101010'),(b'01111001001011'),(NULL);
|
||
SET GLOBAL innodb_debug_sync = "ib_clust_v_col_before_row_allocated "
|
||
"SIGNAL before_row_allocated "
|
||
"WAIT_FOR flush_unlock";
|
||
SET GLOBAL innodb_debug_sync = "ib_open_after_dict_open "
|
||
"SIGNAL purge_open "
|
||
"WAIT_FOR select_open";
|
||
set global debug_dbug= "d,ib_purge_virtual_index_callback";
|
||
connect purge_waiter,localhost,root;
|
||
SET debug_sync= "now WAIT_FOR before_row_allocated";
|
||
connection default;
|
||
REPLACE INTO t1 (pk, b) SELECT pk, b FROM t1;
|
||
connection purge_waiter;
|
||
connection default;
|
||
disconnect purge_waiter;
|
||
FLUSH TABLES;
|
||
SET GLOBAL innodb_debug_sync = reset;
|
||
SET debug_sync= "now SIGNAL flush_unlock WAIT_FOR purge_open";
|
||
SET GLOBAL innodb_debug_sync = reset;
|
||
SET debug_sync= "ib_open_after_dict_open SIGNAL select_open";
|
||
SELECT * FROM t1;
|
||
pk b v
|
||
1 NULL NULL
|
||
2
|
||
3 4 4
|
||
4 j j
|
||
5 K K
|
||
6 NULL NULL
|
||
DROP TABLE t1;
|
||
SET debug_sync= reset;
|
||
set global debug_dbug= @old_dbug;
|
||
# MDEV-16962 Assertion '!error || !ot_ctx.can_recover_from_failed_open()'
|
||
# failed in open_purge_table upon concurrent ALTER and FLUSH
|
||
CREATE TABLE t1 (
|
||
pk SERIAL,
|
||
c VARCHAR(128),
|
||
d DATE,
|
||
vd DATE AS (d) VIRTUAL,
|
||
PRIMARY KEY(pk),
|
||
KEY(vd,c)
|
||
) ENGINE=InnoDB;
|
||
INSERT IGNORE INTO t1 (pk,c) VALUES (1,'foo');
|
||
set debug_sync="now WAIT_FOR purge";
|
||
connect con1,localhost,root,,test;
|
||
SET GLOBAL innodb_debug_sync="after_open_table_mdl_shared SIGNAL purge WAIT_FOR flush";
|
||
SET global debug_dbug="d,ib_purge_virtual_index_callback";
|
||
REPLACE INTO t1 (pk,c) VALUES (1,'bar');
|
||
connection default;
|
||
SET debug_sync="alter_table_before_rename_result_table WAIT_FOR flush";
|
||
ALTER TABLE t1 ADD FULLTEXT KEY(c), ALGORITHM=COPY;
|
||
connection con1;
|
||
SET debug_sync="after_flush_unlock SIGNAL flush ";
|
||
FLUSH TABLES;
|
||
disconnect con1;
|
||
connection default;
|
||
InnoDB 0 transactions not purged
|
||
DROP TABLE t1;
|
||
SET debug_sync= reset;
|
||
SET global debug_dbug=@old_dbug;
|
||
SET GLOBAL innodb_purge_rseg_truncate_frequency = @saved_frequency;
|