mirror of
https://github.com/MariaDB/server.git
synced 2025-11-12 10:22:39 +03:00
73ed19e44f
This is a backport of the following commits: commitb4165985c9commit69e88de0fecommit40f4525f43commit656f66def2Now that MDEV-14717 made RENAME TABLE crash-safe within InnoDB, it should be safe to drop the #sql- tables within InnoDB during crash recovery. These tables can be one of two things: (1) #sql-ib related to deferred DROP TABLE (follow-up to MDEV-13407) or to table-rebuilding ALTER TABLE...ALGORITHM=INPLACE (since MDEV-14378, only related to the intermediate copy of a table), (2) #sql- related to the intermediate copy of a table during ALTER TABLE...ALGORITHM=COPY We will not drop tables whose name starts with #sql2, because the server can be killed during an ALGORITHM=COPY operation at a point where the original table was renamed to #sql2 but the finished intermediate copy was not yet renamed from #sql- to the original table name. If an old version of MariaDB Server before 10.2.13 (MDEV-11415) was killed while ALTER TABLE...ALGORITHM=COPY was in progress, after recovery there could be undo log records for some records that were inserted into an intermediate copy of the table. Due to these undo log records, InnoDB would resurrect locks at recovery, and the intermediate table would be locked while we are trying to drop it. This would cause a call to row_rename_table_for_mysql(), either from row_mysql_drop_garbage_tables() or from the rollback of a RENAME operation that was part of the ALTER TABLE. row_rename_table_for_mysql(): Do not attempt to parse FOREIGN KEY constraints when renaming from #sql-something to #sql-something-else, because it does not make any sense. row_drop_table_for_mysql(): When deferring DROP TABLE due to locks, do not rename the table if its name already starts with the #sql- prefix, which is what row_mysql_drop_garbage_tables() uses. Previously, the too strict prefix #sql-ib was used, and some tables were renamed unnecessarily.
148 lines
4.4 KiB
Plaintext
148 lines
4.4 KiB
Plaintext
#
|
|
# Bug#20015132 ALTER TABLE FAILS TO CHECK IF TABLE IS CORRUPTED
|
|
#
|
|
CREATE TABLE t1(c1 INT PRIMARY KEY, c2 CHAR(1), c3 INT UNSIGNED) ENGINE=InnoDB;
|
|
SET @saved_debug_dbug = @@SESSION.debug_dbug;
|
|
SET DEBUG_DBUG='+d,ib_create_table_fail_too_many_trx';
|
|
ALTER TABLE t1 ADD INDEX (c2), ADD INDEX (c3);
|
|
ERROR HY000: Too many active concurrent transactions
|
|
SET DEBUG_DBUG=@saved_debug_dbug;
|
|
ALTER TABLE t1 ADD INDEX (c2), ADD INDEX (c3);
|
|
SET DEBUG_DBUG='+d,dict_set_index_corrupted';
|
|
CHECK TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check Warning InnoDB: Index c2 is marked as corrupted
|
|
test.t1 check Warning InnoDB: Index c3 is marked as corrupted
|
|
test.t1 check error Corrupt
|
|
CHECK TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check Warning InnoDB: Index c2 is marked as corrupted
|
|
test.t1 check Warning InnoDB: Index c3 is marked as corrupted
|
|
test.t1 check error Corrupt
|
|
ALTER TABLE t1 DROP INDEX c2;
|
|
CHECK TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check Warning InnoDB: Index c3 is marked as corrupted
|
|
test.t1 check error Corrupt
|
|
ALTER TABLE t1 ADD INDEX (c2,c3);
|
|
ERROR HY000: Index c3 is corrupted
|
|
ALTER TABLE t1 CHANGE c3 c3 INT NOT NULL;
|
|
CHECK TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 check status OK
|
|
ALTER TABLE t1 ADD INDEX (c2,c3);
|
|
DROP TABLE t1;
|
|
#
|
|
# Bug #14669848 CRASH DURING ALTER MAKES ORIGINAL TABLE INACCESSIBLE
|
|
#
|
|
# -- Scenario 1:
|
|
# Crash the server in ha_innobase::commit_inplace_alter_table()
|
|
# just after committing the dictionary changes.
|
|
CREATE TABLE t1 (f1 INT NOT NULL, f2 INT NOT NULL) ENGINE=innodb;
|
|
INSERT INTO t1 VALUES (1,2),(3,4);
|
|
SET DEBUG_DBUG='+d,innodb_alter_commit_crash_after_commit';
|
|
ALTER TABLE t1 ADD PRIMARY KEY (f2, f1);
|
|
ERROR HY000: Lost connection to MySQL server during query
|
|
# Restart mysqld after the crash and reconnect.
|
|
SELECT * FROM information_schema.innodb_sys_tables
|
|
WHERE table_id = ID;
|
|
TABLE_ID NAME FLAG N_COLS SPACE ROW_FORMAT ZIP_PAGE_SIZE SPACE_TYPE
|
|
# Files in datadir after manual recovery.
|
|
db.opt
|
|
t1.frm
|
|
t1.ibd
|
|
SHOW TABLES;
|
|
Tables_in_test
|
|
t1
|
|
SHOW CREATE TABLE t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`f1` int(11) NOT NULL,
|
|
`f2` int(11) NOT NULL,
|
|
PRIMARY KEY (`f2`,`f1`)
|
|
) ENGINE=InnoDB DEFAULT CHARSET=latin1
|
|
INSERT INTO t1 VALUES (5,6),(7,8);
|
|
SELECT * FROM t1;
|
|
f1 f2
|
|
1 2
|
|
3 4
|
|
5 6
|
|
7 8
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (f1 INT NOT NULL, f2 INT NOT NULL) ENGINE=InnoDB;
|
|
ALTER TABLE t1 ADD PRIMARY KEY (f2, f1);
|
|
DROP TABLE t1;
|
|
# -- Scenario 2:
|
|
# Crash the server in ha_innobase::commit_inplace_alter_table()
|
|
# just before committing the dictionary changes, but after
|
|
# writing the MLOG_FILE_RENAME records. As the mini-transaction
|
|
# is not committed, the renames will not be replayed.
|
|
CREATE TABLE t2 (f1 int not null, f2 int not null) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1,2),(3,4);
|
|
SET DEBUG_DBUG='+d,innodb_alter_commit_crash_before_commit';
|
|
ALTER TABLE t2 ADD PRIMARY KEY (f2, f1);
|
|
ERROR HY000: Lost connection to MySQL server during query
|
|
# Startup the server after the crash
|
|
SELECT * FROM information_schema.innodb_sys_tables
|
|
WHERE name LIKE 'test/#sql-%';
|
|
TABLE_ID NAME FLAG N_COLS SPACE ROW_FORMAT ZIP_PAGE_SIZE SPACE_TYPE
|
|
SHOW TABLES;
|
|
Tables_in_test
|
|
t2
|
|
INSERT INTO t2 VALUES (5,6),(7,8);
|
|
SELECT * from t2;
|
|
f1 f2
|
|
1 2
|
|
3 4
|
|
5 6
|
|
7 8
|
|
SHOW CREATE TABLE t2;
|
|
Table Create Table
|
|
t2 CREATE TABLE `t2` (
|
|
`f1` int(11) NOT NULL,
|
|
`f2` int(11) NOT NULL
|
|
) ENGINE=InnoDB DEFAULT CHARSET=latin1
|
|
DROP TABLE t2;
|
|
CREATE TABLE t2 (f1 INT NOT NULL, f2 INT NOT NULL) ENGINE=InnoDB;
|
|
ALTER TABLE t2 ADD PRIMARY KEY (f2, f1);
|
|
DROP TABLE t2;
|
|
db.opt
|
|
# -------------------------
|
|
# End of Testing Scenario 2
|
|
# -------------------------
|
|
#
|
|
# Bug#19330255 WL#7142 - CRASH DURING ALTER TABLE LEADS TO
|
|
# DATA DICTIONARY INCONSISTENCY
|
|
#
|
|
CREATE TABLE t1(a int PRIMARY KEY, b varchar(255), c int NOT NULL)
|
|
ENGINE=InnoDB;
|
|
INSERT INTO t1 SET a=1,c=2;
|
|
SET DEBUG_DBUG='+d,innodb_alter_commit_crash_after_commit';
|
|
ALTER TABLE t1 ADD INDEX (b), CHANGE c d int, ALGORITHM=INPLACE;
|
|
ERROR HY000: Lost connection to MySQL server during query
|
|
# Restart mysqld after the crash and reconnect.
|
|
SELECT * FROM information_schema.innodb_sys_tables
|
|
WHERE table_id = ID;
|
|
TABLE_ID NAME FLAG N_COLS SPACE ROW_FORMAT ZIP_PAGE_SIZE SPACE_TYPE
|
|
# Files in datadir after manual recovery.
|
|
db.opt
|
|
t1.frm
|
|
t1.ibd
|
|
SHOW TABLES;
|
|
Tables_in_test
|
|
t1
|
|
SHOW CREATE TABLE t1;
|
|
Table Create Table
|
|
t1 CREATE TABLE `t1` (
|
|
`a` int(11) NOT NULL,
|
|
`b` varchar(255) DEFAULT NULL,
|
|
`d` int(11) DEFAULT NULL,
|
|
PRIMARY KEY (`a`),
|
|
KEY `b` (`b`)
|
|
) ENGINE=InnoDB DEFAULT CHARSET=latin1
|
|
UPDATE t1 SET d=NULL;
|
|
SELECT * FROM t1;
|
|
a b d
|
|
1 NULL NULL
|
|
DROP TABLE t1;
|