Konstantin Osipov
3138ee3be1
Backport of 2617.65.4 from 6.0-codebase. ...
A fix and a test case for Bug#34898 "mysql_info() reports 0 warnings
while mysql_warning_count() reports 1"
Review the patch by Chad Miller, implement review comments
(since Chad left) and push the patch.
This bug is actually not a bug. At least according to Monty.
See Bug#841 "wrong number of warnings" reported back in July 2003
and closed as "not a bug".
mysql_info() was printing the number of truncated columns, not
the number of warnings.
But since the message of mysql_info() was "Warnings: <number of truncated
columns>", people would expect to get the number
of warnings in it, not the number of truncated columns.
So a possible fix would be to change the message of mysql_info()
to say Rows changed: <n>, truncated: <m>.
Instead, put the number of warnings there. That is, remove the
feature that thd->cuted_fields (the number of truncated fields)
is exposed to the client. The number of truncated columns can be
calculated on the client, by analyzing SHOW WARNINGS output,
and in future we may remove thd->cuted_fields altogether.
So let's have one less thing to worry about.
client/mysqltest.cc:
Fix a bug in mysqltest program which used to return
a wrong number of affected rows in ps-protocol, and a wrong
mysql_info() information in both protocols in presence of warnings.
mysql-test/r/insert.result:
Update results (Bug#34898)
mysql-test/suite/rpl/r/rpl_udf.result:
Update to the changed output of mysqltest: mysql_info() is now printed
before warnings.
mysql-test/t/insert.test:
Add a test case for Bug#34898.
sql/sql_table.cc:
A fix for Bug#34898 - report statement warn count, not the
number of truncated values in mysql_info().
sql/sql_update.cc:
A fix for Bug#34898 - report statement warn count, not the
number of truncated values in mysql_info().
2009-10-16 17:41:43 +04:00
2009-06-17 15:54:01 +02:00
2009-09-17 03:20:11 -06:00
2009-09-10 03:18:29 -06:00
2009-08-13 17:07:20 -03:00
2009-09-30 15:35:01 +02:00
2007-10-09 17:56:32 -04:00
2007-10-09 17:56:32 -04:00
2007-10-09 17:56:32 -04:00
2009-10-08 00:57:03 +04:00
2008-05-09 09:43:02 +02:00
2008-11-10 21:21:49 +01:00
2007-08-15 19:08:44 +04:00
2009-02-13 11:41:47 -05:00
2008-11-10 21:21:49 +01:00
2008-05-09 09:43:02 +02:00
2007-08-15 19:08:44 +04:00
2009-10-13 22:29:28 +04:00
2007-08-15 19:08:44 +04:00
2009-08-29 16:52:22 +08:00
2007-08-15 19:08:44 +04:00
2009-06-17 15:54:01 +02:00
2009-10-14 15:14:58 +04:00
2009-10-14 15:14:58 +04:00
2009-02-17 13:24:09 +01:00
2009-02-13 11:41:47 -05:00
2009-06-09 18:11:21 +02:00
2009-10-14 20:37:38 +04:00
2007-09-11 16:17:28 +02:00
2008-03-29 09:52:16 +02:00
2008-03-10 07:07:56 +01:00
2009-10-14 20:37:38 +04:00
2008-12-20 11:01:41 +01:00
2009-10-15 13:07:04 +02:00
2009-10-15 13:07:04 +02:00
2009-10-14 20:37:38 +04:00
2009-10-14 15:14:58 +04:00
2009-10-14 20:37:38 +04:00
2009-10-14 20:37:38 +04:00
2008-04-03 13:14:57 -04:00
2007-10-11 13:29:09 -04:00
2009-08-28 18:21:54 +02:00
2008-12-12 15:13:11 +04:00
2009-10-14 20:37:38 +04:00
2007-08-15 17:43:08 +04:00
2009-10-14 20:37:38 +04:00
2009-08-24 16:47:08 -03:00
2009-06-17 16:58:33 +02:00
2008-02-22 13:30:33 +03:00
2008-02-22 13:30:33 +03:00
2008-02-22 13:30:33 +03:00
2009-09-17 03:20:11 -06:00
2009-06-01 16:00:38 +04:00
2009-09-04 13:14:54 +05:00
2008-02-22 13:30:33 +03:00
2009-09-28 10:21:25 +03:00
2009-09-28 10:21:25 +03:00
2009-09-17 03:20:11 -06:00
2009-02-07 16:50:31 +01:00
2009-04-01 13:40:33 +05:00
2007-11-21 16:00:09 +04:00
2009-09-17 03:20:11 -06:00
2009-08-28 12:55:59 +02:00
2008-10-10 12:01:01 +02:00
2009-09-10 03:18:29 -06:00
2009-10-14 20:37:38 +04:00
2009-09-10 03:18:29 -06:00
2007-12-05 20:00:14 +01:00
2009-09-17 03:20:11 -06:00
2009-06-30 19:40:38 +01:00
2009-10-14 20:37:38 +04:00
2009-06-18 14:52:46 +01:00
2009-09-10 03:18:29 -06:00
2008-10-23 15:28:53 +02:00
2008-10-23 15:28:53 +02:00
2008-10-23 15:28:53 +02:00
2007-10-11 13:29:09 -04:00
2008-10-23 15:28:53 +02:00
2009-09-10 03:18:29 -06:00
2009-08-24 16:47:08 -03:00
2009-10-14 15:14:58 +04:00
2008-06-17 17:57:04 +05:30
2007-10-16 16:11:50 -04:00
2009-10-14 18:07:50 +04:00
2009-10-13 22:18:48 +04:00
2008-11-22 01:10:38 +01:00
2008-11-22 01:10:38 +01:00
2009-09-28 10:21:25 +03:00
2009-09-28 10:21:25 +03:00
2009-09-28 10:21:25 +03:00
2009-06-19 13:24:43 +05:00
2009-04-13 18:09:10 +05:00
2009-09-10 11:15:39 +02:00
2008-12-02 11:18:01 +01:00
2009-09-02 18:42:08 +03:00
2009-06-01 16:00:38 +04:00
2007-10-11 14:37:45 -04:00
2008-03-21 17:48:28 +02:00
2009-10-09 13:06:41 +04:00
2009-09-30 10:09:28 +05:00
2008-07-15 21:46:02 +04:00
2009-10-14 20:37:38 +04:00
2007-08-16 08:52:50 +02:00
2008-12-29 17:04:10 +01:00
2009-10-14 20:37:38 +04:00
2008-02-19 14:43:01 +03:00
2009-10-14 15:14:58 +04:00
2007-12-14 15:21:37 +02:00
2007-08-16 08:52:50 +02:00
2007-08-16 07:37:50 +02:00
2007-08-16 07:37:50 +02:00
2009-03-05 20:54:53 +01:00
2008-01-31 14:54:03 +02:00
2009-06-16 16:04:30 +01:00
2009-06-16 16:04:30 +01:00
2009-09-10 03:18:29 -06:00
2009-02-21 09:36:07 +00:00
2009-10-14 20:37:38 +04:00
2009-10-14 20:37:38 +04:00
2008-06-30 22:11:18 +02:00
2009-03-25 12:53:56 +02:00
2007-11-14 16:12:46 -05:00
2009-10-15 13:38:21 +02:00
2009-06-19 11:27:19 +02:00
2009-09-10 03:18:29 -06:00
2009-07-06 09:02:14 +01:00
2009-10-14 20:37:38 +04:00
2008-07-03 23:41:22 +04:00
2009-10-14 20:37:38 +04:00
2009-04-29 07:59:10 +05:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2009-10-14 20:37:38 +04:00
2009-07-28 18:44:38 +01:00
2009-08-28 18:21:54 +02:00
2009-06-17 16:56:44 +02:00
2009-10-14 20:37:38 +04:00
2009-10-10 00:01:10 +04:00
2009-06-17 16:56:44 +02:00
2008-03-21 17:48:28 +02:00
2007-10-18 14:32:43 +04:00
2009-10-14 20:37:38 +04:00
2009-01-09 13:49:24 +01:00
2008-01-29 14:14:34 +03:00
2009-10-16 15:39:57 +04:00
2009-10-14 15:14:58 +04:00
2009-10-14 20:37:38 +04:00
2009-10-16 15:39:57 +04:00
2009-10-14 20:37:38 +04:00
2009-04-23 12:43:42 +05:00
2009-04-23 12:43:42 +05:00
2009-02-17 13:24:09 +01:00
2007-10-16 16:11:50 -04:00
2009-10-14 20:37:38 +04:00
2009-09-10 11:15:39 +02:00
2009-09-10 03:18:29 -06:00
2008-02-19 15:45:21 +03:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2009-10-14 20:37:38 +04:00
2009-06-17 16:56:44 +02:00
2009-10-15 14:53:06 +02:00
2009-10-14 20:37:38 +04:00
2009-10-14 15:14:58 +04:00
2009-06-10 10:59:49 +02:00
2009-09-10 03:18:29 -06:00
2008-12-23 18:08:04 +04:00
2008-12-04 19:41:53 +01:00
2007-10-23 14:27:11 +05:00
2009-10-13 22:18:48 +04:00
2009-10-05 22:59:19 +02:00
2007-11-20 11:21:00 +01:00
2009-10-14 20:37:38 +04:00
2009-05-14 14:03:33 +02:00
2009-10-14 20:37:38 +04:00
2009-10-09 15:59:25 +02:00
2009-10-09 15:59:25 +02:00
2009-06-19 13:24:43 +05:00
2009-09-10 03:18:29 -06:00
2008-03-14 18:38:54 +01:00
2009-10-14 20:37:38 +04:00
2009-09-28 10:21:25 +03:00
2009-10-14 20:37:38 +04:00
2009-10-14 15:14:58 +04:00
2008-11-10 21:21:49 +01:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2009-09-30 10:09:28 +05:00
2009-07-31 22:14:52 +05:00
2009-10-16 17:41:43 +04:00
2009-09-10 03:18:29 -06:00
2009-10-14 20:37:38 +04:00
2009-06-17 16:56:44 +02:00
2009-01-14 18:50:51 +04:00
2009-10-14 20:37:38 +04:00
2009-05-15 12:11:07 +05:00
2009-10-16 17:41:43 +04:00
2009-08-28 18:21:54 +02:00
2009-04-13 18:09:10 +05:00
2009-10-14 15:14:58 +04:00
2009-03-14 21:58:23 +03:00
2009-10-14 15:14:58 +04:00
2009-10-15 13:07:04 +02:00
2009-10-15 13:07:04 +02:00
2009-09-10 03:18:29 -06:00
2009-09-10 03:18:29 -06:00
2009-10-14 20:37:38 +04:00
2009-01-12 17:40:29 +01:00
2009-09-30 15:35:01 +02:00
2007-10-17 17:54:11 -04:00
2009-06-17 16:56:44 +02:00
2009-09-17 03:20:11 -06:00
2009-07-31 15:28:15 -04:00
3138ee3be1