Ole John Aske
221ce9223d
Fix for bug#59308: Incorrect result for SELECT DISTINCT <col>... ORDER BY <col> DESC. ...
Also fix bug#59110: Memory leak of QUICK_SELECT_I allocated memory.
Includes Jørgen Lølands review comments.
Root cause of these bugs are that test_if_skip_sort_order() decided to
revert the 'skip_sort_order' descision (and use filesort) after the
query plan has been updated to reflect a 'skip' of the sort order.
This might happen in 'check_reverse_order:' if we have a
select->quick which could not be made descending by appending
a QUICK_SELECT_DESC. ().
The original 'save_quick' was then restored after the QEP has been modified,
which caused:
- An incorrect 'precomputed_group_by= TRUE' may have been set,
and not reverted, as part of the already modifified QEP (Bug#59308)
- A 'select->quick' might have been created which we fail to delete (bug#59110).
This fix is a refactorication of test_if_skip_sort_order() where all logic
related to modification of QEP (controlled by argument 'bool no_changes'), is
moved to the end of test_if_skip_sort_order(), and done after *all* 'test_if_skip'
checks has been performed - including the 'check_reverse_order:' checks.
The refactorication above contains now intentional changes to the logic which
has been moved to the end of the function.
Furthermore, a smaller part of the fix address the handling of the
select->quick objects which may already exists when we call
'test_if_skip_sort_order()' (save_quick) -and
new select->quick's created during test_if_skip_sort_order():
- Before new select->quick may be created by calling ::test_quick_select(), we
set 'select->quick= 0' to avoid that ::test_quick_select() prematurely
delete the save_quick's. (After this call we may have both a 'save_quick'
and 'select->quick')
- All returns from ::test_if_skip_sort_order() where we may have both a
'save_quick' and a 'select->quick' has been changed to goto's to the
exit points 'skiped_sort_order:' or 'need_filesort:' where we
decide which of the QUICK_SELECT's to keep, and delete the other.
2011-02-07 10:36:21 +01:00
2009-08-25 15:56:50 +02:00
2010-05-24 21:54:08 +08:00
2009-12-18 14:00:30 +02:00
2009-10-30 11:40:44 +02:00
2009-05-15 12:15:56 +02:00
2010-03-25 23:57:06 +04:00
2011-01-04 14:36:37 +01:00
2009-02-09 22:00:15 +01:00
2010-02-25 23:13:11 +04:00
2010-05-28 00:07:40 +04:00
2009-07-10 15:00:34 +03:00
2010-02-02 14:17:21 +02:00
2010-04-22 15:52:00 +02:00
2010-04-22 15:52:00 +02:00
2009-09-18 16:01:18 +03:00
2009-09-18 16:01:18 +03:00
2009-11-25 12:25:49 +05:30
2009-11-30 10:54:26 +05:30
2009-05-21 13:06:43 +05:00
2009-01-15 14:58:32 +03:00
2010-11-25 03:11:05 +00:00
2009-02-05 21:47:23 +01:00
2009-05-15 12:15:56 +02:00
2009-02-09 22:00:15 +01:00
2010-11-11 07:34:14 +00:00
2009-05-11 20:54:00 -03:00
2009-06-08 20:03:01 -03:00
2009-12-22 13:52:23 +04:00
2010-05-24 21:54:08 +08:00
2010-01-16 15:44:24 +08:00
2011-01-25 12:14:28 +05:30
2010-03-09 16:09:32 +01:00
2009-03-19 12:20:28 +04:00
2010-05-24 21:54:08 +08:00
2010-11-26 16:58:54 +03:00
2009-07-24 11:27:23 +05:00
2009-09-07 13:42:54 +08:00
2010-11-18 11:53:08 +03:00
2010-03-22 16:27:59 +04:00
2011-01-17 15:11:33 +03:00
2009-05-05 11:55:22 +05:00
2010-04-06 12:26:59 +05:00
2010-11-11 13:25:23 +03:00
2010-10-12 23:25:40 +04:00
2010-11-12 13:12:15 +03:00
2009-05-15 12:15:56 +02:00
2009-05-15 12:15:56 +02:00
2009-09-29 17:38:40 +02:00
2009-11-18 13:49:45 +01:00
2010-08-31 02:16:38 +04:00
2010-12-14 12:33:03 +03:00
2009-03-03 21:34:18 +01:00
2011-01-29 12:38:36 +01:00
2009-09-06 00:42:17 +04:00
2009-05-15 12:15:56 +02:00
2010-06-29 10:28:17 +02:00
2009-03-11 17:30:56 -03:00
2009-05-15 12:15:56 +02:00
2009-08-27 15:17:09 +02:00
2010-05-19 11:18:59 +02:00
2009-05-15 12:15:56 +02:00
2009-05-15 12:15:56 +02:00
2010-10-18 16:12:27 +04:00
2009-05-15 12:15:56 +02:00
2010-05-24 21:54:08 +08:00
2009-03-03 21:34:18 +01:00
2009-10-20 11:00:07 -07:00
2009-05-15 12:15:56 +02:00
2009-12-22 17:52:15 +02:00
2008-12-17 17:24:34 +04:00
2008-12-17 17:24:34 +04:00
2010-10-18 14:47:26 +04:00
2009-06-19 11:27:19 +02:00
2010-04-03 00:30:22 +04:00
2009-05-27 14:20:57 +04:00
2009-04-17 18:52:57 +03:00
2009-04-27 15:05:01 +05:00
2010-12-14 23:52:53 +03:00
2010-12-21 15:30:07 +03:00
2010-06-22 22:53:08 +04:00
2010-06-08 10:22:40 +04:00
2011-01-17 12:30:22 +03:00
2010-12-24 14:05:04 +03:00
2010-10-12 23:28:03 +04:00
2009-02-06 18:25:08 +01:00
2009-06-16 16:36:15 +02:00
2011-01-13 08:57:15 +01:00
2011-02-02 20:13:11 +02:00
2010-03-25 15:49:01 +04:00
2011-01-15 00:56:09 +04:00
2009-10-29 22:06:10 -07:00
2010-10-18 21:03:53 +07:00
2009-10-27 12:09:19 +04:00
2010-10-13 12:28:58 +07:00
2009-01-13 13:09:12 +02:00
2010-10-29 12:23:06 +04:00
2010-06-11 09:38:29 +02:00
2010-06-09 14:45:04 +04:00
2010-07-09 14:39:47 +04:00
2009-05-06 15:00:14 +05:30
2009-03-14 21:58:23 +03:00
2009-09-28 13:25:47 +02:00
2010-06-25 12:01:47 +04:00
2009-07-06 18:20:17 -04:00
2010-12-19 18:07:28 +01:00
2009-02-09 19:03:52 +04:00
2009-02-09 19:03:52 +04:00
2010-05-28 00:07:40 +04:00
2009-09-02 18:58:17 +02:00
2009-04-28 20:12:18 +02:00
2010-08-09 13:39:59 +02:00
2010-10-29 12:23:06 +04:00
2010-09-07 15:43:00 +02:00
2010-11-05 15:26:38 +01:00
2010-11-25 03:11:05 +00:00
2009-10-20 11:00:07 -07:00
2010-07-14 14:54:51 +03:00
2009-10-19 13:44:44 +05:00
2009-08-28 18:49:16 -03:00
2009-08-28 18:49:16 -03:00
2009-12-18 18:32:55 -02:00
2010-05-28 00:07:40 +04:00
2009-02-02 22:20:25 +01:00
2009-03-05 15:22:33 +01:00
2010-05-12 13:19:12 +02:00
2009-06-15 20:27:27 -03:00
2010-02-26 09:22:48 -03:00
2009-08-27 15:17:09 +02:00
2010-11-07 23:42:54 +06:00
2009-10-27 14:09:36 +04:00
2009-09-09 14:38:50 +05:00
2009-09-09 14:38:50 +05:00
2009-09-09 14:38:50 +05:00
2009-08-28 16:13:27 +02:00
2010-10-19 12:27:09 +02:00
2010-10-19 12:27:09 +02:00
2009-02-17 18:22:48 +04:00
2009-02-18 16:09:46 +04:00
2010-06-25 15:59:44 +03:00
2010-04-26 15:44:10 +02:00
2010-03-12 10:33:16 +04:00
2009-06-08 19:18:31 -03:00
2010-12-14 12:33:03 +03:00
2009-04-06 12:31:17 +05:30
2009-10-14 16:26:16 +05:00
2009-05-04 14:35:16 +05:30
2009-09-17 16:33:23 +05:00
2010-03-12 14:43:30 +04:00
2009-04-07 17:06:15 +05:30
2010-07-30 09:17:10 -03:00
2010-07-01 12:05:09 +03:00
2009-03-25 11:47:41 +03:00
2009-06-17 20:10:48 +04:00
2011-02-05 11:02:00 +06:00
2011-01-16 02:04:08 +05:30
2011-01-12 19:32:45 +00:00
2009-09-07 13:42:54 +08:00
2010-11-05 15:26:38 +01:00
2010-12-29 11:52:57 +08:00
2009-05-20 18:31:10 -07:00
2009-05-22 10:38:17 -04:00
2009-03-02 11:03:13 +01:00
2011-01-14 19:50:34 +05:30
2010-06-03 10:31:26 +02:00
2010-06-03 10:31:26 +02:00
2011-01-11 10:54:42 +01:00
2009-11-03 01:19:37 +01:00
2010-02-07 00:12:04 +00:00
2011-02-04 10:47:46 +06:00
2009-09-02 23:29:11 +02:00
2009-02-05 13:49:32 +04:00
2009-11-06 09:44:01 +03:00
2010-01-29 16:54:27 +02:00
2011-02-07 10:36:21 +01:00
2010-05-07 00:41:37 +04:00
2009-02-03 14:45:17 +01:00
2009-02-05 21:47:23 +01:00
2009-06-19 11:27:19 +02:00
2009-04-17 16:00:53 -04:00
2009-04-17 16:00:53 -04:00
2010-10-01 13:39:04 +02:00
2009-12-13 23:29:50 +03:00
2009-09-03 08:38:06 +02:00
2010-02-01 16:07:00 +01:00
2009-01-08 15:16:44 +01:00
2009-08-12 12:03:05 +02:00
2011-01-26 16:50:21 +01:00
2009-09-25 11:26:49 +02:00
2010-11-15 23:27:37 +01:00
2008-12-16 12:44:18 +01:00
2010-01-07 11:22:45 +01:00
2010-01-18 17:49:18 +01:00
2010-10-15 20:13:35 +05:00
2009-04-17 16:00:53 -04:00
2010-07-08 14:36:55 +02:00
2010-08-20 21:17:51 +02:00
2009-07-27 16:50:43 +05:30
2009-10-08 15:36:43 +02:00
2009-10-09 16:12:01 +02:00
2010-08-26 17:14:18 +02:00
2010-08-11 14:13:59 +02:00
2009-07-27 16:50:43 +05:30
2010-12-22 10:50:36 +01:00
2009-06-10 10:59:49 +02:00
2009-10-08 10:39:15 +02:00
2010-03-09 09:16:17 -03:00
2010-12-02 09:13:31 +01:00
2009-10-08 10:39:15 +02:00
2009-05-05 17:03:23 -04:00
2009-04-01 10:58:55 +02:00
2010-06-09 16:07:34 +04:00
2010-01-16 15:44:24 +08:00
2009-09-04 17:02:17 -03:00
2009-08-27 15:17:09 +02:00
2010-10-01 14:08:38 +04:00
2009-02-23 09:03:31 +01:00
2009-06-17 16:28:11 +02:00
2009-02-13 17:26:20 -02:00
2010-03-24 17:37:41 +01:00
2009-11-03 17:18:43 +01:00
2011-02-01 13:20:16 +01:00
2009-03-06 15:56:17 +01:00
2009-02-11 10:27:52 +01:00
2010-05-21 22:47:32 +04:00
2010-09-09 16:46:13 +04:00
2010-06-26 19:36:00 +02:00
2010-06-24 21:13:08 +04:00
2009-03-26 20:17:27 -03:00
2009-08-27 15:17:09 +02:00
2009-12-15 11:03:24 +02:00
2010-03-31 16:12:37 +03:00
2010-02-05 13:39:46 +04:00
2010-01-15 10:51:39 +02:00
2010-05-24 21:54:08 +08:00
2010-11-11 10:52:51 +06:00
2009-11-21 09:18:21 -02:00
2009-10-19 16:55:04 +03:00
2009-07-03 10:19:32 +02:00
2009-11-27 18:10:28 +02:00
2009-02-05 21:47:23 +01:00
2009-12-02 15:17:08 +04:00
2009-12-23 17:44:03 +04:00
2009-06-12 18:11:19 -03:00
2010-07-28 12:59:19 -03:00
2009-03-03 21:34:18 +01:00
2009-03-03 21:34:18 +01:00
2009-03-03 21:34:18 +01:00
2008-12-17 17:23:21 +04:00
2009-08-27 15:17:09 +02:00
2009-06-10 11:58:36 +03:00
2009-03-05 08:20:01 -03:00
2009-11-03 13:48:59 +01:00
2011-01-12 09:55:31 +01:00
2010-04-15 17:04:24 +03:00
2010-04-01 18:49:02 +04:00
2009-02-05 21:47:23 +01:00
2009-02-02 13:36:03 +02:00
2009-01-07 10:11:37 -02:00
2010-08-06 23:29:37 +04:00
2009-01-12 17:40:29 +01:00
2009-02-05 21:47:23 +01:00
2010-09-07 15:53:46 +07:00
2009-02-19 18:24:25 -05:00
2010-04-01 10:15:22 -03:00
2009-03-11 14:54:57 -06:00
2010-02-16 13:13:49 +04:00
2010-10-31 19:04:38 +03:00
2010-03-16 10:20:07 +01:00
2011-01-19 15:09:32 +01:00
2009-02-14 18:36:57 +03:00
2009-11-20 12:10:47 +02:00
2010-05-31 13:25:11 +04:00
2010-09-13 11:18:35 +04:00
2010-03-22 12:33:25 +04:00
2010-03-18 11:26:27 +01:00
2010-01-06 12:24:51 +02:00
2010-07-19 11:03:52 +02:00
2010-05-21 22:47:32 +04:00
2009-03-03 21:34:18 +01:00
2010-11-22 09:57:59 +01:00
2009-04-28 20:12:18 +02:00
2010-02-11 14:26:58 +01:00
2010-09-22 23:33:18 +04:00
2010-11-15 16:17:38 +01:00
2009-04-06 13:42:33 +02:00
2008-12-13 19:42:12 +00:00
2011-02-02 19:05:28 +02:00
2010-03-09 07:36:26 -03:00
2011-01-12 16:08:30 +03:00
2010-12-14 12:33:03 +03:00
2010-10-19 13:54:28 +02:00
2008-12-17 19:45:34 +04:00
2009-09-10 13:49:49 +05:00
2009-09-22 08:22:07 -03:00
2010-03-10 19:31:22 +04:00
2011-01-18 09:38:41 +03:00
221ce9223d