Alexander Barkov
1d30a23fcc
Moving a few static functions in sql_lex.cc to new methods in Lex_input_stream
...
Reasoning:
- Shorter and clearer code
- Better encapsulation
(a fair number of Lex_input_stream methods and members were
moved to the private section)
New methods:
int lex_token(union YYSTYPE *yylval, THD *thd);
bool consume_comment(int remaining_recursions_permitted);
int lex_one_token(union YYSTYPE *yylval, THD *thd);
int find_keyword(Lex_ident_cli_st *str, uint len, bool function);
LEX_CSTRING get_token(uint skip, uint length);
Additional changes:
- Removing Lex_input_stream::yylval.
In the original code it was just an alias
for the "yylval" passed to lex_one_token().
This coding style is bug prone and is hard to follow.
In the new reduction "yylval" (or its components) is passed to
the affected methods as a parameter.
- Moving the code in sql_lex.h up and down between "private" and "public"
sections (sorry if this made the diff somewhat harder to read)
2018-05-09 00:16:32 +04:00
..
2018-04-26 16:38:56 -07:00
2017-11-22 14:39:21 +04:00
2017-08-24 01:05:44 +02:00
2018-04-30 19:34:08 +04:00
2018-02-06 17:12:17 +02:00
2018-04-05 14:23:18 +04:00
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2017-04-23 22:35:46 +03:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:44 +02:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:44 +02:00
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:44 +02:00
2017-08-26 00:34:43 +02:00
2018-05-07 00:07:32 +03:00
2018-01-30 21:33:55 +02:00
2018-04-20 14:33:24 +02:00
2017-04-23 22:35:46 +03:00
2017-10-04 08:24:06 +03:00
2017-08-24 01:05:48 +02:00
2018-01-30 21:33:55 +02:00
2017-04-23 22:35:46 +03:00
2018-01-30 21:33:56 +02:00
2018-05-07 00:07:32 +03:00
2017-04-23 22:35:46 +03:00
2018-04-20 18:29:18 +04:00
2017-08-31 15:44:17 +04:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2018-04-30 19:34:08 +04:00
2018-01-04 09:22:59 +02:00
2017-08-24 01:05:44 +02:00
2018-05-08 16:22:38 +03:00
2017-08-24 01:05:48 +02:00
2018-02-06 12:55:58 +00:00
2017-03-10 18:21:29 +01:00
2017-08-24 01:05:44 +02:00
2017-03-10 18:21:29 +01:00
2018-05-07 00:07:32 +03:00
2017-11-13 19:09:46 +03:00
2018-05-07 00:07:32 +03:00
2017-03-10 18:21:29 +01:00
2017-08-24 01:05:44 +02:00
2017-08-24 01:05:44 +02:00
2018-05-07 00:07:33 +03:00
2018-03-29 13:59:40 +03:00
2018-05-07 00:07:32 +03:00
2017-05-30 21:31:30 +03:00
2018-05-07 14:58:11 +05:30
2018-05-07 14:58:11 +05:30
2017-08-24 01:05:44 +02:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:44 +02:00
2017-08-24 01:05:44 +02:00
2017-09-01 11:33:45 +03:00
2018-02-06 12:55:58 +00:00
2017-08-24 01:05:44 +02:00
2018-05-07 00:07:32 +03:00
2018-03-30 09:45:05 +02:00
2018-05-07 00:07:32 +03:00
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2018-04-24 20:59:57 +03:00
2017-11-30 08:16:37 +02:00
2017-11-23 09:49:45 +02:00
2018-05-07 00:07:32 +03:00
2017-11-23 09:49:45 +02:00
2018-05-07 00:07:32 +03:00
2017-11-23 09:49:45 +02:00
2017-11-30 08:16:37 +02:00
2018-04-05 21:27:33 +04:00
2018-05-07 00:07:32 +03:00
2018-04-24 20:59:57 +03:00
2018-05-07 00:07:32 +03:00
2018-02-15 10:22:03 +02:00
2018-05-07 00:07:32 +03:00
2018-04-23 09:31:17 +04:00
2018-05-07 00:07:32 +03:00
2018-03-28 11:26:02 +04:00
2018-01-30 21:33:55 +02:00
2017-11-23 19:41:44 +03:00
2018-02-15 10:22:03 +02:00
2018-02-15 10:22:03 +02:00
2018-02-27 15:26:51 +04:00
2018-02-15 10:22:03 +02:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2018-04-24 20:59:57 +03:00
2017-08-24 01:05:44 +02:00
2018-02-06 12:55:58 +00:00
2018-02-06 12:55:58 +00:00
2018-04-30 14:24:48 +03:00
2018-03-29 14:27:57 +04:00
2018-05-07 00:07:32 +03:00
2017-04-07 18:09:56 +04:00
2018-05-07 00:07:32 +03:00
2017-12-29 13:35:41 +02:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:51 +02:00
2018-05-07 00:07:32 +03:00
2018-04-23 09:49:58 +03:00
2017-08-24 01:05:44 +02:00
2018-03-26 17:53:17 +03:00
2018-05-01 16:52:19 +03:00
2018-02-15 10:22:03 +02:00
2018-05-07 00:07:32 +03:00
2018-02-06 12:55:58 +00:00
2017-06-21 13:44:16 +03:00
2017-12-12 09:57:17 +02:00
2017-12-08 13:46:23 +02:00
2018-02-06 12:55:58 +00:00
2018-02-16 15:52:25 +04:00
2018-02-06 12:55:58 +00:00
2018-02-20 21:17:36 +00:00
2018-04-30 19:34:08 +04:00
2018-02-20 21:17:36 +00:00
2018-05-07 00:07:32 +03:00
2018-04-12 12:41:19 +03:00
2018-05-07 00:07:32 +03:00
2018-02-20 21:17:36 +00:00
2018-02-20 21:17:36 +00:00
2017-08-24 01:05:44 +02:00
2018-04-26 17:35:12 +03:00
2018-05-07 00:07:32 +03:00
2017-12-11 15:43:41 +03:00
2018-05-06 23:05:37 +05:30
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:53 +02:00
2018-05-07 00:07:32 +03:00
2017-12-02 12:04:54 +02:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:48 +02:00
2018-02-23 19:17:48 +01:00
2018-05-07 00:07:33 +03:00
2018-04-10 13:12:36 +02:00
2018-04-24 20:59:57 +03:00
2018-04-24 12:48:27 +03:00
2018-01-30 21:33:55 +02:00
2018-04-05 21:27:33 +04:00
2018-05-07 00:07:32 +03:00
2018-04-02 22:49:32 +02:00
2018-03-23 20:23:12 +00:00
2018-05-07 00:07:32 +03:00
2017-08-31 13:46:30 +04:00
2018-02-06 12:55:58 +00:00
2018-02-06 12:55:58 +00:00
2017-12-18 13:43:36 +02:00
2018-01-30 21:33:55 +02:00
2018-05-07 00:07:32 +03:00
2018-01-30 21:33:55 +02:00
2018-05-07 00:07:32 +03:00
2018-01-30 21:33:56 +02:00
2018-05-07 00:07:32 +03:00
2018-04-19 16:04:23 +05:30
2018-05-07 14:58:11 +05:30
2017-04-18 12:23:40 +03:00
2017-10-30 20:47:39 +04:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:44 +02:00
2017-08-24 01:05:44 +02:00
2017-08-24 01:05:44 +02:00
2018-05-07 00:07:32 +03:00
2017-08-26 00:34:43 +02:00
2018-02-04 18:40:06 +04:00
2018-04-20 18:11:27 +04:00
2017-08-24 01:05:44 +02:00
2017-08-24 01:05:44 +02:00
2018-02-06 12:55:58 +00:00
2017-12-18 13:43:38 +02:00
2018-05-07 00:07:32 +03:00
2018-02-06 12:55:58 +00:00
2018-02-06 12:55:58 +00:00
2017-12-18 13:43:38 +02:00
2017-12-18 13:43:38 +02:00
2017-12-18 13:43:38 +02:00
2018-02-06 12:55:58 +00:00
2017-03-07 19:07:27 +02:00
2018-05-07 00:07:32 +03:00
2018-04-12 12:41:19 +03:00
2018-02-20 21:17:36 +00:00
2018-05-07 14:58:11 +05:30
2018-01-04 09:22:59 +02:00
2018-04-10 13:12:36 +02:00
2018-04-10 13:12:36 +02:00
2018-05-07 00:07:32 +03:00
2018-03-29 13:59:40 +03:00
2018-02-06 12:55:58 +00:00
2018-02-27 15:26:51 +04:00
2018-05-07 00:07:32 +03:00
2018-02-27 15:26:51 +04:00
2018-05-07 14:37:38 +04:00
2018-03-02 12:09:41 +04:00
2018-05-07 00:07:32 +03:00
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2017-04-23 22:35:46 +03:00
2018-05-01 16:52:19 +03:00
2018-05-07 14:58:11 +05:30
2018-05-07 14:58:11 +05:30
2017-08-24 01:05:44 +02:00
2017-05-17 00:34:48 +03:00
2017-08-24 01:05:44 +02:00
2017-03-30 12:48:42 +02:00
2018-05-07 00:07:32 +03:00
2018-01-30 21:33:55 +02:00
2018-01-30 21:33:55 +02:00
2018-05-07 00:07:32 +03:00
2018-04-24 20:59:57 +03:00
2018-02-06 12:55:58 +00:00
2018-04-29 17:53:21 +03:00
2018-01-29 12:44:20 +04:00
2017-04-07 18:09:56 +04:00
2018-05-07 00:07:32 +03:00
2018-02-26 18:14:58 +11:00
2018-05-07 00:07:32 +03:00
2018-05-09 00:16:32 +04:00
2017-08-24 01:05:44 +02:00
2018-02-27 15:26:51 +04:00
2018-05-07 00:07:32 +03:00
2017-08-25 16:14:03 +00:00
2018-04-12 12:41:19 +03:00
2017-08-24 01:05:44 +02:00
2017-08-24 01:05:48 +02:00
2018-04-19 15:23:21 +03:00
2018-02-22 10:26:56 -08:00
2018-04-05 21:27:33 +04:00
2018-02-07 20:19:40 +00:00
2018-05-07 00:07:32 +03:00
2018-01-30 21:33:55 +02:00
2018-05-07 00:07:32 +03:00
2017-07-07 22:38:15 +02:00
2018-05-07 00:07:32 +03:00
2017-04-28 21:59:11 -07:00
2018-02-06 12:55:58 +00:00
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2018-04-10 13:12:36 +02:00
2018-02-06 12:55:58 +00:00
2018-02-15 10:22:03 +02:00
2018-05-07 00:07:32 +03:00
2017-03-10 18:21:29 +01:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2018-01-30 21:33:55 +02:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:44 +02:00
2018-05-07 00:07:32 +03:00
2017-05-05 20:36:08 +03:00
2018-05-07 00:07:32 +03:00
2018-02-06 12:55:58 +00:00
2018-05-09 00:16:32 +04:00
2018-05-09 00:16:32 +04:00
2018-04-29 17:53:21 +03:00
2018-02-15 10:22:03 +02:00
2018-05-01 16:52:19 +03:00
2018-05-07 00:07:32 +03:00
2018-03-15 23:29:48 +04:00
2017-08-24 01:05:44 +02:00
2017-08-24 01:05:44 +02:00
2017-10-04 08:24:06 +03:00
2018-05-07 00:07:32 +03:00
2018-04-27 22:11:18 +04:00
2018-05-07 00:07:33 +03:00
2018-05-07 00:07:33 +03:00
2018-05-07 00:07:33 +03:00
2018-05-01 16:52:19 +03:00
2017-04-23 22:35:46 +03:00
2018-03-12 14:46:20 +02:00
2018-05-07 00:07:32 +03:00
2018-01-30 21:33:56 +02:00
2018-05-07 00:07:32 +03:00
2018-02-07 20:19:40 +00:00
2018-04-24 20:59:57 +03:00
2018-02-06 12:55:58 +00:00
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2017-11-21 19:47:46 +01:00
2018-05-07 00:07:32 +03:00
2018-02-15 10:22:03 +02:00
2018-05-07 00:07:32 +03:00
2017-10-19 13:25:02 +03:00
2018-05-07 00:07:32 +03:00
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2018-04-10 13:12:36 +02:00
2018-05-07 00:07:32 +03:00
2017-04-05 15:02:53 +04:00
2018-05-07 00:07:33 +03:00
2017-08-24 01:05:44 +02:00
2018-04-24 20:59:57 +03:00
2018-04-02 13:14:30 +03:00
2018-04-24 20:59:57 +03:00
2018-05-07 00:07:32 +03:00
2018-05-07 14:58:11 +05:30
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2018-01-09 14:16:47 +03:00
2017-10-30 20:47:39 +04:00
2018-03-28 17:31:57 +02:00
2018-02-23 15:33:24 +01:00
2018-05-07 00:07:32 +03:00
2018-01-30 21:33:55 +02:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2017-11-23 09:49:45 +02:00
2018-04-23 18:34:06 +04:00
2018-04-23 18:34:06 +04:00
2018-05-07 00:07:32 +03:00
2018-02-06 12:55:58 +00:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:44 +02:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2018-01-30 21:33:55 +02:00
2018-05-07 00:07:32 +03:00
2017-11-23 09:49:45 +02:00
2018-05-07 00:07:33 +03:00
2018-05-09 00:16:32 +04:00
2018-05-07 00:07:32 +03:00
2018-02-06 12:55:58 +00:00
2018-04-27 22:11:18 +04:00
2018-02-06 12:55:58 +00:00
2018-05-07 14:58:11 +05:30
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2017-10-31 19:13:20 +04:00
2018-05-07 00:07:32 +03:00
2018-04-24 20:59:57 +03:00
2018-05-07 00:07:32 +03:00
2018-05-07 00:07:32 +03:00
2018-02-04 18:40:06 +04:00
2018-05-07 00:07:32 +03:00
2018-02-20 21:17:36 +00:00
2018-05-07 00:07:32 +03:00
2017-03-30 12:48:42 +02:00
2018-05-07 00:07:32 +03:00
2017-08-24 01:05:44 +02:00
2018-05-07 00:07:32 +03:00
2017-11-27 15:07:32 +03:00
2018-02-20 21:17:36 +00:00
2017-04-07 18:09:56 +04:00
2018-05-07 00:07:33 +03:00
2018-04-24 12:48:27 +03:00
2018-05-07 00:07:32 +03:00
2018-04-10 13:12:36 +02:00
2018-04-10 13:12:36 +02:00
2018-04-10 13:12:36 +02:00
2017-11-05 22:23:32 +02:00
2017-03-10 18:21:29 +01:00
2017-11-10 16:12:45 +02:00
2017-03-10 18:21:29 +01:00
2018-05-07 00:07:32 +03:00
2018-03-28 17:31:57 +02:00
2018-03-21 12:02:09 +02:00
2018-03-19 08:48:14 +02:00
2018-03-28 17:31:57 +02:00
2018-03-28 17:31:57 +02:00
2017-08-24 01:05:44 +02:00
2017-03-30 12:48:42 +02:00
2018-03-28 17:31:57 +02:00
2018-02-06 14:50:50 +01:00
2018-01-30 21:33:55 +02:00
2017-12-18 16:57:54 +01:00
2017-08-31 09:30:40 +03:00
2018-03-28 17:31:57 +02:00
2018-03-21 10:36:49 +02:00
2018-03-21 12:02:09 +02:00