mirror of
https://github.com/MariaDB/server.git
synced 2025-05-28 13:01:41 +03:00
1b74f2e3da
WRITTEN WHILE ROWS REMAINS Problem: ======== When truncate table fails while using transactional based engines even though the operation errors out we still continue and log it to binlog. Because of this master has data but the truncate will be written to binary log which will cause inconsistency. Analysis: ======== Truncate table can happen either through drop and create of table or by deleting rows. In the second case the existing code is written in such a way that even if an error occurs the truncate statement will always be binlogged. Which is not correct. Binlogging of TRUNCATE TABLE statement should check whether truncate is executed "transactionally or not". If the table is transaction based we log the TRUNCATE TABLE only on successful completion. If table is non transactional there are possibilities that on error we could have partial changes done hence in such cases we do log in spite of errors as some of the lines might have been removed, so the statement has to be sent to slave. Fix: === Using table handler whether truncate table is being executed in transaction based mode or not is identified and statement is binlogged accordingly. mysql-test/suite/binlog/r/binlog_truncate_kill.result: Added test case to test the fix for Bug#17942050. mysql-test/suite/binlog/t/binlog_truncate_kill.test: Added test case to test the fix for Bug#17942050. sql/sql_truncate.cc: Check if truncation is successful or not and retun appropriate return values so that binlogging can be done based on that. sql/sql_truncate.h: Added a new enum.
57 lines
2.0 KiB
Plaintext
57 lines
2.0 KiB
Plaintext
###############################################################################
|
|
# Bug#17942050:KILL OF TRUNCATE TABLE WILL LEAD TO BINARY LOG WRITTEN WHILE
|
|
# ROWS REMAINS
|
|
#
|
|
# Problem:
|
|
# ========
|
|
# When truncate table fails while using transactional based engines even
|
|
# though the operation errors out we still continue and log it to binlog.
|
|
# Because of this master has data but the truncate will be written to binary
|
|
# log which will cause inconsistency.
|
|
#
|
|
# Test:
|
|
# =====
|
|
# Make master to wait in "open_table" call during the execution of truncate
|
|
# table command and kill the truncate table from other connection. This causes
|
|
# open table to return an error saying truncate failed during open table. This
|
|
# statement should not be binlogged.
|
|
###############################################################################
|
|
--source include/have_debug_sync.inc
|
|
--source include/have_binlog_format_statement.inc
|
|
RESET MASTER;
|
|
--enable_connect_log
|
|
--connection default
|
|
CREATE TABLE t1(id INT AUTO_INCREMENT PRIMARY KEY, a INT, b INT) ENGINE=INNODB;
|
|
INSERT INTO t1(a, b) VALUES(1,2),(2,4),(3,6),(4,8),(5,10);
|
|
SET DEBUG_SYNC = "open_and_process_table signal truncate_before_lock wait_for forever";
|
|
--send TRUNCATE t1
|
|
|
|
connect(con1,localhost,root,,);
|
|
SET DEBUG_SYNC = "now wait_for truncate_before_lock";
|
|
# Wait for one connection to reach open_and_process_table.
|
|
--let $show_statement= SHOW PROCESSLIST
|
|
--let $field= State
|
|
--let $condition= 'debug sync point: open_and_process_table';
|
|
--source include/wait_show_condition.inc
|
|
|
|
SELECT ((@id := id) - id) FROM information_schema.processlist WHERE processlist.info LIKE '%TRUNCATE t1%' AND state LIKE '%open_and_process_table%';
|
|
# Test killing from mysql server
|
|
KILL QUERY @id;
|
|
|
|
connection default;
|
|
--ERROR ER_QUERY_INTERRUPTED
|
|
--reap
|
|
|
|
connection con1;
|
|
--source include/show_binlog_events.inc
|
|
|
|
disconnect con1;
|
|
--source include/wait_until_disconnected.inc
|
|
connection default;
|
|
|
|
SELECT * FROM t1;
|
|
|
|
DROP TABLE t1;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
--disable_connect_log
|