mirror of
https://github.com/MariaDB/server.git
synced 2025-10-22 19:52:58 +03:00
093106f552
Extend and implement the grammar that allows to FLUSH WITH READ LOCK a list of tables, rather than all of them. Incompatible grammar change: Previously one could perform FLUSH TABLES, HOSTS, PRIVILEGES in a single statement. After this change, FLUSH TABLES must always be alone on the list. Judging by the test suite, however, the old extended syntax was never or very rarely used. The new statement requires RELOAD ACL global privilege and LOCK_TABLES_ACL | SELECT_ACL on individual tables. In other words, it's an atomic combination of LOCK TALBES <list> READ and FLUSH TABLES <list>, and requires respective privileges. For additional information about the semantics, please see WL#5000 and the comment for flush_tables_with_read_lock() function in sql_parse.cc mysql-test/r/flush.result: Update test results (WL#5000). mysql-test/t/flush.test: Add test coverage for WL#5000. sql/sql_yacc.yy: Allow FLUSH TABLES <table_list> WITH READ LOCK. Disallow FLUSH TABLES <table_list>, flush_options.
327 lines
7.4 KiB
Plaintext
327 lines
7.4 KiB
Plaintext
connect (con1,localhost,root,,);
|
|
connect (con2,localhost,root,,);
|
|
connection con1;
|
|
|
|
--disable_warnings
|
|
drop table if exists t1,t2;
|
|
drop database if exists mysqltest;
|
|
--enable_warnings
|
|
|
|
create temporary table t1(n int not null primary key);
|
|
create table t2(n int);
|
|
insert into t2 values(3);
|
|
let $1=100;
|
|
disable_query_log;
|
|
while ($1)
|
|
{
|
|
connection con1;
|
|
send replace into t1 select n from t2;
|
|
connection con2;
|
|
send flush tables;
|
|
connection con1;
|
|
reap;
|
|
connection con2;
|
|
reap;
|
|
dec $1;
|
|
}
|
|
enable_query_log;
|
|
connection con1;
|
|
select * from t1;
|
|
connection con2;
|
|
flush tables with read lock;
|
|
--error 1223
|
|
drop table t2;
|
|
connection con1;
|
|
send drop table t2;
|
|
connection con2;
|
|
unlock tables;
|
|
connection con1;
|
|
reap;
|
|
|
|
#test if drop database will wait until we release the global read lock
|
|
connection con1;
|
|
create database mysqltest;
|
|
create table mysqltest.t1(n int);
|
|
insert into mysqltest.t1 values (23);
|
|
flush tables with read lock;
|
|
connection con2;
|
|
send drop database mysqltest;
|
|
connection con1;
|
|
select * from mysqltest.t1;
|
|
unlock tables;
|
|
connection con2;
|
|
reap;
|
|
|
|
# test if dirty close releases global read lock
|
|
connection con1;
|
|
create table t1 (n int);
|
|
flush tables with read lock;
|
|
dirty_close con1;
|
|
connection con2;
|
|
insert into t1 values (345);
|
|
select * from t1;
|
|
drop table t1;
|
|
|
|
#
|
|
# Bug#9459 - deadlock with flush with lock, and lock table write
|
|
#
|
|
create table t1 (c1 int);
|
|
lock table t1 write;
|
|
# Cannot get the global read lock with write locked tables.
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables with read lock;
|
|
lock table t1 read;
|
|
# Cannot get the global read lock with read locked tables.
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables with read lock;
|
|
unlock tables;
|
|
flush tables with read lock;
|
|
--error 1223
|
|
lock table t1 write;
|
|
lock table t1 read;
|
|
--error 1223
|
|
lock table t1 write;
|
|
# Release all table locks and the global read lock.
|
|
unlock tables;
|
|
create table t2 (c1 int);
|
|
create table t3 (c1 int);
|
|
lock table t1 read, t2 read, t3 write;
|
|
# Cannot get the global read lock with write locked tables.
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables with read lock;
|
|
lock table t1 read, t2 read, t3 read;
|
|
# Cannot get the global read lock with read locked tables.
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables with read lock;
|
|
unlock tables;
|
|
drop table t1, t2, t3;
|
|
|
|
# End of 4.1 tests
|
|
|
|
#
|
|
# Test of deadlock problem when doing FLUSH TABLE with read lock
|
|
# (Bug was in NTPL threads in Linux when using different mutex while
|
|
# waiting for a condtion variable)
|
|
|
|
create table t1 (c1 int);
|
|
create table t2 (c1 int);
|
|
|
|
connect (con1,localhost,root,,);
|
|
connect (con3,localhost,root,,);
|
|
|
|
connection con1;
|
|
lock table t1 write;
|
|
|
|
connection con2;
|
|
send flush tables with read lock;
|
|
--sleep 1
|
|
|
|
connection con3;
|
|
send insert into t2 values(1);
|
|
--sleep 1
|
|
|
|
connection con1;
|
|
unlock tables;
|
|
disconnect con1;
|
|
|
|
connection con2;
|
|
reap;
|
|
disconnect con2;
|
|
|
|
connection con3;
|
|
# It hangs here (insert into t2 does not end).
|
|
reap;
|
|
disconnect con3;
|
|
|
|
connection default;
|
|
drop table t1, t2;
|
|
|
|
#
|
|
# Bug#32528 Global read lock with a low priority write lock causes a server crash
|
|
#
|
|
|
|
--disable_warnings
|
|
drop table if exists t1, t2;
|
|
--enable_warnings
|
|
|
|
set session low_priority_updates=1;
|
|
|
|
create table t1 (a int);
|
|
create table t2 (b int);
|
|
|
|
lock tables t1 write;
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables with read lock;
|
|
unlock tables;
|
|
|
|
lock tables t1 read, t2 write;
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables with read lock;
|
|
unlock tables;
|
|
|
|
lock tables t1 read;
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables with read lock;
|
|
unlock tables;
|
|
|
|
drop table t1, t2;
|
|
|
|
set session low_priority_updates=default;
|
|
|
|
#
|
|
# Bug #33334 mysqltest_embedded crashes when disconnecting before reap
|
|
#
|
|
|
|
connect (con1,localhost,root,,);
|
|
send select benchmark(200, (select sin(1))) > 1000;
|
|
disconnect con1;
|
|
--source include/wait_until_disconnected.inc
|
|
connection default;
|
|
|
|
--echo End of 5.0 tests
|
|
|
|
#
|
|
# Bug #26380: LOCK TABLES + FLUSH LOGS causes deadlock
|
|
#
|
|
set @old_general_log= @@general_log;
|
|
set @old_read_only= @@read_only;
|
|
set global general_log= on;
|
|
|
|
flush tables with read lock;
|
|
flush logs;
|
|
unlock tables;
|
|
|
|
set global read_only=1;
|
|
flush logs;
|
|
unlock tables;
|
|
|
|
flush tables with read lock;
|
|
flush logs;
|
|
unlock tables;
|
|
|
|
set global general_log= @old_general_log;
|
|
set global read_only= @old_read_only;
|
|
|
|
--echo End of 5.1 tests
|
|
|
|
|
|
--echo #
|
|
--echo # Additional test for bug #51136 "Crash in pthread_rwlock_rdlock
|
|
--echo # on TEMPORARY + HANDLER + LOCK + SP".
|
|
--echo # Also see the main test for this bug in include/handler.inc.
|
|
--echo #
|
|
--disable_warnings
|
|
drop tables if exists t1, t2;
|
|
--enable_warnings
|
|
create table t1 (i int);
|
|
create temporary table t2 (j int);
|
|
flush tables with read lock;
|
|
lock table t2 read;
|
|
--echo # This commit should not release any MDL locks.
|
|
commit;
|
|
--echo # The below statement crashed before the bug fix as it
|
|
--echo # has attempted to release global shared metadata lock
|
|
--echo # which was already released by commit.
|
|
unlock tables;
|
|
drop tables t1, t2;
|
|
|
|
|
|
|
|
--echo #
|
|
--echo # Tests for WL#5000 FLUSH TABLES|TABLE table_list WITH READ LOCK
|
|
--echo #
|
|
--echo # I. Check the incompatible changes in the grammar.
|
|
--echo #
|
|
--error ER_PARSE_ERROR
|
|
flush tables with read lock, hosts;
|
|
--error ER_PARSE_ERROR
|
|
flush privileges, tables;
|
|
--error ER_PARSE_ERROR
|
|
flush privileges, tables with read lock;
|
|
--error ER_PARSE_ERROR
|
|
flush privileges, tables;
|
|
--error ER_PARSE_ERROR
|
|
flush tables with read lock, tables;
|
|
show tables;
|
|
--echo #
|
|
--echo # II. Check the allowed syntax.
|
|
--echo #
|
|
--disable_warnings
|
|
drop table if exists t1, t2, t3;
|
|
--enable_warnings
|
|
create table t1 (a int);
|
|
create table t2 (a int);
|
|
create table t3 (a int);
|
|
lock table t1 read, t2 read;
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables with read lock;
|
|
unlock tables;
|
|
flush tables with read lock;
|
|
flush tables t1, t2 with read lock;
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables t1, t2 with read lock;
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
flush tables with read lock;
|
|
select * from t1;
|
|
select * from t2;
|
|
--error ER_TABLE_NOT_LOCKED
|
|
select * from t3;
|
|
--error ER_TABLE_NOT_LOCKED_FOR_WRITE
|
|
insert into t1 (a) values (1);
|
|
--error ER_TABLE_NOT_LOCKED_FOR_WRITE
|
|
insert into t2 (a) values (1);
|
|
--error ER_TABLE_NOT_LOCKED
|
|
insert into t3 (a) values (1);
|
|
--error ER_NO_SUCH_TABLE
|
|
lock table no_such_table read;
|
|
--echo #
|
|
--echo # We implicitly left the locked tables
|
|
--echo # mode but still have the read lock.
|
|
--echo #
|
|
--error ER_CANT_UPDATE_WITH_READLOCK
|
|
insert into t2 (a) values (1);
|
|
unlock tables;
|
|
insert into t1 (a) values (1);
|
|
insert into t2 (a) values (1);
|
|
flush table t1, t2 with read lock;
|
|
select * from t1;
|
|
select * from t2;
|
|
--error ER_TABLE_NOT_LOCKED
|
|
select * from t3;
|
|
--error ER_TABLE_NOT_LOCKED_FOR_WRITE
|
|
insert into t1 (a) values (2);
|
|
--error ER_TABLE_NOT_LOCKED_FOR_WRITE
|
|
insert into t2 (a) values (2);
|
|
--error ER_TABLE_NOT_LOCKED
|
|
insert into t3 (a) values (2);
|
|
--error ER_NO_SUCH_TABLE
|
|
lock table no_such_table read;
|
|
insert into t3 (a) values (2);
|
|
|
|
|
|
--echo #
|
|
--echo # III. Concurrent tests.
|
|
--echo #
|
|
connect (con1,localhost,root,,);
|
|
--echo # --> connection default
|
|
--echo #
|
|
--echo # Check that flush tables <list> with read lock
|
|
--echo # does not affect non-locked tables.
|
|
connection default;
|
|
--echo #
|
|
flush tables t1 with read lock;
|
|
--echo # --> connection con1;
|
|
connection con1;
|
|
select * from t1;
|
|
select * from t2;
|
|
insert into t2 (a) values (3);
|
|
--echo # --> connection default;
|
|
connection default;
|
|
unlock tables;
|
|
--echo # --> connection con1
|
|
connection con1;
|
|
disconnect con1;
|
|
--source include/wait_until_disconnected.inc
|
|
connection default;
|
|
drop table t1, t2, t3;
|