1
0
mirror of https://github.com/MariaDB/server.git synced 2025-04-24 18:27:21 +03:00
Sachin Setiya 16be7469ac MDEV-14849 CREATE + ALTER with user-invisible columns produce ...
Problem:-
  create or replace table t1 (pk int auto_increment primary key invisible, i int);
  alter table t1 modify pk int invisible;
 This last alter makes a invisible column which is not null and does not
 have default value.

Analysis:-
 This is caused because our error check for NOT_NULL_FLAG and
 NO_DEFAULT_VALUE_FLAG flag misses this sql_field , but this is not the fault
 of error check :).Actually this field come via mysql_prepare_alter_table
 and it does not have NO_DEFAULT_VALUE_FLAG flag turned on. (If it was create
 table NO_DEFAULT_VALUE_FLAG would have turned on Column_definition::check)
 and this would have generated error.

Solution:-
 I have moved the error check to kind last of mysql_prepare_create_table
 because upto this point we have applied NO_DEFAULT_VALUE_FLAG to required
 column.
2018-02-02 14:45:44 +05:30
..
2017-11-22 14:39:21 +04:00
2017-12-07 11:41:52 +02:00
2017-10-04 08:24:06 +03:00
2017-10-04 08:24:06 +03:00
2017-08-24 01:05:48 +02:00
2017-10-27 19:21:58 +00:00
2017-08-31 15:44:17 +04:00
2017-12-22 14:56:58 +02:00
2018-01-04 09:22:59 +02:00
2018-01-04 09:22:59 +02:00
2017-08-24 01:05:48 +02:00
2017-03-10 18:21:29 +01:00
2017-03-10 18:21:29 +01:00
2017-11-13 19:09:46 +03:00
2017-03-10 18:21:29 +01:00
2017-11-07 00:37:49 +03:00
2017-09-01 11:33:45 +03:00
2018-01-10 12:36:55 +03:00
2018-01-04 09:22:59 +02:00
2017-11-30 08:16:37 +02:00
2017-11-10 16:12:45 +02:00
2018-01-04 09:22:59 +02:00
2017-11-30 08:16:37 +02:00
2017-11-30 08:16:37 +02:00
2017-12-14 11:34:30 +02:00
2017-11-30 08:16:37 +02:00
2017-11-23 19:41:44 +03:00
2017-11-30 08:16:37 +02:00
2018-01-15 19:11:28 +02:00
2017-12-21 15:22:31 +03:00
2017-04-07 18:09:56 +04:00
2018-01-04 09:22:59 +02:00
2018-01-30 20:47:12 +02:00
2018-01-05 22:52:06 +02:00
2018-01-15 19:11:28 +02:00
2017-06-21 13:44:16 +03:00
2017-12-12 09:57:17 +02:00
2017-03-10 18:21:29 +01:00
2018-01-10 12:36:55 +03:00
2017-12-11 15:43:41 +03:00
2017-08-24 01:05:48 +02:00
2017-03-10 18:21:29 +01:00
2017-11-30 08:16:37 +02:00
2017-08-31 13:46:30 +04:00
2017-08-31 13:46:30 +04:00
2017-08-26 00:34:43 +02:00
2018-01-13 20:37:00 +02:00
2017-08-26 00:34:43 +02:00
2017-10-04 08:24:06 +03:00
2018-01-05 17:11:37 +00:00
2018-01-04 09:22:59 +02:00
2018-01-04 09:22:59 +02:00
2017-12-26 15:24:48 +03:00
2017-11-07 00:37:49 +03:00
2017-11-30 08:16:37 +02:00
2018-01-10 12:36:55 +03:00
2017-09-25 22:05:56 +03:00
2017-11-23 09:49:45 +02:00
2016-10-05 01:11:08 +03:00
2017-10-04 08:24:06 +03:00
2017-10-04 11:59:54 +00:00
2017-08-15 14:13:42 +04:00
2017-08-24 01:05:48 +02:00
2017-04-28 21:59:11 -07:00
2018-01-05 22:52:06 +02:00
2018-01-04 09:22:59 +02:00
2018-01-04 09:22:59 +02:00
2017-03-10 18:21:29 +01:00
2017-05-05 20:36:08 +03:00
2017-11-17 07:30:05 +02:00
2017-03-10 18:21:29 +01:00
2017-12-08 11:38:22 +02:00
2017-10-04 08:24:06 +03:00
2017-05-06 14:36:46 +03:00
2017-06-14 12:02:54 +02:00
2017-11-21 19:47:46 +01:00
2018-01-04 09:22:59 +02:00
2018-01-09 14:16:47 +03:00
2018-01-09 14:16:47 +03:00
2017-11-07 00:37:49 +03:00
2018-01-25 19:48:52 +02:00
2017-11-23 09:49:45 +02:00
2018-01-04 09:22:59 +02:00
2018-01-13 02:01:34 +01:00
2017-03-30 12:48:42 +02:00
2017-11-27 15:07:32 +03:00
2017-10-04 08:24:06 +03:00
2017-10-04 08:24:06 +03:00
2017-09-28 17:20:46 +00:00
2017-11-05 22:23:32 +02:00
2017-03-10 18:21:29 +01:00
2017-11-10 16:12:45 +02:00
2017-03-10 18:21:29 +01:00
2017-03-30 12:48:42 +02:00
2017-09-21 08:12:19 +03:00
2017-08-31 09:30:40 +03:00