1
0
mirror of https://github.com/MariaDB/server.git synced 2025-07-05 12:42:17 +03:00
Files
mariadb/mysql-test/t
Sachin Setiya 16be7469ac MDEV-14849 CREATE + ALTER with user-invisible columns produce ...
Problem:-
  create or replace table t1 (pk int auto_increment primary key invisible, i int);
  alter table t1 modify pk int invisible;
 This last alter makes a invisible column which is not null and does not
 have default value.

Analysis:-
 This is caused because our error check for NOT_NULL_FLAG and
 NO_DEFAULT_VALUE_FLAG flag misses this sql_field , but this is not the fault
 of error check :).Actually this field come via mysql_prepare_alter_table
 and it does not have NO_DEFAULT_VALUE_FLAG flag turned on. (If it was create
 table NO_DEFAULT_VALUE_FLAG would have turned on Column_definition::check)
 and this would have generated error.

Solution:-
 I have moved the error check to kind last of mysql_prepare_create_table
 because upto this point we have applied NO_DEFAULT_VALUE_FLAG to required
 column.
2018-02-02 14:45:44 +05:30
..
2017-02-10 06:30:42 -05:00
2018-01-11 18:00:31 +02:00
2016-09-06 12:50:02 +04:00
2017-10-24 14:53:18 +02:00
2016-09-06 12:50:02 +04:00
2016-09-06 12:50:02 +04:00
2017-10-24 14:53:18 +02:00
2017-12-14 09:53:19 +02:00
2017-12-14 08:40:01 +02:00
2017-02-10 17:01:45 +01:00
2017-10-24 14:53:18 +02:00
2017-02-21 20:31:06 +01:00
2017-05-05 20:36:13 +03:00
2017-05-23 11:09:47 +03:00
2017-03-30 12:48:42 +02:00
2017-11-10 16:12:45 +02:00
2017-04-28 20:19:32 +02:00
2017-02-10 06:30:42 -05:00
2017-07-05 19:08:55 +02:00
2016-12-29 13:23:18 +01:00
2017-10-28 20:54:18 +02:00
2017-06-19 16:56:13 +03:00
2017-09-20 17:47:49 +03:00
2018-01-04 09:22:59 +02:00
2017-12-14 09:53:19 +02:00
2017-05-29 15:46:29 +04:00
2017-03-30 12:48:42 +02:00
2017-10-28 20:54:18 +02:00
2017-06-21 13:44:16 +03:00
2017-06-08 12:45:08 +03:00
2017-02-10 06:30:42 -05:00
2017-10-28 20:54:18 +02:00
2017-09-22 02:27:00 +02:00
2016-09-15 15:31:28 +02:00
2017-02-24 09:40:53 -08:00
2017-12-20 13:30:05 +02:00
2017-05-09 13:24:52 +02:00
2017-02-10 06:30:42 -05:00
2017-06-19 16:46:34 +03:00
2017-07-05 17:15:57 +02:00
2016-09-10 16:04:44 +02:00
2017-02-10 06:30:42 -05:00
2017-02-10 06:30:42 -05:00
2017-05-22 09:46:51 +03:00
2017-02-10 06:30:42 -05:00
2017-10-24 14:53:18 +02:00
2017-06-30 13:28:39 +02:00
2017-11-10 01:14:58 +01:00
2017-07-05 19:08:55 +02:00
2018-01-02 02:03:12 +02:00
2017-02-10 06:30:42 -05:00
2017-12-03 13:58:35 +02:00
2017-03-30 12:48:42 +02:00
2018-01-24 14:00:33 +02:00
2017-12-21 23:36:00 +01:00
2017-10-24 14:53:18 +02:00
2017-02-10 06:30:42 -05:00
2016-12-11 09:53:42 +01:00
2017-02-10 06:30:42 -05:00
2018-01-30 21:04:48 +02:00
2017-08-08 09:56:38 +02:00
2017-03-21 19:20:44 +01:00
2018-01-11 18:00:31 +02:00
2017-03-09 08:53:08 +02:00
2017-11-08 13:12:11 +02:00
2017-05-05 20:36:13 +03:00
2017-11-28 11:40:13 +03:00
2016-09-24 15:12:34 +02:00
2017-12-18 12:24:02 +04:00